From 1f44278e8612c5c2567046f5bd6a82eacccc1e2a Mon Sep 17 00:00:00 2001 From: Dimitri van Heesch Date: Sun, 8 Sep 2013 16:10:13 +0200 Subject: Avoid accessing uninitialized memory in fileToString --- src/bufstr.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/bufstr.h b/src/bufstr.h index 427b012..cfb89c4 100644 --- a/src/bufstr.h +++ b/src/bufstr.h @@ -33,7 +33,7 @@ class BufStr BufStr(int size) : m_size(size), m_writeOffset(0), m_spareRoom(10240), m_buf(0) { - m_buf = (char *)malloc(size); + m_buf = (char *)calloc(size,1); } ~BufStr() { @@ -62,12 +62,17 @@ class BufStr } void resize( uint newlen ) { + uint oldsize = m_size; m_size=newlen; if (m_writeOffset>=m_size) // offset out of range -> enlarge { m_size=m_writeOffset+m_spareRoom; } m_buf = (char *)realloc(m_buf,m_size); + if (m_size>oldsize) + { + memset(m_buf+oldsize,0,m_size-oldsize); + } } int size() const { -- cgit v0.12