From a95ab819972148fef8287353e13089fd8cacebb8 Mon Sep 17 00:00:00 2001 From: Dimitri van Heesch Date: Sat, 28 Nov 2020 17:02:52 +0100 Subject: Refactoring: make setAnchors() a member of MemberList --- src/classdef.cpp | 2 +- src/filedef.cpp | 2 +- src/groupdef.cpp | 2 +- src/membergroup.cpp | 2 +- src/memberlist.cpp | 18 ++++++++++++++++++ src/memberlist.h | 5 ++--- src/namespacedef.cpp | 2 +- src/util.cpp | 18 ------------------ src/util.h | 2 -- 9 files changed, 25 insertions(+), 28 deletions(-) diff --git a/src/classdef.cpp b/src/classdef.cpp index 572b550..98cfc86 100644 --- a/src/classdef.cpp +++ b/src/classdef.cpp @@ -1144,7 +1144,7 @@ void ClassDefImpl::computeAnchors() { if ((ml->listType()&MemberListType_detailedLists)==0) { - setAnchors(ml); + ml->setAnchors(); } } diff --git a/src/filedef.cpp b/src/filedef.cpp index c2020e1..0fdcdd3 100644 --- a/src/filedef.cpp +++ b/src/filedef.cpp @@ -288,7 +288,7 @@ void FileDefImpl::setDiskName(const QCString &name) void FileDefImpl::computeAnchors() { MemberList *ml = getMemberList(MemberListType_allMembersList); - if (ml) setAnchors(ml); + if (ml) ml->setAnchors(); } void FileDefImpl::distributeMemberGroupDocumentation() diff --git a/src/groupdef.cpp b/src/groupdef.cpp index 2e01d64..bad8526 100644 --- a/src/groupdef.cpp +++ b/src/groupdef.cpp @@ -665,7 +665,7 @@ int GroupDefImpl::numDocMembers() const void GroupDefImpl::computeAnchors() { //printf("GroupDefImpl::computeAnchors()\n"); - setAnchors(m_allMemberList); + m_allMemberList->setAnchors(); } void GroupDefImpl::writeTagFile(FTextStream &tagFile) diff --git a/src/membergroup.cpp b/src/membergroup.cpp index d8d6193..bd3bf0c 100644 --- a/src/membergroup.cpp +++ b/src/membergroup.cpp @@ -86,7 +86,7 @@ void MemberGroup::insertMember(MemberDef *md) void MemberGroup::setAnchors() { - ::setAnchors(memberList); + memberList->setAnchors(); } void MemberGroup::writeDeclarations(OutputList &ol, diff --git a/src/memberlist.cpp b/src/memberlist.cpp index ed10bed..d8700d4 100644 --- a/src/memberlist.cpp +++ b/src/memberlist.cpp @@ -1143,6 +1143,24 @@ void MemberList::writeTagFile(FTextStream &tagFile) } } +// compute the HTML anchors for a list of members +void MemberList::setAnchors() +{ + //int count=0; + MemberListIterator mli(*this); + MemberDef *md; + for (;(md=mli.current());++mli) + { + MemberDefMutable *mdm = toMemberDefMutable(md); + if (mdm && !md->isReference()) + { + mdm->setAnchor(); + } + } +} + + + //-------------------------------------------------------------------------- int MemberSDict::compareValues(const MemberDef *c1, const MemberDef *c2) const diff --git a/src/memberlist.h b/src/memberlist.h index 7ee8925..e62655b 100644 --- a/src/memberlist.h +++ b/src/memberlist.h @@ -1,8 +1,6 @@ /****************************************************************************** * - * - * - * Copyright (C) 1997-2015 by Dimitri van Heesch. + * Copyright (C) 1997-2020 by Dimitri van Heesch. * * Permission to use, copy, modify, and distribute this software and its * documentation under the terms of the GNU General Public License is hereby @@ -92,6 +90,7 @@ class MemberList : private QList void setNeedsSorting(bool b); MemberGroupList *getMemberGroupList() const { return memberGroupList; } void setAnonymousEnumType(); + void setAnchors(); private: int compareValues(const MemberDef *item1,const MemberDef *item2) const; diff --git a/src/namespacedef.cpp b/src/namespacedef.cpp index cef836a..0c55573 100644 --- a/src/namespacedef.cpp +++ b/src/namespacedef.cpp @@ -559,7 +559,7 @@ void NamespaceDefImpl::insertMember(MemberDef *md) void NamespaceDefImpl::computeAnchors() { MemberList *allMemberList = getMemberList(MemberListType_allMembersList); - if (allMemberList) setAnchors(allMemberList); + if (allMemberList) allMemberList->setAnchors(); } bool NamespaceDefImpl::hasDetailedDescription() const diff --git a/src/util.cpp b/src/util.cpp index 0d94138..c71d3c7 100644 --- a/src/util.cpp +++ b/src/util.cpp @@ -1229,24 +1229,6 @@ QCString tempArgListToString(const ArgumentList &al,SrcLangExt lang,bool include } -// compute the HTML anchors for a list of members -// TODO: make member of MemberList -void setAnchors(MemberList *ml) -{ - //int count=0; - if (ml==0) return; - MemberListIterator mli(*ml); - MemberDef *md; - for (;(md=mli.current());++mli) - { - MemberDefMutable *mdm = toMemberDefMutable(md); - if (mdm && !md->isReference()) - { - mdm->setAnchor(); - } - } -} - //---------------------------------------------------------------------------- /*! takes the \a buf of the given length \a len and converts CR LF (DOS) diff --git a/src/util.h b/src/util.h index 19c30c8..c3fc6ba 100644 --- a/src/util.h +++ b/src/util.h @@ -137,8 +137,6 @@ void linkifyText(const TextGeneratorIntf &ol, int indentLevel=0 ); -void setAnchors(MemberList *ml); - QCString fileToString(const char *name,bool filter=FALSE,bool isSourceCode=FALSE); QCString dateToString(bool); -- cgit v0.12