From a481a84fdf39cdf40b38ebaad86b2a159db4c383 Mon Sep 17 00:00:00 2001
From: albert-github <albert.tests@gmail.com>
Date: Sun, 1 Dec 2013 15:16:26 +0100
Subject: Bug 719639 - @xrefitem with empty heading string

Replaced:
  if (!(x->title().length())) return;
by:
  if (x->title().isEmpty()) return;
---
 src/docbookvisitor.cpp  | 4 ++--
 src/htmldocvisitor.cpp  | 4 ++--
 src/latexdocvisitor.cpp | 4 ++--
 src/mandocvisitor.cpp   | 4 ++--
 src/perlmodgen.cpp      | 4 ++--
 src/rtfdocvisitor.cpp   | 4 ++--
 src/xmldocvisitor.cpp   | 4 ++--
 7 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/docbookvisitor.cpp b/src/docbookvisitor.cpp
index 151f12d..aaea045 100644
--- a/src/docbookvisitor.cpp
+++ b/src/docbookvisitor.cpp
@@ -1160,7 +1160,7 @@ void DocbookDocVisitor::visitPost(DocParamList *)
 void DocbookDocVisitor::visitPre(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   m_t << "<para><link linkend=\"";
   m_t << x->file() << "_1" << x->anchor();
   m_t << "\">";
@@ -1172,7 +1172,7 @@ void DocbookDocVisitor::visitPre(DocXRefItem *x)
 void DocbookDocVisitor::visitPost(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   m_t << "</para>";
 }
 
diff --git a/src/htmldocvisitor.cpp b/src/htmldocvisitor.cpp
index ecdafe6..815a16d 100644
--- a/src/htmldocvisitor.cpp
+++ b/src/htmldocvisitor.cpp
@@ -1777,7 +1777,7 @@ void HtmlDocVisitor::visitPost(DocParamList *)
 void HtmlDocVisitor::visitPre(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
 
   forceEndParagraph(x);
   bool anonymousEnum = x->file()=="@";
@@ -1800,7 +1800,7 @@ void HtmlDocVisitor::visitPre(DocXRefItem *x)
 void HtmlDocVisitor::visitPost(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   m_t << "</dd></dl>" << endl;
   forceStartParagraph(x);
 }
diff --git a/src/latexdocvisitor.cpp b/src/latexdocvisitor.cpp
index e6448b1..91064a3 100644
--- a/src/latexdocvisitor.cpp
+++ b/src/latexdocvisitor.cpp
@@ -1515,7 +1515,7 @@ void LatexDocVisitor::visitPost(DocParamList *pl)
 void LatexDocVisitor::visitPre(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   m_t << "\\begin{DoxyRefDesc}{";
   filter(x->title());
   m_t << "}" << endl;
@@ -1538,7 +1538,7 @@ void LatexDocVisitor::visitPre(DocXRefItem *x)
 void LatexDocVisitor::visitPost(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   m_t << "\\end{DoxyRefDesc}" << endl;
 }
 
diff --git a/src/mandocvisitor.cpp b/src/mandocvisitor.cpp
index d4da7aa..729f3d4 100644
--- a/src/mandocvisitor.cpp
+++ b/src/mandocvisitor.cpp
@@ -933,7 +933,7 @@ void ManDocVisitor::visitPost(DocParamList *pl)
 void ManDocVisitor::visitPre(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   if (!m_firstCol)
   { 
     m_t << endl;
@@ -948,7 +948,7 @@ void ManDocVisitor::visitPre(DocXRefItem *x)
 void ManDocVisitor::visitPost(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   if (!m_firstCol) m_t << endl;
   m_t << ".RE" << endl;
   m_t << ".PP" << endl;
diff --git a/src/perlmodgen.cpp b/src/perlmodgen.cpp
index dd0dbbb..5537438 100644
--- a/src/perlmodgen.cpp
+++ b/src/perlmodgen.cpp
@@ -1360,14 +1360,14 @@ void PerlModDocVisitor::visitPre(DocXRefItem *x)
   m_output.add("</xreftitle>");
   m_output.add("<xrefdescription>");
 #endif
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   openItem("xrefitem");
   openSubBlock("content");
 }
 
 void PerlModDocVisitor::visitPost(DocXRefItem *x)
 {
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   closeSubBlock();
   closeItem();
 #if 0
diff --git a/src/rtfdocvisitor.cpp b/src/rtfdocvisitor.cpp
index d83d8c0..866c660 100644
--- a/src/rtfdocvisitor.cpp
+++ b/src/rtfdocvisitor.cpp
@@ -1579,7 +1579,7 @@ void RTFDocVisitor::visitPost(DocParamList *pl)
 void RTFDocVisitor::visitPre(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   bool anonymousEnum = x->file()=="@";
   DBG_RTF("{\\comment RTFDocVisitor::visitPre(DocXRefItem)}\n");
   m_t << "{"; // start param list
@@ -1628,7 +1628,7 @@ void RTFDocVisitor::visitPre(DocXRefItem *x)
 void RTFDocVisitor::visitPost(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   DBG_RTF("{\\comment RTFDocVisitor::visitPost(DocXRefItem)}\n");
   m_t << "\\par" << endl;
   decIndentLevel();
diff --git a/src/xmldocvisitor.cpp b/src/xmldocvisitor.cpp
index c4357f6..8df1acf 100644
--- a/src/xmldocvisitor.cpp
+++ b/src/xmldocvisitor.cpp
@@ -1012,7 +1012,7 @@ void XmlDocVisitor::visitPost(DocParamList *)
 void XmlDocVisitor::visitPre(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   m_t << "<xrefsect id=\"";
   m_t << x->file() << "_1" << x->anchor();
   m_t << "\">";
@@ -1025,7 +1025,7 @@ void XmlDocVisitor::visitPre(DocXRefItem *x)
 void XmlDocVisitor::visitPost(DocXRefItem *x)
 {
   if (m_hide) return;
-  if (!(x->title().length())) return;
+  if (x->title().isEmpty()) return;
   m_t << "</xrefdescription>";
   m_t << "</xrefsect>";
 }
-- 
cgit v0.12