From 4ed08b969b575d6dc1a49bca936a43eb43d337e2 Mon Sep 17 00:00:00 2001
From: Dimitri van Heesch <dimitri@stack.nl>
Date: Sat, 24 Nov 2018 18:55:02 +0100
Subject: Refactored code a bit

---
 src/reflist.cpp | 30 ++++++++++--------------------
 1 file changed, 10 insertions(+), 20 deletions(-)

diff --git a/src/reflist.cpp b/src/reflist.cpp
index 59f7ad4..6f2a763 100644
--- a/src/reflist.cpp
+++ b/src/reflist.cpp
@@ -169,29 +169,19 @@ void RefList::generatePage()
     doc += item->prefix;
     doc += " \\_internalref ";
     doc += item->name;
-    doc += " \"";
     // escape \'s in title, see issue #5901
-    // prevent Obj-C names in e.g. todo list are seen as emoji
-    if (item->scope)
-    {
-      switch(item->scope->definitionType())
-      {
-        case Definition::TypeClass:
-        case Definition::TypeNamespace:
-        case Definition::TypeMember:
-        case Definition::TypePackage:
-          doc += substitute(substitute(item->title,"\\","\\\\"),":","&Colon;");
-          break;
-        default:
-          doc += substitute(item->title,"\\","\\\\");
-          break;
-      }
-    }
-    else
+    QCString escapedTitle = substitute(item->title,"\\","\\\\");
+    if (item->scope &&
+        (item->scope->definitionType()==Definition::TypeClass ||
+         item->scope->definitionType()==Definition::TypeNamespace ||
+         item->scope->definitionType()==Definition::TypeMember ||
+         item->scope->definitionType()==Definition::TypePackage)
+       )
     {
-      doc += substitute(item->title,"\\","\\\\");
+      // prevent Obj-C names in e.g. todo list are seen as emoji
+      escapedTitle = substitute(escapedTitle,":","&Colon;");
     }
-    doc += "\" ";
+    doc += " \""+escapedTitle+"\" ";
     // write declaration in case a function with arguments
     if (!item->args.isEmpty()) 
     {
-- 
cgit v0.12