diff options
| author | Jan Niklas Hasse <jhasse@bixense.com> | 2020-11-10 11:34:44 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-10 11:34:44 (GMT) |
| commit | 3094b5c289b418b31e63ad2e7f52a38cf64e3dfc (patch) | |
| tree | e938030fcc49419fca00d145f65ff587f9a68b01 | |
| parent | 17bcd4c8d69d3e5a0d11092938d30ac29aeb65e1 (diff) | |
| parent | 9fa3491284af9a595cd46c6b230bcffb0ab8aec9 (diff) | |
| download | Ninja-3094b5c289b418b31e63ad2e7f52a38cf64e3dfc.zip Ninja-3094b5c289b418b31e63ad2e7f52a38cf64e3dfc.tar.gz Ninja-3094b5c289b418b31e63ad2e7f52a38cf64e3dfc.tar.bz2 | |
Merge pull request #1787 from neheb/str
[clang-tidy] remove pointless string init
| -rw-r--r-- | .clang-tidy | 2 | ||||
| -rw-r--r-- | src/string_piece_util_test.cc | 4 |
2 files changed, 4 insertions, 2 deletions
diff --git a/.clang-tidy b/.clang-tidy index 8968011..df4c1ed 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -3,9 +3,11 @@ Checks: ' ,readability-avoid-const-params-in-decls, ,readability-non-const-parameter, ,readability-redundant-string-cstr, + ,readability-redundant-string-init, ' WarningsAsErrors: ' ,readability-avoid-const-params-in-decls, ,readability-non-const-parameter, ,readability-redundant-string-cstr, + ,readability-redundant-string-init, ' diff --git a/src/string_piece_util_test.cc b/src/string_piece_util_test.cc index b77ae84..61586dd 100644 --- a/src/string_piece_util_test.cc +++ b/src/string_piece_util_test.cc @@ -31,7 +31,7 @@ TEST(StringPieceUtilTest, SplitStringPiece) { } { - string empty(""); + string empty; vector<StringPiece> list = SplitStringPiece(empty, ':'); EXPECT_EQ(list.size(), 1); @@ -82,7 +82,7 @@ TEST(StringPieceUtilTest, JoinStringPiece) { } { - string empty(""); + string empty; vector<StringPiece> list = SplitStringPiece(empty, ':'); EXPECT_EQ("", JoinStringPiece(list, ':')); |