diff options
author | Nico Weber <thakis@chromium.org> | 2014-05-18 00:20:20 (GMT) |
---|---|---|
committer | Nico Weber <thakis@chromium.org> | 2014-05-18 00:20:20 (GMT) |
commit | b0ada0efd9ee1d80d38c781fa15d73bece4a3d69 (patch) | |
tree | fb80ed9afefe1921d6ad170ce41bfa4908c06933 | |
parent | c246b586a4191d8eca21761b15466b047008489f (diff) | |
download | Ninja-b0ada0efd9ee1d80d38c781fa15d73bece4a3d69.zip Ninja-b0ada0efd9ee1d80d38c781fa15d73bece4a3d69.tar.gz Ninja-b0ada0efd9ee1d80d38c781fa15d73bece4a3d69.tar.bz2 |
win console wip: Fix comments based on review feedback.
-rw-r--r-- | src/subprocess-posix.cc | 2 | ||||
-rw-r--r-- | src/subprocess-win32.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/subprocess-posix.cc b/src/subprocess-posix.cc index 6e4b47c..743e406 100644 --- a/src/subprocess-posix.cc +++ b/src/subprocess-posix.cc @@ -85,7 +85,7 @@ bool Subprocess::Start(SubprocessSet* set, const string& command) { error_pipe = 2; close(output_pipe[1]); } - // In the console case, child_pipe is still inherited by the child and + // In the console case, output_pipe is still inherited by the child and // closed when the subprocess finishes, which then notifies ninja. execl("/bin/sh", "/bin/sh", "-c", command.c_str(), (char *) NULL); diff --git a/src/subprocess-win32.cc b/src/subprocess-win32.cc index 4fa24c6..fad66e8 100644 --- a/src/subprocess-win32.cc +++ b/src/subprocess-win32.cc @@ -277,7 +277,7 @@ void SubprocessSet::Clear() { for (vector<Subprocess*>::iterator i = running_.begin(); i != running_.end(); ++i) { // Since the foreground process is in our process group, it will receive a - // CTRL_BREAK_EVENT at the same time as us. + // CTRL_C_EVENT or CTRL_BREAK_EVENT at the same time as us. if ((*i)->child_ && !(*i)->use_console_) { if (!GenerateConsoleCtrlEvent(CTRL_BREAK_EVENT, GetProcessId((*i)->child_))) { |