metrics: use chrono to convert ticks to micros

This was previously causing undefined behavior, as multiplying dt by 1000000
overflowed on some systems. Fixes #2301.

1 files changed, 7 insertions, 2 deletions

diff --git a/src/metrics.cc b/src/metrics.cc
index 9a4dd12..632ae43 100644
--- a/src/metrics.cc
+++ b/src/metrics.cc
@@ -48,12 +48,17 @@ constexpr int64_t GetFrequency() {
 
 int64_t TimerToMicros(int64_t dt) {
   // dt is in ticks.  We want microseconds.
-  return (dt * 1000000) / GetFrequency();
+  return chrono::duration_cast<chrono::microseconds>(
+             std::chrono::steady_clock::duration{ dt })
+      .count();
 }
 
 int64_t TimerToMicros(double dt) {
   // dt is in ticks.  We want microseconds.
-  return (dt * 1000000) / GetFrequency();
+  using DoubleSteadyClock =
+      std::chrono::duration<double, std::chrono::steady_clock::period>;
+  return chrono::duration_cast<chrono::microseconds>(DoubleSteadyClock{ dt })
+      .count();
 }
 
 }  // anonymous namespace