summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNico Weber <nicolasweber@gmx.de>2016-03-05 01:43:33 (GMT)
committerNico Weber <nicolasweber@gmx.de>2016-03-05 01:43:33 (GMT)
commitd63fe50c493c397bae3b4a3dd08cfac128000a81 (patch)
treeee95c94021b3fe965c211f41d15db732c2e2c0e0
parentd1763746b65cc7349d4ed9478befdb651aa24589 (diff)
parent1a8e5455939ed3f701141cc72262add9a7d75055 (diff)
downloadNinja-d63fe50c493c397bae3b4a3dd08cfac128000a81.zip
Ninja-d63fe50c493c397bae3b4a3dd08cfac128000a81.tar.gz
Ninja-d63fe50c493c397bae3b4a3dd08cfac128000a81.tar.bz2
Merge pull request #1102 from bradking/remove-unnecessary-StatIfNecessary
Remove StatIfNecessary call that is never necessary
-rw-r--r--src/graph.cc3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/graph.cc b/src/graph.cc
index 98a2c18..f1d9ca2 100644
--- a/src/graph.cc
+++ b/src/graph.cc
@@ -37,6 +37,7 @@ bool DependencyScan::RecomputeDirty(Edge* edge, string* err) {
edge->outputs_ready_ = true;
edge->deps_missing_ = false;
+ // Load output mtimes so we can compare them to the most recent input below.
// RecomputeDirty() recursively walks the graph following the input nodes
// of |edge| and the in_edges of these nodes. It uses the stat state of each
// node to mark nodes as visited and doesn't traverse across nodes that have
@@ -126,8 +127,6 @@ bool DependencyScan::RecomputeOutputsDirty(Edge* edge, Node* most_recent_input,
string command = edge->EvaluateCommand(/*incl_rsp_file=*/true);
for (vector<Node*>::iterator o = edge->outputs_.begin();
o != edge->outputs_.end(); ++o) {
- if (!(*o)->StatIfNecessary(disk_interface_, err))
- return false;
if (RecomputeOutputDirty(edge, most_recent_input, command, *o)) {
*outputs_dirty = true;
return true;