diff options
author | Nico Weber <nicolasweber@gmx.de> | 2012-05-10 03:25:07 (GMT) |
---|---|---|
committer | Nico Weber <nicolasweber@gmx.de> | 2012-05-10 03:25:07 (GMT) |
commit | 5cd73252cdc54f554a95ae76914758104fc51552 (patch) | |
tree | 1f6bb411723c80f583b5141519b581f3534bf857 | |
parent | d603d538434fc69b99e036303451829b802cc86d (diff) | |
download | Ninja-5cd73252cdc54f554a95ae76914758104fc51552.zip Ninja-5cd73252cdc54f554a95ae76914758104fc51552.tar.gz Ninja-5cd73252cdc54f554a95ae76914758104fc51552.tar.bz2 |
Add a BuildLog test that checks duplicate version headers don't crash.
-rw-r--r-- | src/build_log_test.cc | 31 |
1 files changed, 31 insertions, 0 deletions
diff --git a/src/build_log_test.cc b/src/build_log_test.cc index 84a4ca5..332a73e 100644 --- a/src/build_log_test.cc +++ b/src/build_log_test.cc @@ -185,3 +185,34 @@ TEST_F(BuildLogTest, SpacesInOutputV4) { ASSERT_EQ(456, e->restat_mtime); ASSERT_EQ("command", e->command); } + +TEST_F(BuildLogTest, DuplicateVersionHeader) { + // Old versions of ninja accidentally wrote multiple version headers to the + // build log on Windows. This shouldn't crash, and the second version header + // should be ignored. + FILE* f = fopen(kTestFilename, "wb"); + fprintf(f, "# ninja log v4\n"); + fprintf(f, "123\t456\t456\tout\tcommand\n"); + fprintf(f, "# ninja log v4\n"); + fprintf(f, "456\t789\t789\tout2\tcommand2\n"); + fclose(f); + + string err; + BuildLog log; + EXPECT_TRUE(log.Load(kTestFilename, &err)); + ASSERT_EQ("", err); + + BuildLog::LogEntry* e = log.LookupByOutput("out"); + ASSERT_TRUE(e); + ASSERT_EQ(123, e->start_time); + ASSERT_EQ(456, e->end_time); + ASSERT_EQ(456, e->restat_mtime); + ASSERT_EQ("command", e->command); + + e = log.LookupByOutput("out2"); + ASSERT_TRUE(e); + ASSERT_EQ(456, e->start_time); + ASSERT_EQ(789, e->end_time); + ASSERT_EQ(789, e->restat_mtime); + ASSERT_EQ("command2", e->command); +} |