diff options
author | Evan Martin <martine@danga.com> | 2012-07-18 00:38:48 (GMT) |
---|---|---|
committer | Evan Martin <martine@danga.com> | 2012-07-18 00:38:48 (GMT) |
commit | 8a37bfffcbea27ffbb9168b2740476336cd4963a (patch) | |
tree | 858b58f1fb26898be995f6540eb03430ad8e2130 /src/build.cc | |
parent | 42163db5edfd6865a05226af23f99aef3622f550 (diff) | |
download | Ninja-8a37bfffcbea27ffbb9168b2740476336cd4963a.zip Ninja-8a37bfffcbea27ffbb9168b2740476336cd4963a.tar.gz Ninja-8a37bfffcbea27ffbb9168b2740476336cd4963a.tar.bz2 |
disallow crlf in manifest files
It turns out to be trickier than expected to process these correctly.
It turns out to also be trickier than expected to give a nice error
message on encountering these. But the behavior prior to this patch
would just be silent failures where we attempted to examine paths
that accidentally contained embedded \r.
For now, fix all regexes of the form [^...] to include \r in the
excluded block, then assert that we get a vague lexer error near the
problem.
In the future perhaps we can open manifest files in text mode on Windows
or just disallow Windows-style CRLF in the manual.
Diffstat (limited to 'src/build.cc')
0 files changed, 0 insertions, 0 deletions