summaryrefslogtreecommitdiffstats
path: root/src/build.cc
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2015-11-13 18:05:51 (GMT)
committerBrad King <brad.king@kitware.com>2017-06-19 15:08:26 (GMT)
commitafe3beb980a4780caecc12d3fc919feb3f9cce42 (patch)
tree4c5be698e3e8ec0dacb7fb4c2738fe79ffcae3cd /src/build.cc
parent29a6e2fc6c671b9490193d4b235b53fb61886c80 (diff)
downloadNinja-afe3beb980a4780caecc12d3fc919feb3f9cce42.zip
Ninja-afe3beb980a4780caecc12d3fc919feb3f9cce42.tar.gz
Ninja-afe3beb980a4780caecc12d3fc919feb3f9cce42.tar.bz2
Refactor RecomputeDirty to take a node instead of an edge
All call sites have a node on which they call `in_edge()` to call RecomputeDirty. Simplify call sites by taking the node directly and calling `in_edge()` internally.
Diffstat (limited to 'src/build.cc')
-rw-r--r--src/build.cc5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/build.cc b/src/build.cc
index 8f4169b..c2a615a 100644
--- a/src/build.cc
+++ b/src/build.cc
@@ -640,9 +640,10 @@ Node* Builder::AddTarget(const string& name, string* err) {
}
bool Builder::AddTarget(Node* node, string* err) {
+ if (!scan_.RecomputeDirty(node, err))
+ return false;
+
if (Edge* in_edge = node->in_edge()) {
- if (!scan_.RecomputeDirty(in_edge, err))
- return false;
if (in_edge->outputs_ready())
return true; // Nothing to do.
}