summaryrefslogtreecommitdiffstats
path: root/src/build.h
diff options
context:
space:
mode:
authorBrad King <brad.king@kitware.com>2016-04-19 19:57:49 (GMT)
committerBrad King <brad.king@kitware.com>2016-04-19 19:59:08 (GMT)
commit87b57e88755f130159b759b8a9954c362bc463d4 (patch)
tree3af9e927797da3fe1cc75adc662fb847d91dca17 /src/build.h
parent10ef5bf7f965b92e79777309f62ffc3fc9787065 (diff)
downloadNinja-87b57e88755f130159b759b8a9954c362bc463d4.zip
Ninja-87b57e88755f130159b759b8a9954c362bc463d4.tar.gz
Ninja-87b57e88755f130159b759b8a9954c362bc463d4.tar.bz2
Improve Plan::EdgeFinished signature
Use an enumeration instead of a boolean to clarify the purpose of arguments at call sites. Suggested-by: Nico Weber <nicolasweber@gmx.de>
Diffstat (limited to 'src/build.h')
-rw-r--r--src/build.h7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/build.h b/src/build.h
index 3a7183f..51589ef 100644
--- a/src/build.h
+++ b/src/build.h
@@ -56,8 +56,13 @@ struct Plan {
/// Dumps the current state of the plan.
void Dump();
+ enum EdgeResult {
+ kEdgeFailed,
+ kEdgeSucceeded
+ };
+
/// Mark an edge as done building (whether it succeeded or failed).
- void EdgeFinished(Edge* edge, bool success);
+ void EdgeFinished(Edge* edge, EdgeResult result);
/// Clean the given node during the build.
/// Return false on error.