Return non-zero status when errors occur.

Clean all was not returning non-zero when an error occur (like when
failing to remove a directory). This patch fix the problem and add a test
for it.

1 files changed, 5 insertions, 4 deletions

diff --git a/src/ninja_test.cc b/src/ninja_test.cc
index e8e7f08..8d53343 100644
--- a/src/ninja_test.cc
+++ b/src/ninja_test.cc
@@ -114,9 +114,9 @@ struct StatTest : public StateTestWithBuiltinRules,
     assert(false);
     return "";
   }
-  virtual bool RemoveFile(const string& path) {
+  virtual int RemoveFile(const string& path) {
     assert(false);
-    return false;
+    return 0;
   }
 
   map<string, time_t> mtimes_;
@@ -262,6 +262,7 @@ TEST_F(DiskInterfaceTest, RemoveFile) {
   string cmd = "touch ";
   cmd += kFileName;
   ASSERT_EQ(0, system(cmd.c_str()));
-  EXPECT_TRUE(disk_.RemoveFile(kFileName));
-  EXPECT_FALSE(disk_.RemoveFile(kFileName));
+  EXPECT_EQ(0, disk_.RemoveFile(kFileName));
+  EXPECT_EQ(1, disk_.RemoveFile(kFileName));
+  EXPECT_EQ(-1, disk_.RemoveFile("does not exist"));
 }