diff options
| author | Nico Weber <thakis@chromium.org> | 2014-05-14 10:00:34 (GMT) |
|---|---|---|
| committer | Nico Weber <thakis@chromium.org> | 2014-05-14 10:00:34 (GMT) |
| commit | c246b586a4191d8eca21761b15466b047008489f (patch) | |
| tree | a3067be92da87662130b239b3aad9d30e7ac0380 /src | |
| parent | 6d5cdede695cd08064f9b7e76b7e4b77a5a78c0c (diff) | |
| download | Ninja-c246b586a4191d8eca21761b15466b047008489f.zip Ninja-c246b586a4191d8eca21761b15466b047008489f.tar.gz Ninja-c246b586a4191d8eca21761b15466b047008489f.tar.bz2 | |
win console wip: resolve FIXME
Diffstat (limited to 'src')
| -rw-r--r-- | src/subprocess-posix.cc | 1 | ||||
| -rw-r--r-- | src/subprocess-win32.cc | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/subprocess-posix.cc b/src/subprocess-posix.cc index 7311f64..6e4b47c 100644 --- a/src/subprocess-posix.cc +++ b/src/subprocess-posix.cc @@ -65,6 +65,7 @@ bool Subprocess::Start(SubprocessSet* set, const string& command) { break; if (!use_console_) { + // Put the child in its own process group, so ctrl-c won't reach it. if (setpgid(0, 0) < 0) break; diff --git a/src/subprocess-win32.cc b/src/subprocess-win32.cc index 59b2d37..4fa24c6 100644 --- a/src/subprocess-win32.cc +++ b/src/subprocess-win32.cc @@ -277,7 +277,7 @@ void SubprocessSet::Clear() { for (vector<Subprocess*>::iterator i = running_.begin(); i != running_.end(); ++i) { // Since the foreground process is in our process group, it will receive a - // SIGINT at the same time as us. XXX is this true on windows? + // CTRL_BREAK_EVENT at the same time as us. if ((*i)->child_ && !(*i)->use_console_) { if (!GenerateConsoleCtrlEvent(CTRL_BREAK_EVENT, GetProcessId((*i)->child_))) { |