refactor

1 files changed, 8 insertions, 7 deletions

diff --git a/src/parsers.cc b/src/parsers.cc
index 3c392db..d2368f4 100644
--- a/src/parsers.cc
+++ b/src/parsers.cc
@@ -327,21 +327,22 @@ bool ManifestParser::ParseRule(string* err) {
       if (!ParseLet(&key, &val, false, err))
         return false;
 
-      string parse_err;
+      EvalString* eval_target = NULL;
       if (key == "command") {
-        if (!rule->ParseCommand(val, &parse_err))
-          return tokenizer_.Error(parse_err, err);
+        eval_target = &rule->command_;
       } else if (key == "depfile") {
-        if (!rule->depfile_.Parse(val, &parse_err))
-          return tokenizer_.Error(parse_err, err);
+        eval_target = &rule->depfile_;
       } else if (key == "description") {
-        if (!rule->description_.Parse(val, &parse_err))
-          return tokenizer_.Error(parse_err, err);
+        eval_target = &rule->description_;
       } else {
         // Die on other keyvals for now; revisit if we want to add a
         // scope here.
         return let_loc.Error("unexpected variable '" + key + "'", err);
       }
+
+      string parse_err;
+      if (!eval_target->Parse(val, &parse_err))
+        return tokenizer_.Error(parse_err, err);
     }
     tokenizer_.ConsumeToken();
   }