diff options
Diffstat (limited to 'src/ninja.cc')
-rw-r--r-- | src/ninja.cc | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/src/ninja.cc b/src/ninja.cc index a5e8d81..7bb5ce3 100644 --- a/src/ninja.cc +++ b/src/ninja.cc @@ -140,7 +140,7 @@ int GuessParallelism() { /// An implementation of ManifestParser::FileReader that actually reads /// the file. struct RealFileReader : public ManifestParser::FileReader { - bool ReadFile(const string& path, string* content, string* err) { + virtual bool ReadFile(const string& path, string* content, string* err) { return ::ReadFile(path, content, err) == 0; } }; @@ -292,7 +292,7 @@ int ToolBrowse(Globals* globals, int argc, char* argv[]) { } #endif // _WIN32 -#if defined(WIN32) +#if defined(_WIN32) int ToolMSVC(Globals* globals, int argc, char* argv[]) { // Reset getopt: push one argument onto the front of argv, reset optind. argc++; @@ -537,7 +537,7 @@ int ChooseTool(const string& tool_name, const Tool** tool_out) { { "browse", "browse dependency graph in a web browser", Tool::RUN_AFTER_LOAD, ToolBrowse }, #endif -#if defined(WIN32) +#if defined(_WIN32) { "msvc", "build helper for MSVC cl.exe (EXPERIMENTAL)", Tool::RUN_AFTER_FLAGS, ToolMSVC }, #endif @@ -743,7 +743,7 @@ int NinjaMain(int argc, char** argv) { int opt; while (tool_name.empty() && - (opt = getopt_long(argc, argv, "d:f:hj:k:l:nt:vC:V", kLongOptions, + (opt = getopt_long(argc, argv, "d:f:j:k:l:nt:vC:h", kLongOptions, NULL)) != -1) { switch (opt) { case 'd': @@ -756,14 +756,6 @@ int NinjaMain(int argc, char** argv) { case 'j': config.parallelism = atoi(optarg); break; - case 'l': { - char* end; - double value = strtod(optarg, &end); - if (end == optarg) - Fatal("-l parameter not numeric: did you mean -l 0.0?"); - config.max_load_average = value; - break; - } case 'k': { char* end; int value = strtol(optarg, &end, 10); @@ -776,15 +768,23 @@ int NinjaMain(int argc, char** argv) { config.failures_allowed = value > 0 ? value : INT_MAX; break; } + case 'l': { + char* end; + double value = strtod(optarg, &end); + if (end == optarg) + Fatal("-l parameter not numeric: did you mean -l 0.0?"); + config.max_load_average = value; + break; + } case 'n': config.dry_run = true; break; - case 'v': - config.verbosity = BuildConfig::VERBOSE; - break; case 't': tool_name = optarg; break; + case 'v': + config.verbosity = BuildConfig::VERBOSE; + break; case 'C': working_dir = optarg; break; |