| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|\
| |
| | |
subprocess_test: gracefully handle rlim.rlim_cur < kNumProcs
|
| |
| |
| |
| |
| |
| | |
Instead of expecting that the number of open files is well above
kNumProcs, simply "skip" the test in that case, still printing the
message about the test limit (adding the current system limit too).
|
|\ \
| | |
| | | |
POSIX: detach background subprocesses from terminal.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Put background subprocesses (i.e. subprocesses with no access
to the console) in their own session and detach them from the
terminal.
This fixes martine/ninja#909.
|
|\ \ \
| | | |
| | | | |
Make diagnostics colored with new gccs (4.9+) too.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Both clang and gcc understand -fdiagnostics-color, so use that flag name.
(This will disable colored diagnostics for clangs older than LLVM 3.3,
but that is several years old by now.)
|
|\ \ \ \
| |/ / /
|/| | | |
Fix build with libc++ after #921.
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It failed with
error: field has incomplete type 'EvalString'
note: in instantiation of exception specification for 'map' requested here
explicit Rule(const string& name) : name_(name) {}
^
|
|\ \ \
| | | |
| | | | |
Allow scoping rules through subninja
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The new test shows the added value of scoped rules by demonstrating
a multi-level build where a single rules file gets included at all
the levels. By scoping rules, this is possible.
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | | |
Ninja didn't support scoping rules through subninja and assumed
a unique rule name in the whole namespace. With this change, this
behavior is changed to allow scoping rules. Two rules can have the
same name if they belong to two different scopes. However, two
rules can NOT have the same name in the same scope.
|
|\ \ \
| | | |
| | | | |
Test for Clang by checking --version
|
|/ / / |
|
|\ \ \
| |/ /
|/| | |
Directly pass the string instead of char * to Truncate util function. It...
|
|/ /
| |
| |
| | |
will prevent useless conversions.
|
|\ \
| | |
| | | |
Typo fix in graph.cc
|
|/ / |
|
|\ \
| |/
|/| |
Allow manifest rebuild to loop up to 100 times
|
|/
|
|
|
|
|
|
|
| |
Ninja generators that bootstrap themselves with Ninja may need
to rebuild build.ninja multiple times. Replace the 2 cycle loop
with a 100 cycle loop, and print the pass number each time it
restarts.
Original-author: Jamie Gennis <jgennis@gmail.com>
|
|\
| |
| | |
Check pending SIGINT after ppoll/pselect
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ppoll/pselect prioritizes file descriptor events over
a signal delivery. So a flood of events prevents ninja
from reacting keyboard interruption by the user.
This CL adds a check for pending keyboard interruptions after
file descriptor events.
|
|\ \
| | |
| | | |
Document how to run gcov on ninja.
|
|/ / |
|
|\ \
| | |
| | | |
Remove an incorrect assert.
|
|/ /
| |
| |
| |
| |
| | |
The assert fires on cyclic manifests (found by afl-fuzz). Since there
was explicit error handing for this case already, just remove the
assert.
|
|\ \
| |/
|/| |
Cleanup: Fix 'hasIdent' variable name/style.
|
| |
| |
| |
| |
| |
| |
| | |
Seems more correct to name it has_indent_token and to use the
unix_hacker style.
Signed-off-by: Thiago Farina <tfarina@chromium.org>
|
|\ \
| | |
| | | |
Try to simplify d1e6a29 a bit.
|
|/ / |
|
|\ \
| | |
| | | |
Remove unused hash<std::string>.
|
|/ /
| |
| |
| |
| | |
ExternalStringHashMap used to store std::strings long ago. Since it
doesn't anymore, this specialization isn't needed. No behavior change.
|
|\ \
| |/
|/| |
Fix compilation errors on Visual Studio 2015 (_MSC_VER 1900)
|
|/ |
|
|\
| |
| | |
Remove 'Recompacting...' messages.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Recompacting the build log used to be slow, so it made sense to print this
message. We then made recompaction much faster, but didn't remove this
message back then.
The deps log only has it because the build log had it.
Since both steps are effectively instant in practice, remove these log messages.
|
|\ \
| | |
| | | |
zsh-completion: remove use of 'head' with negative offset
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some systems - like OSX - don't come with a version of head that
supports a negative value for the -n flag. Such systems get a message
such as this when tab-completing ninja's -d flag:
ninja -dhead: illegal line count -- -1
Using sed instead should be more universally supported.
|
|\ \
| |/
|/| |
configure: add a verbose mode
|
|/
|
|
|
| |
Required for Fedora infrastructure so that the commands used to build
ninja are logged.
|
|\
| |
| | |
Let DependencyScan::RecomputeDirty() work correclty with cyclic graphs.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RecomputDirty(edge) currently works roughly like this:
RecomputeDirty(edge):
LoadDeps(edge)
for in in edge.inputs:
if in.StatIfNecessary():
RecomputeDirty(in.in_edge) # recurse into inputs
for out in edge.outputs:
out.StatIfNecessary() # mark outputs as visited
It uses the stat state of each node to mark nodes as visited and doesn't
traverse across nodes that have been visited already. For cyclic graphs
with an edge with multiple outputs on the cycle, nothing prevents an
edge to be visited more than once if the cycle is entered through an
output that isn't on the cycle. In other words, RecomputeDirty() for
the same edge can be on the call stack more than once. This is bad for
at least two reasons:
1. Deps are added multiple times, making the graph confusing to reason
about.
2. LoadDeps() will insert into the inputs_ of an edge that's iterated
over in a callframe higher up. This can invalidate the iterator,
which causes a crash when the callframe with the loop over the
now-invalidated iterator resumes.
To fix this, let RecomputeDirty() mark all outputs of an edge as visited
as the first thing it does. This way, even if the edge is on a cycle
with several outputs, each output is already marked and no edge will
have its deps loaded more than once.
Fixes the crashes in #875. (In practice, it turns the crashes into
"stuck [this is a bug]" messages for now, due to the example without
duplicate rules in #867)
|
|
|
|
|
|
|
|
|
| |
It confused me that the iterator iterating over `outputs_` was called
`i` -- this always made me think of "input", not "iterator".
Call iterators over edge outputs "o", iterators over edge inputs "i",
iterators over node input edges "oe", and general iterators over edges
"e".
|
| |
|
|\
| |
| | |
Added *.obj ignore rule
|
| | |
|
|\ \
| | |
| | | |
Fixed cygwin compatibility (issue #806)
|
| | |
| | |
| | |
| | | |
Fixed platform specific issues causing cygwin build to fail.
|
| | |
| | |
| | |
| | |
| | | |
All other counting variables are called foo_count, not num_foos.
No behavior change.
|
|\ \ \
| | | |
| | | | |
Remove unneeded save-excursion.
|