summaryrefslogtreecommitdiffstats
path: root/src/build_log.cc
Commit message (Collapse)AuthorAgeFilesLines
* fix all "class" -> "struct"Evan Martin2012-12-291-2/+1
|
* Fix formattingRobert Iannucci2012-11-301-2/+2
|
* build log: fixing parameter namesMaxim Kalaev2012-10-151-6/+6
|
* build log: mini-refactoring to use constructors to initialize entriesMaxim Kalaev2012-10-121-4/+11
|
* build log: moving HashCommand() calculation out of targets loopMaxim Kalaev2012-10-121-1/+2
|
* Add metric for log recompactingPetr Wolf2012-10-041-0/+1
|
* remove config from BuildLog, rename membersEvan Martin2012-09-021-13/+10
|
* make it more explicit that a bad build log causes us to rebuildEvan Martin2012-08-171-3/+6
| | | | | (Committing this on top of b56fe80 since they're related, but I may end up reverting both.)
* windows: fix size_t<->int conversions in ninja.exeEvan Martin2012-08-101-6/+6
|
* Revert "Make StringPiece data members private."Nico Weber2012-07-281-2/+2
| | | | | | This reverts commit 904c9610fe66c4f4bd63a07d6f057c8603d24394. The commit caused issue #380, this revert fixes it. The revert also makes the test from the previous commit pass.
* Merge pull request #352 from tfarina/string-piece-privateEvan Martin2012-07-271-2/+2
|\ | | | | Make StringPiece data members private.
| * Make StringPiece data members private.Thiago Farina2012-06-301-2/+2
| | | | | | | | Signed-off-by: Thiago Farina <tfarina@chromium.org>
* | Minor: zero log buffer before reading data/parsing itMaxim Kalaev2012-07-271-1/+3
| | | | | | | | Not a real problem, mainly to make valgrind happy
* | don't leak file handle on fail-to-upgrade caseScott Graham2012-06-191-0/+1
|/
* switch build log to print hashes as hexEvan Martin2012-06-191-2/+2
| | | | | | Nico convinced me that it's safe to do this without revving the build log format: the old decimal values will still parse as hex (just as different numbers) and cause a superfluous rebuild.
* drop support of log formats < 4Evan Martin2012-06-181-10/+15
| | | | | Log format 4 was introduced in January. There's been plenty of time to migrate.
* use PRIu64 for printing 64-bit in, %d for printing intEvan Martin2012-06-181-2/+4
| | | | Fixes a warning.
* no recompacting needed when log file is emptyPeter Kuemmel2012-06-181-3/+7
|
* Only store command hashes in the build log.Nico Weber2012-06-151-5/+59
| | | | | | | | | | | | | | .build_log load time 350ms -> 17ms, filesize 197MB -> 1.6MB on Mac. On Windows, it's 500ms -> 20ms. Makes the build log a lot less useful for scripts, but there could be a tool for use cases that need log information. A prototype of such a tool is in https://github.com/nico/ninja/commit/1b243d311 The hash function is 64bit murmurhash2. Assuming that that different commands get the same hash only by chance, it's is very unlikely for two different commands to hash to the same value with a 64bit hash.
* Switch LineReader from fgets() to just fread().Nico Weber2012-05-101-5/+33
| | | | | | | | | | | | | | | | | | | | | fgets() needs to search for a \n in the input, and LineReader's strstr() did the same work again. By using fread() directly, this duplicate work can be saved. (I tried using readline() / fgetln() for the same saving, but those functions are not standard, and were slower than the code in this CL.) Results from running build_log_perftest, on OS X: Before: min 369ms max 372ms avg 370.4ms After: min 243ms max 247ms avg 244.8ms On Windows: Before: min 796ms max 904ms avg 858.0ms After: min 359ms max 375ms avg 371.4ms On Linux: Before: min 161ms max 169ms avg 164.8ms Before: min 130ms max 137ms avg 132.6ms
* Pull BuildLog line reading into its own class. No performance or behavior ↵Nico Weber2012-05-101-11/+36
| | | | change.
* Don't write ninja log header to log on every build on Windows.Nico Weber2012-05-081-0/+4
|
* Merge pull request #290 from nico/metricsEvan Martin2012-05-021-0/+2
|\ | | | | Add .ninja_log load time to metrics.
| * Add .ninja_log load time to metrics.Nico Weber2012-05-011-0/+2
| | | | | | | | On my system, it takes 22% of the empty build time for chrome.
* | Fix Windows build.Nico Weber2012-04-301-0/+3
|/
* Include unistd.h where neededBen Boeckel2012-03-281-0/+1
|
* Fix resources leaksPierre Schweitzer2012-03-131-0/+1
|
* Response filesunknown2012-02-091-1/+1
|
* Fix cygwin build by including stdio.h hereokuoku2012-01-251-1/+0
|
* BuildLog: Use Log::insert(Log::value_type()) to avoid invalid strings.Evan Jones2012-01-131-2/+2
| | | | | | | The MSVC std::string implementation copies strings, so using make_pair resulted in a pointer to invalid memory. This ensures the insert uses a StringPiece without an intermediate std::string copy, so the correct pointer ends up in the hash_map.
* convert ExternalStringHash to use StringPieceEvan Martin2012-01-091-4/+4
|
* convert all time_t to a new TimeStamp typeEvan Martin2012-01-051-2/+2
|
* make my last change actually workEvan Martin2012-01-051-2/+2
|
* remove build_log v1/v2 codeEvan Martin2012-01-051-24/+14
|
* Switch build log to use tabs as field separators, to support outputs with ↵Nico Weber2012-01-051-6/+9
| | | | spaces.
* Protect BuildLog data member variables by making them private.Thiago Farina2011-12-201-2/+6
| | | | | | | | | They are not accessed outside of BuildLog and there is even a SetConfig function to set the |config_| variable. So better to make them private to BuildLog now while nobody is using it outside. Signed-off-by: Thiago Farina <tfarina@chromium.org>
* merge FileStat into NodeEvan Martin2011-12-071-1/+1
| | | | | | The two were always one-to-one anyway. I started adding accessors to FileStat and then realized most users wanted them on Node and that forwarding them through was silly.
* Merge pull request #125 from pcc/outputs-readyEvan Martin2011-11-021-14/+25
|\ | | | | CMake requirements: Make-style order-only dependencies, restat rules
| * Implement restat rulesPeter Collingbourne2011-10-241-10/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A restat rule is a rule which is capable of pruning the build tree depending on the timestamps of its outputs before and after a build. After a restat rule is rebuilt, Ninja will re-stat each output file to obtain its current timestamp. If the timestamp is unchanged from when Ninja initially stat'ed the file before starting the build, Ninja will mark that output file as clean, and recursively for each reverse dependency of the output file, recompute its dirty status. Ninja then stores the most recent timestamp of any input file in the build log entry associated with the output file. This timestamp will be treated by future invocations of Ninja as the output file's modification time instead of the output file's actual modification time for the purpose of deciding whether it is dirty (but not whether its reverse dependencies are dirty).
| * Create log entries in BuildLog::RecordCommand without requiring a log filePeter Collingbourne2011-10-241-4/+2
| | | | | | | | | | This permits us to write tests that write and later read from the build log without needing a temporary log file.
* | move SetCloseOnExec to utilEvan Martin2011-10-311-17/+2
|/
* generalize the pattern of hash_map<const char*, ...>, use in BuildLogEvan Martin2011-09-121-7/+7
| | | | | | Refactor the code in StatCache for use in BuildLog. Now both use hash tables where the keys are const char*. Removes another 30ms from Chrome no-op builds.
* Factor out State struct from ninja_jumble.cc into its header/source files.Thiago Farina2011-09-031-1/+1
| | | | | | This was a TODO in src/ninja_jumble.cc. Now this task is completed. Signed-off-by: Thiago Farina <tfarina@chromium.org>
* don't leak the build_log file descriptor into subprocessesEvan Martin2011-06-301-0/+17
| | | | Closes issue #74.
* remove +x bit from sourceEvan Martin2011-06-031-0/+0
|
* Tests now build on a native Windows build (tested with VS2010)Philip Craig2011-05-281-1/+1
| | | | | All tests except SubProcess pass on a native Windows build Tests continue not to build on a platform=mingw build
* don't recompact log often for small programsEvan Martin2011-05-221-4/+8
|
* refix recompactionEvan Martin2011-05-121-1/+1
| | | | | Like all untested quick fixes, my previous quick fix actually introduced a reliable segfault.
* quick fix: write out signature in recompactionEvan Martin2011-05-111-0/+5
| | | | | This needs refactoring but I already pushed the bad code so this hopefully makes it less broken.
* don't crash on truncated log filesEvan Martin2011-05-111-3/+7
| | | | | Add a test that tries all truncations of a log file and verifies it doesn't crash.