summaryrefslogtreecommitdiffstats
path: root/src/graph.cc
Commit message (Collapse)AuthorAgeFilesLines
* views: Mark single-argument constructors as explicit.Thiago Farina2012-05-061-1/+1
| | | | | | | | This was reported by cpplint as: python ~/depot_tools/cpplint.py 2>&1 | grep -v "Done processing" | grep explicit Signed-off-by: Thiago Farina <tfarina@chromium.org>
* add support for -d explain to help debug why rules are runningScott Graham2012-04-131-6/+25
|
* Mark a phony target with no inputs as outputs-readyPeter Collingbourne2012-03-051-4/+4
| | | | | | | | Even if such a target is dirty (i.e. the file does not exist), it has nothing to do, which makes it safe to mark as outputs-ready. Without this change, ninja will print no output when rebuilding the target (or an order-only dependency thereof), instead of reporting it has "no work to do".
* fix some public/private errors in rspfile patchEvan Martin2012-02-231-3/+3
|
* Response filesunknown2012-02-091-3/+20
|
* remove string copy while loading depfilesEvan Martin2012-01-091-3/+2
|
* add a '-d stats' flag for detailed timingsEvan Martin2012-01-051-0/+3
| | | | | | 1) Add a system for recording detailed timing info of functions. 2) Add a -d flag for requesting debug info at runtime, with the above as the first user.
* convert all time_t to a new TimeStamp typeEvan Martin2012-01-051-4/+5
|
* When expanding $in and $out, wrap with quotes if the filename has a space.Jeremy Apthorp2012-01-021-1/+8
|
* switch DepfileParser to take a string* to make memory clearerEvan Martin2011-12-271-1/+1
| | | | Add some comments as well.
* Fix the TODO in Rule class.Thiago Farina2011-12-241-4/+4
| | | | | | Move various data members to private section and provide accessors for them. Signed-off-by: Thiago Farina <tfarina@chromium.org>
* use re2c to parse depfilesEvan Martin2011-12-071-11/+12
|
* refactor EdgeEnvEvan Martin2011-12-071-23/+35
|
* make Rule::generator_ and restat_ privateEvan Martin2011-12-071-2/+2
|
* make Rule::name_ privateEvan Martin2011-12-071-1/+1
|
* make Node::out_edges_ privateEvan Martin2011-12-071-1/+1
|
* make Node::in_edge_ privateEvan Martin2011-12-071-5/+5
|
* make Node::dirty_ privateEvan Martin2011-12-071-3/+3
|
* merge FileStat into NodeEvan Martin2011-12-071-18/+18
| | | | | | The two were always one-to-one anyway. I started adding accessors to FileStat and then realized most users wanted them on Node and that forwarding them through was silly.
* refactor to remove Node::ready()Evan Martin2011-12-071-0/+9
|
* Factor out Edge::EvaluateDepFilePeter Collingbourne2011-12-061-3/+6
|
* disable the 'unused parameter' warningEvan Martin2011-12-051-2/+2
| | | | It was firing too often, and hadn't uncovered any bugs.
* fix some minor style issues in RecomputeDirtyEvan Martin2011-12-041-11/+11
|
* when an edge is dirty, mark all outputs dirtyEvan Martin2011-12-041-9/+25
| | | | | | | | | | | | | | | The logic before was like: for each output: if edge_dirty or output.dirty: output.dirty = true edge_dirty = true This was wrong in the case where the second output would case the edge to be dirty; we needed to go back and mark the first output dirty as well. Fixed by taking two passes: one to compute the dirty state, then a latter sweep to mark all outputs. Fixes issue 148.
* refactor RecomputeOutputDirty to return true/false for dirtyEvan Martin2011-12-041-29/+25
| | | | | | | | | Rather than taking whether the edge is dirty as an input, instead only consider the arguments and return true/false, allowing the caller to decide what to do with that information. (In the restat case we were faking out the environment to get particular behavior for this.) Should have no side effects, but this is part of fixing issue 148.
* Implement restat rulesPeter Collingbourne2011-10-241-5/+18
| | | | | | | | | | | | | | | | | A restat rule is a rule which is capable of pruning the build tree depending on the timestamps of its outputs before and after a build. After a restat rule is rebuilt, Ninja will re-stat each output file to obtain its current timestamp. If the timestamp is unchanged from when Ninja initially stat'ed the file before starting the build, Ninja will mark that output file as clean, and recursively for each reverse dependency of the output file, recompute its dirty status. Ninja then stores the most recent timestamp of any input file in the build log entry associated with the output file. This timestamp will be treated by future invocations of Ninja as the output file's modification time instead of the output file's actual modification time for the purpose of deciding whether it is dirty (but not whether its reverse dependencies are dirty).
* Implement Make-style order-only dependenciesPeter Collingbourne2011-10-241-16/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the implementation of order-only dependencies differed between Make and Ninja in two important ways: 1) If the order-only dependency existed but was out of date, it would never be rebuilt, whereas Make would always rebuild out of date order-only dependencies. 2) If the order-only dependency did not exist, it would cause its reverse dependencies to always build, whereas Make would only rebuild a file if a non-order-only dependency was out of date. A key distinction between Ninja and Make as seen through the above two points was that in Ninja, order-only dependencies cared about whether the target as a file exists (so perhaps a better name for the old semantics would have been "missing-only dependencies"). These differences made it impossible to introduce an order-only dependency on an always out-of-date (i.e. missing) target without also causing the depender and its reverse dependencies to rebuild unnecessarily on every build. Build systems which must perform some action (such as logging the build start time, or printing a message) at the start of every build typically implement this by adding to every target an order-only dependency which performs this action, which would have forced an entire rebuild on every invocation of Ninja under the old semantics. This commit causes Ninja to conform to the Make-style behaviour.
* Split Node::dirty_ into two flags: Node::dirty_ and Edge::outputs_ready_Peter Collingbourne2011-10-181-27/+54
| | | | | dirty_ is intended to remain static during the build (unless a restat occurs), while outputs_ready_ reflects the dynamic state of the build.
* Implement generator rulesPeter Collingbourne2011-10-151-1/+3
| | | | | | | | | | | | | Introduce a rule attribute "generator" which, if present, specifies that this rule is used to re-invoke the generator program. Files built using generator rules are treated specially in two ways: firstly, they will not be rebuilt if the command line changes; and secondly, they are not cleaned by default. A command line flag "-g" is introduced for the clean tool, which causes it to remove generator files. Fixes issue #102.
* make CanonicalizePath report an error on empty pathEvan Martin2011-10-061-1/+2
| | | | Fixes part of issue 121, but the fix exposed a further issue.
* Merge pull request #106 from pcc/depfile-vectorEvan Martin2011-09-141-4/+7
|\ | | | | Allocate space in the inputs vector for the depfile implicit deps
| * Allocate space in the inputs vector for the depfile implicit depsPeter Collingbourne2011-09-141-4/+7
| | | | | | | | This speeds up a no-op LLVM/Clang build by about 20ms.
* | Consider missing phony targets with no dependencies out of datePeter Collingbourne2011-09-141-1/+4
|/ | | | | | | | | | | | | | | Commit 639c8f0 ("don't mark phony edges dirty if none of their inputs are dirty") modified the behaviour of the "phony" built-in rule. Previously, when the output file was missing, it was marked as dirty. After 639c8f0, it was always marked as clean unless one of the dependencies was dirty. The depfile mechanism uses the old behaviour of "phony" to rebuild an object file if any of the headers were missing. Restore the old "phony" behaviour only for the case where the build statement has no dependencies. This is slightly inconsistent, but I can't really see any other use case for an alias of nothing. Also, document this behaviour.
* use StringPiece for makefile depsEvan Martin2011-09-121-5/+7
| | | | | | | | | | | | Because of this, MakefileParser now returns pointers into the source makefile string rather than allocating new strings. Despite needing to take the result and stuff it into a new string anyway to canonicalize it, this takes another 50ms or so off the null Chrome build, likely due to the vector used in MakefileParser changing to a type that doesn't use any allocations. (I also experimented with making the vector reserve an initial size but didn't see any performance impact.)
* don't mark phony edges dirty if none of their inputs are dirtyEvan Martin2011-09-091-2/+11
| | | | | | | Because the output file is always missing, we'd consider a phony edge dirty even when there wasn't any work to do. Most importantly, that would mean we wouldn't print "nothing to do" in the common case of everything being up to date when building an alias.
* Add depfile support to build command with multiple outputs (Fixes: #61)Qingning Huo2011-09-061-4/+0
| | | | | | | | | | | | | parsers.cpp: allow depfile used at build command with multiple outputs. graph.cpp: allow depfile used at build command with multiple outputs. parsers_test.cpp: make the test pass. As before, the depfile itself can only mention one target, which must be the first of a build command with multiple outpus. [There is really no need to mention all the output in the depfile, because all targets should depend on exactly the same files anyway, because these targets are built by a single build command.]
* Factor out State struct from ninja_jumble.cc into its header/source files.Thiago Farina2011-09-031-1/+2
| | | | | | This was a TODO in src/ninja_jumble.cc. Now this task is completed. Signed-off-by: Thiago Farina <tfarina@chromium.org>
* Merge pull request #86 from tfarina/real-disk-interfaceEvan Martin2011-08-251-0/+1
|\ | | | | Move RealDiskInterface class to disk_interface.h.
| * Move RealDiskInterface class to disk_interface.h.Thiago Farina2011-08-251-0/+1
| | | | | | | | | | | | This is a TODO in src/ninja_jumble.cc Signed-off-by: Thiago Farina <tfarina@chromium.org>
* | semantic change: allow reaching into parent directories in pathsEvan Martin2011-08-241-2/+1
|/ | | | | | | | | | | This allows generating build files in a subdirectory of your source tree. - Change CanonicalizePath to accept this. - CanonicalizePath no longer has an error condition, so change it to a void function. I profiled the result against Chrome and it might be ~100ms slower, but that might just be Chrome's size working against me. In any case I think there are lower-hanging performance fruit elsewhere.
* src/graph.cc: fix EdgeEnv::LookupVariableQingning Huo2011-06-101-1/+6
| | | | | Make it return the correct value for "out" when there are multiple outputs. It used to return only the first target file.
* make the phony depfile edge order-onlyEvan Martin2011-05-171-0/+1
| | | | | I'm not sure this is semantically different but it's consistent with how I think about these phony edges.
* SEMANTIC CHANGE: implicit inputs are now required to existEvan Martin2011-05-131-3/+10
| | | | | | Edges found through depfiles are special: they get an extra empty "phony" rule. (This is identical to the way you hack this with Makefiles.)
* add doxygen-compatibile comments to most classesEvan Martin2011-04-291-0/+1
|
* Move CanonicalizePath into util.h so it can be shared by the other modules.Thiago Farina2011-04-151-53/+1
| | | | | | Also add util_test.cc and move the CanonicalizePathTest into there. Signed-off-by: Thiago Farina <tfarina@chromium.org>
* files that have both implicit and explicit edges should be implicitEvan Martin2011-03-071-11/+3
| | | | | | | This is just deleting some code that was written in anticipation of staying memory-resident; when loading a depfile, we don't need to attempt to update existing entries in the dependency list, we just need to blindly add them.
* canonicalize paths loaded from depfilesEvan Martin2011-03-071-1/+58
| | | | | | | | | If a C file #includes "../foo.cc", then gcc will emit paths like "bar/../foo.cc" into the dependency file; canonicalize these when we load the file. Add a test module for testing the graph dirty recomputation directly, without all the build classes around it.
* add copyrightsEvan Martin2011-02-061-0/+14
|
* cleanup phony testingEvan Martin2011-02-051-0/+3
|
* include path when printing a makefile parse errorEvan Martin2011-02-041-1/+4
|
generated by cgit v0.12 at 2025-04-07 05:00:49 (GMT)