Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | Switch LineReader from fgets() to just fread(). | Nico Weber | 2012-05-10 | 1 | -5/+33 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fgets() needs to search for a \n in the input, and LineReader's strstr() did the same work again. By using fread() directly, this duplicate work can be saved. (I tried using readline() / fgetln() for the same saving, but those functions are not standard, and were slower than the code in this CL.) Results from running build_log_perftest, on OS X: Before: min 369ms max 372ms avg 370.4ms After: min 243ms max 247ms avg 244.8ms On Windows: Before: min 796ms max 904ms avg 858.0ms After: min 359ms max 375ms avg 371.4ms On Linux: Before: min 161ms max 169ms avg 164.8ms Before: min 130ms max 137ms avg 132.6ms | |||||
| * | Pull BuildLog line reading into its own class. No performance or behavior ↵ | Nico Weber | 2012-05-10 | 1 | -11/+36 | |
| | | | | | | | | change. | |||||
* | | Add a BuildLog test that checks that very long command liens don't crash. | Nico Weber | 2012-05-10 | 1 | -0/+28 | |
| | | ||||||
* | | Add a BuildLog test that checks duplicate version headers don't crash. | Nico Weber | 2012-05-10 | 1 | -0/+31 | |
|/ | ||||||
* | Merge pull request #307 from sgraham/nul-input | Evan Martin | 2012-05-09 | 1 | -5/+16 | |
|\ | | | | | pass subprocesses handle to nul device rather than null handle | |||||
| * | pass subprocesses handle to nul device rather than null handle | Scott Graham | 2012-05-09 | 1 | -5/+16 | |
| | | ||||||
* | | Add a BuildLog loading perftest. | Nico Weber | 2012-05-08 | 2 | -1/+140 | |
| | | ||||||
* | | include version number | Evan Martin | 2012-05-08 | 1 | -2/+10 | |
| | | ||||||
* | | Don't write ninja log header to log on every build on Windows. | Nico Weber | 2012-05-08 | 2 | -0/+35 | |
|/ | ||||||
* | Merge pull request #299 from tfarina/explicit-ctors | Evan Martin | 2012-05-07 | 4 | -6/+10 | |
|\ | | | | | views: Mark single-argument constructors as explicit. | |||||
| * | views: Mark single-argument constructors as explicit. | Thiago Farina | 2012-05-06 | 4 | -6/+10 | |
| | | | | | | | | | | | | | | | | This was reported by cpplint as: python ~/depot_tools/cpplint.py 2>&1 | grep -v "Done processing" | grep explicit Signed-off-by: Thiago Farina <tfarina@chromium.org> | |||||
* | | No need to convert log_path to c-string. Two places. | Thiago Farina | 2012-05-06 | 1 | -4/+3 | |
|/ | | | | Signed-off-by: Thiago Farina <tfarina@chromium.org> | |||||
* | First check for string end, then dereference. (5ms more expensive, heh.) | Nico Weber | 2012-05-04 | 1 | -2/+2 | |
| | ||||||
* | Don't walk path components twice. Speeds up CanonicalizePath() 115ms (285ms ↵ | Nico Weber | 2012-05-04 | 1 | -6/+2 | |
| | | | | -> 170ms). | |||||
* | Reorder a few lines, no functionality (or perf) change. | Nico Weber | 2012-05-04 | 1 | -5/+4 | |
| | ||||||
* | Skip single '/' characters earlier in the loop. 300ms -> 285ms. | Nico Weber | 2012-05-04 | 1 | -8/+11 | |
| | ||||||
* | Speed up CanonicalizePath() 6.8% (322ms -> 300ms for chrome empty build). | Nico Weber | 2012-05-04 | 2 | -8/+35 | |
| | ||||||
* | Merge pull request #290 from nico/metrics | Evan Martin | 2012-05-02 | 1 | -0/+2 | |
|\ | | | | | Add .ninja_log load time to metrics. | |||||
| * | Add .ninja_log load time to metrics. | Nico Weber | 2012-05-01 | 1 | -0/+2 | |
| | | | | | | | | On my system, it takes 22% of the empty build time for chrome. | |||||
* | | Merge pull request #284 from nico/fixwinbuild | Evan Martin | 2012-05-02 | 2 | -1/+4 | |
|\ \ | | | | | | | Fix Windows build. | |||||
| * | | Fix Windows build. | Nico Weber | 2012-04-30 | 2 | -1/+4 | |
| |/ | ||||||
* | | Merge pull request #283 from tfarina/string-ampersand | Evan Martin | 2012-05-02 | 6 | -7/+7 | |
|\ \ | |/ |/| | Put & operator with the type rather than the variable name. | |||||
| * | Put & operator with the type rather than the variable name. | Thiago Farina | 2012-04-28 | 6 | -7/+7 | |
| | | | | | | | | Signed-off-by: Thiago Farina <tfarina@chromium.org> | |||||
* | | Merge pull request #274 from polrop/max_load_average | Evan Martin | 2012-04-28 | 5 | -4/+51 | |
|\ \ | | | | | | | Max load average | |||||
| * | | Add -l N option to limit the load average. | Nicolas Despres | 2012-04-19 | 5 | -4/+51 | |
| | | | | | | | | | | | | | | | | | | | | | This is similar to GNU make -l/--load-average option. It limits the number of job started if the load average exceed the given value. It can be very useful when running ninja on a continuous integration server where we want to use parallelism as much as possible without overloading the server. | |||||
| * | | Remove trailing white spaces. | Nicolas Despres | 2012-04-19 | 1 | -6/+6 | |
| | | | ||||||
* | | | suggest ninja -h when someone runs 'ninja help' | Evan Martin | 2012-04-26 | 1 | -0/+2 | |
| |/ |/| | ||||||
* | | allow UTF-8 in rule descriptions | Evan Martin | 2012-04-26 | 3 | -5/+12 | |
| | | | | | | | | | | The lexer already mostly allowed this, except that chars >127 were being interpreted as negative indexes into the lexer table. | |||||
* | | reduce custom ninja status patch in minor ways | Evan Martin | 2012-04-26 | 3 | -128/+53 | |
| | | | | | | | | | | Elsewhere in the code I avoid sstream and manual buffer management, so switch this code to behave similarly. Sorry for being OCD. | |||||
* | | Merge branch 'custom_ninja_status' of git://github.com/polrop/ninja | Evan Martin | 2012-04-26 | 3 | -51/+199 | |
|\ \ | ||||||
| * | | Refactor and test progress status formatting. | Nicolas Despres | 2012-04-24 | 3 | -69/+140 | |
| | | | ||||||
| * | | Introduce NINJA_STATUS env var for customization. | Nicolas Despres | 2012-04-24 | 1 | -2/+79 | |
| | | | | | | | | | | | | | | | | | | Some people may want to display different relevant information about the progress of the build. Also it can be usefull to debug jobs allocation. | |||||
| * | | Remove trailing white spaces. | Nicolas Despres | 2012-04-24 | 2 | -13/+13 | |
| |/ | ||||||
* | | Merge pull request #272 from nico/statstweak | Evan Martin | 2012-04-26 | 1 | -3/+3 | |
|\ \ | | | | | | | Switch the order of total and avg columns in -d stats output. | |||||
| * | | Switch the order of total and avg columns in -d stats output. | Nico Weber | 2012-04-17 | 1 | -3/+3 | |
| |/ | ||||||
* | | Merge pull request #269 from sgraham/explain | Evan Martin | 2012-04-26 | 6 | -10/+72 | |
|\ \ | | | | | | | add support for -d explain to help debug why rules are running | |||||
| * | | add support for -d explain to help debug why rules are running | Scott Graham | 2012-04-13 | 6 | -10/+72 | |
| |/ | ||||||
* | | Merge pull request #228 from pcc/lazily-create-commandrunner | Evan Martin | 2012-04-26 | 1 | -4/+8 | |
|\ \ | | | | | | | Lazily create the CommandRunner in Builder::Build | |||||
| * | | Lazily create the CommandRunner in Builder::Build | Peter Collingbourne | 2012-02-27 | 1 | -4/+8 | |
| | | | | | | | | | | | | | | | This allows the user to interrupt the build (i.e. using Ctrl-C) while the build plan is being computed. | |||||
* | | | Merge branch 'dont-clean-phony' of git://github.com/pcc/ninja | Evan Martin | 2012-04-26 | 2 | -9/+36 | |
|\ \ \ | |_|/ |/| | | | | | | | | Conflicts: src/clean.cc | |||||
| * | | Don't delete phony targets when cleaning a specified target | Peter Collingbourne | 2012-02-28 | 2 | -7/+34 | |
| |/ | | | | | | | Also, modify Cleaner::CleanAll to use Edge::is_phony. | |||||
* | | Merge pull request #252 from qhuo/remove-depfile-when-cleaning | Evan Martin | 2012-04-11 | 2 | -0/+34 | |
|\ \ | | | | | | | Remove depfiles when running "ninja -t clean <target>" or "ninja -t clean -r <rule>" | |||||
| * | | Remove depfiles when running when running "ninja -t clean <target>" | Qingning Huo | 2012-03-14 | 2 | -0/+34 | |
| | | | | | | | | | | | | or "ninja -t clean -r <rule>" | |||||
* | | | Merge pull request #253 from qhuo/include-io.h | Evan Martin | 2012-04-10 | 1 | -0/+1 | |
|\ \ \ | | | | | | | | | Fix windows build (add #include <io.h>) | |||||
| * | | | Fix windows build (add #include <io.h>) | Qingning Huo | 2012-03-15 | 1 | -0/+1 | |
| |/ / | ||||||
* | | | Make |log_| variable private to BuildLog. | Evan Martin | 2012-04-05 | 2 | -4/+5 | |
| | | | | | | | | | | | | | | | | | | This fix the TODO in build_log.h file. Signed-off-by: Thiago Farina <tfarina@chromium.org> | |||||
* | | | Merge pull request #263 from mathstuf/dev/gcc-470-build-fixes | Evan Martin | 2012-04-05 | 3 | -0/+3 | |
|\ \ \ | | | | | | | | | Include unistd.h where needed | |||||
| * | | | Include unistd.h where needed | Ben Boeckel | 2012-03-28 | 3 | -0/+3 | |
| | | | | ||||||
* | | | | Merge pull request #256 from iwadon/fix-sign-compare | Evan Martin | 2012-04-05 | 3 | -10/+10 | |
|\ \ \ \ | |/ / / |/| | | | fix warning: "comparison between signed and unsigned integer expressions" | |||||
| * | | | fix warning: "comparison between signed and unsigned integer expressions" | Hiroyuki Iwatsuki | 2012-03-16 | 3 | -10/+10 | |
| |/ / |