Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix typo. | Nicolas Despres | 2015-09-24 | 1 | -1/+1 |
| | |||||
* | Merge pull request #1014 from moroten/optimize-stringpiece | Nico Weber | 2015-09-07 | 1 | -1/+1 |
|\ | | | | | Optimize StringPiece hash map | ||||
| * | Optimize StringPiece hash map | Fredrik Medley | 2015-09-03 | 1 | -1/+1 |
| | | | | | | | | | | | | Replace strncmp with memcmp to improve performance. Signed-off-by: Fredrik Medley <fredrik.medley@gmail.com> | ||||
* | | Merge LLVM r242069, make spell checking allocate less memory. | Nico Weber | 2015-09-07 | 1 | -18/+20 |
|/ | |||||
* | Remove accidental changes | Scott Graham | 2015-08-10 | 2 | -1105/+1105 |
| | |||||
* | Some mucking with std:: for set_terminate and terminate_handler | Scott Graham | 2015-08-10 | 4 | -1109/+1108 |
| | |||||
* | Make sure not to re-define __STDC_FORMAT_MACROS. | Lindley French | 2015-07-31 | 1 | -0/+2 |
| | |||||
* | Correct order of ASSERT_EQ arguments | Mike Seplowitz | 2015-07-30 | 1 | -2/+2 |
| | | | | The correct order is ASSERT_EQ(expected, actual). | ||||
* | Merge pull request #988 from nico/slashes | Nico Weber | 2015-07-10 | 3 | -7/+13 |
|\ | | | | | win: print right slashes in 'unknown target' message | ||||
| * | win: print right slashes in 'unknown target' message | Nico Weber | 2015-07-10 | 3 | -7/+13 |
| | | |||||
* | | Merge pull request #973 from sgraham/canonicalize-fix | Nico Weber | 2015-07-05 | 8 | -63/+149 |
|\ \ | | | | | | | Fix crash in attempting to canonicalize paths longer than _MAX_PATH | ||||
| * | | don't alias input/output in ExtractDeps (i.e. actually works now) | Scott Graham | 2015-06-18 | 3 | -3/+8 |
| | | | |||||
| * | | propagate include normalization failure to caller instead | Scott Graham | 2015-06-18 | 5 | -25/+30 |
| | | | |||||
| * | | Error+exit -> Fatal | Scott Graham | 2015-06-18 | 1 | -2/+1 |
| | | | |||||
| * | | don't abort() | Scott Graham | 2015-06-09 | 1 | -3/+3 |
| | | | |||||
| * | | push error to caller and abort on failure | Scott Graham | 2015-06-09 | 4 | -47/+73 |
| | | | |||||
| * | | Fix crash in attempting to canonicalize paths longer than _MAX_PATH | Scott Graham | 2015-06-08 | 2 | -1/+52 |
| | | | |||||
* | | | Merge pull request #979 from stinb/bootstrap-out-of-source | Nico Weber | 2015-07-05 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Bootstrap out of source | ||||
| * | | | Search for generated headers relative to build dir. | Jason Haslam | 2015-06-22 | 1 | -1/+1 |
| | |/ | |/| | |||||
* | | | mark this 1.6.0.git | Nico Weber | 2015-06-29 | 1 | -1/+1 |
|/ / | |||||
* | | Revert "Bootstrap out of source" | Nico Weber | 2015-06-22 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #971 from stinb/bootstrap-out-of-source | Nico Weber | 2015-06-18 | 1 | -1/+1 |
|\ \ | | | | | | | Bootstrap out of source | ||||
| * | | Search for generated headers relative to build dir. | Jason Haslam | 2015-05-26 | 1 | -1/+1 |
| |/ | |||||
* | | Merge pull request #970 from nico/explain | Nico Weber | 2015-06-18 | 1 | -1/+7 |
|\ \ | | | | | | | Add a missing EXPLAIN() call. | ||||
| * | | Add a missing EXPLAIN() call. | Nico Weber | 2015-05-15 | 1 | -1/+7 |
| |/ | |||||
* | | Add missing member initializer in Edge constructor | Brad King | 2015-06-16 | 1 | -1/+2 |
|/ | | | | | | In commit v1.1.0^2~15^2~20 (stub out an api and de-constify Pool, 2012-10-03) the Edge "pool_" member was added as a raw pointer but the initializer was accidentally left out of the constructor. Add it now. | ||||
* | Fix typo in comment. | Nico Weber | 2015-05-02 | 1 | -1/+1 |
| | |||||
* | Merge pull request #962 from sgraham/pool-use-fix | Nico Weber | 2015-04-29 | 4 | -21/+43 |
|\ | | | | | Fix pool use count going unbalanced | ||||
| * | simplify & inline | Scott Graham | 2015-04-27 | 2 | -18/+8 |
| | | |||||
| * | avoid calling ResumeDelayedJobs instead | Scott Graham | 2015-04-24 | 3 | -10/+8 |
| | | |||||
| * | add comment | Scott Graham | 2015-04-24 | 1 | -0/+3 |
| | | |||||
| * | Fix pool use count going unbalanced | Scott Graham | 2015-04-23 | 3 | -9/+40 |
| | | |||||
* | | Forward interruption signal to child processes. | Nicolas Despres | 2015-04-24 | 2 | -29/+34 |
| | | |||||
* | | Allow SIGTERM for interruption. | Nicolas Despres | 2015-04-24 | 3 | -6/+38 |
|/ | | | | | Default signal sent by many other programs (mainly kill(1)) to gently terminates another one is SIGTERM. | ||||
* | Run more than 34 processes on Win32 if we have 32+ cores. | Rui Ueyama | 2015-04-17 | 1 | -1/+1 |
| | | | | | | | | For compatiblity reason, dwNumberOfProcessors in Win32 is capped at 32. So even if your machine has more than 32 cores, Ninja spawns at most 34 subprocesses. This patch fixes the issue by using GetNativeSystemInfo, which returns the system info from Wow64 point of view, instead of GetSystemInfo. | ||||
* | Merge pull request #954 from nico/fix | Nico Weber | 2015-04-09 | 1 | -1/+1 |
|\ | | | | | Fix an assert (and tests in --debug mode) after #921. | ||||
| * | Fix an assert (and tests in --debug mode) after #921. | Nico Weber | 2015-04-09 | 1 | -1/+1 |
| | | |||||
* | | Fix backslashes in graphviz causing incorrect rendering on windows. | Spencer Judge | 2015-04-08 | 1 | -1/+4 |
|/ | |||||
* | Don't get stuck on cyclic graphs where one edge has multiple outputs. | Nico Weber | 2015-04-01 | 2 | -4/+58 |
| | | | | | | | | | | | | | | | | | | | Fixes #934. Plan::AddSubTarget() tracks in want_ if each edge has been visited and visits every edge only once. But Plan::CheckDependencyCycle() worked on nodes however, so if a cycle was entered through an edge with multiple outputs, ninja would fail to detect that cycle. Move cycle detection to look for duplicate edges instead of nodes to fix this. The extra jump makes CheckDependencyCycle() a bit slower: for a synthetic build file with 10000 serial build steps, `ninja -n` now takes 0.32s instead of 0.26s before on my laptop. In practice, projects have a dependency change length on the order of 50, so there shouldn't be a noticeable slowdown in practice. (If this does end up being a problem: CheckDependencyCycle() currently does O(n) work and is called O(m) times from AddSubTarget(), so I think cycle checking is O(n^2) in the build depth. So instead of worrying about constant overhead, we could use a set<> instead of a stack<>. But it doesn't seem to be a problem in practice.) | ||||
* | Cleanup: Don't search stack for cycle elements twice. | Nico Weber | 2015-04-01 | 1 | -4/+2 |
| | | | | | | | | | | | | | The common case is that there is no cycle. In that case, CheckDependencyCycle() searched the stack for a dupe from the back, wouldn't find one, and return false. If there was a cycle, it would then search again from the front (probably because the push_back() that used to be here would invalidate the ri iterator). Since the push_back() is gone, just search from the front once. No intended behavior change. | ||||
* | Cleanup: Make stack a const ref now that it's no longer modified. | Nico Weber | 2015-04-01 | 2 | -8/+10 |
| | |||||
* | Cleanup: Don't modify during cycle checking. | Nico Weber | 2015-04-01 | 1 | -6/+2 |
| | |||||
* | Let Stat() have an err outparam instead of writing to stderr. | Nico Weber | 2015-03-31 | 12 | -138/+192 |
| | | | | | | | | | Also check for Stat() failure in a few more places. This way, ninja doesn't print two "ninja: error: " lines if stat() fails during a build. It also makes it easier to keep the stat tests quiet. Every caller of Stat() needs to explicitly log the error string if that's desired. | ||||
* | Add an opt-in flag to make duplicate edges an error (`-w dupbuild=err`). | Nico Weber | 2015-03-24 | 4 | -9/+65 |
| | | | | | This is step 1 on #931. Duplicated edges will become an error by default in the future. | ||||
* | Swap order of -k and -l in help output, to keep the list alphabetized. | Nico Weber | 2015-03-24 | 1 | -1/+1 |
| | |||||
* | Make tests quiet again. | Nico Weber | 2015-03-24 | 2 | -5/+9 |
| | |||||
* | Move warning emission on dupe edges from State to ManifestParser. | Nico Weber | 2015-03-24 | 3 | -10/+11 |
| | | | | | | | | This will make it easier to optionally make this an error (because ManifestParser has a way of printing errors), and it'll also make it easier to make the tests quiet again. No behavior change. | ||||
* | Preallocate edge node vectors. ~1% faster. | Nico Weber | 2015-03-21 | 1 | -0/+2 |
| | |||||
* | Recover slowdown for cyclic rule bindings fix. | Nico Weber | 2015-03-21 | 1 | -9/+17 |
| | |||||
* | Don't crash on cyclic references between rule bindings. | Nico Weber | 2015-03-21 | 1 | -0/+12 |
| | | | | | | | | | | | | | Fixes #902. This dynamically detects cycles. I like this approach less than detecting them statically when parsing rules [1], but it has the advantage that it doesn't break existing ninja manifest files. It has the disadvantage that it slows down manifest_parser_perftest by 3.9%. 1: https://github.com/martine/ninja/commit/cc6f54d6d436047 |