summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Implement GetLoadAverage on AIX using libperfstatMike Seplowitz2015-08-191-0/+12
|
* Fix AIX compilation error related to printf macrosMike Seplowitz2015-08-191-3/+8
| | | | | On AIX, inttypes.h gets indirectly included by build_log.h. It's easiest just to ask for the printf format macros right away.
* Strip tabs from od's outputMike Seplowitz2015-08-191-1/+1
| | | | /bin/od on Solaris and AIX both generate tabs.
* Remove accidental changesScott Graham2015-08-102-1105/+1105
|
* Some mucking with std:: for set_terminate and terminate_handlerScott Graham2015-08-104-1109/+1108
|
* Make sure not to re-define __STDC_FORMAT_MACROS.Lindley French2015-07-311-0/+2
|
* Correct order of ASSERT_EQ argumentsMike Seplowitz2015-07-301-2/+2
| | | | The correct order is ASSERT_EQ(expected, actual).
* Merge pull request #988 from nico/slashesNico Weber2015-07-103-7/+13
|\ | | | | win: print right slashes in 'unknown target' message
| * win: print right slashes in 'unknown target' messageNico Weber2015-07-103-7/+13
| |
* | Merge pull request #973 from sgraham/canonicalize-fixNico Weber2015-07-058-63/+149
|\ \ | | | | | | Fix crash in attempting to canonicalize paths longer than _MAX_PATH
| * | don't alias input/output in ExtractDeps (i.e. actually works now)Scott Graham2015-06-183-3/+8
| | |
| * | propagate include normalization failure to caller insteadScott Graham2015-06-185-25/+30
| | |
| * | Error+exit -> FatalScott Graham2015-06-181-2/+1
| | |
| * | don't abort()Scott Graham2015-06-091-3/+3
| | |
| * | push error to caller and abort on failureScott Graham2015-06-094-47/+73
| | |
| * | Fix crash in attempting to canonicalize paths longer than _MAX_PATHScott Graham2015-06-082-1/+52
| | |
* | | Merge pull request #979 from stinb/bootstrap-out-of-sourceNico Weber2015-07-051-1/+1
|\ \ \ | | | | | | | | Bootstrap out of source
| * | | Search for generated headers relative to build dir.Jason Haslam2015-06-221-1/+1
| | |/ | |/|
* | | mark this 1.6.0.gitNico Weber2015-06-291-1/+1
|/ /
* | Revert "Bootstrap out of source"Nico Weber2015-06-221-1/+1
| |
* | Merge pull request #971 from stinb/bootstrap-out-of-sourceNico Weber2015-06-181-1/+1
|\ \ | | | | | | Bootstrap out of source
| * | Search for generated headers relative to build dir.Jason Haslam2015-05-261-1/+1
| |/
* | Merge pull request #970 from nico/explainNico Weber2015-06-181-1/+7
|\ \ | | | | | | Add a missing EXPLAIN() call.
| * | Add a missing EXPLAIN() call.Nico Weber2015-05-151-1/+7
| |/
* | Add missing member initializer in Edge constructorBrad King2015-06-161-1/+2
|/ | | | | | In commit v1.1.0^2~15^2~20 (stub out an api and de-constify Pool, 2012-10-03) the Edge "pool_" member was added as a raw pointer but the initializer was accidentally left out of the constructor. Add it now.
* Fix typo in comment.Nico Weber2015-05-021-1/+1
|
* Merge pull request #962 from sgraham/pool-use-fixNico Weber2015-04-294-21/+43
|\ | | | | Fix pool use count going unbalanced
| * simplify & inlineScott Graham2015-04-272-18/+8
| |
| * avoid calling ResumeDelayedJobs insteadScott Graham2015-04-243-10/+8
| |
| * add commentScott Graham2015-04-241-0/+3
| |
| * Fix pool use count going unbalancedScott Graham2015-04-233-9/+40
| |
* | Forward interruption signal to child processes.Nicolas Despres2015-04-242-29/+34
| |
* | Allow SIGTERM for interruption.Nicolas Despres2015-04-243-6/+38
|/ | | | | Default signal sent by many other programs (mainly kill(1)) to gently terminates another one is SIGTERM.
* Run more than 34 processes on Win32 if we have 32+ cores.Rui Ueyama2015-04-171-1/+1
| | | | | | | | For compatiblity reason, dwNumberOfProcessors in Win32 is capped at 32. So even if your machine has more than 32 cores, Ninja spawns at most 34 subprocesses. This patch fixes the issue by using GetNativeSystemInfo, which returns the system info from Wow64 point of view, instead of GetSystemInfo.
* Merge pull request #954 from nico/fixNico Weber2015-04-091-1/+1
|\ | | | | Fix an assert (and tests in --debug mode) after #921.
| * Fix an assert (and tests in --debug mode) after #921.Nico Weber2015-04-091-1/+1
| |
* | Fix backslashes in graphviz causing incorrect rendering on windows.Spencer Judge2015-04-081-1/+4
|/
* Don't get stuck on cyclic graphs where one edge has multiple outputs.Nico Weber2015-04-012-4/+58
| | | | | | | | | | | | | | | | | | | Fixes #934. Plan::AddSubTarget() tracks in want_ if each edge has been visited and visits every edge only once. But Plan::CheckDependencyCycle() worked on nodes however, so if a cycle was entered through an edge with multiple outputs, ninja would fail to detect that cycle. Move cycle detection to look for duplicate edges instead of nodes to fix this. The extra jump makes CheckDependencyCycle() a bit slower: for a synthetic build file with 10000 serial build steps, `ninja -n` now takes 0.32s instead of 0.26s before on my laptop. In practice, projects have a dependency change length on the order of 50, so there shouldn't be a noticeable slowdown in practice. (If this does end up being a problem: CheckDependencyCycle() currently does O(n) work and is called O(m) times from AddSubTarget(), so I think cycle checking is O(n^2) in the build depth. So instead of worrying about constant overhead, we could use a set<> instead of a stack<>. But it doesn't seem to be a problem in practice.)
* Cleanup: Don't search stack for cycle elements twice.Nico Weber2015-04-011-4/+2
| | | | | | | | | | | | | The common case is that there is no cycle. In that case, CheckDependencyCycle() searched the stack for a dupe from the back, wouldn't find one, and return false. If there was a cycle, it would then search again from the front (probably because the push_back() that used to be here would invalidate the ri iterator). Since the push_back() is gone, just search from the front once. No intended behavior change.
* Cleanup: Make stack a const ref now that it's no longer modified.Nico Weber2015-04-012-8/+10
|
* Cleanup: Don't modify during cycle checking.Nico Weber2015-04-011-6/+2
|
* Let Stat() have an err outparam instead of writing to stderr.Nico Weber2015-03-3112-138/+192
| | | | | | | | | Also check for Stat() failure in a few more places. This way, ninja doesn't print two "ninja: error: " lines if stat() fails during a build. It also makes it easier to keep the stat tests quiet. Every caller of Stat() needs to explicitly log the error string if that's desired.
* Add an opt-in flag to make duplicate edges an error (`-w dupbuild=err`).Nico Weber2015-03-244-9/+65
| | | | | This is step 1 on #931. Duplicated edges will become an error by default in the future.
* Swap order of -k and -l in help output, to keep the list alphabetized.Nico Weber2015-03-241-1/+1
|
* Make tests quiet again.Nico Weber2015-03-242-5/+9
|
* Move warning emission on dupe edges from State to ManifestParser.Nico Weber2015-03-243-10/+11
| | | | | | | | This will make it easier to optionally make this an error (because ManifestParser has a way of printing errors), and it'll also make it easier to make the tests quiet again. No behavior change.
* Preallocate edge node vectors. ~1% faster.Nico Weber2015-03-211-0/+2
|
* Recover slowdown for cyclic rule bindings fix.Nico Weber2015-03-211-9/+17
|
* Don't crash on cyclic references between rule bindings.Nico Weber2015-03-211-0/+12
| | | | | | | | | | | | | Fixes #902. This dynamically detects cycles. I like this approach less than detecting them statically when parsing rules [1], but it has the advantage that it doesn't break existing ninja manifest files. It has the disadvantage that it slows down manifest_parser_perftest by 3.9%. 1: https://github.com/martine/ninja/commit/cc6f54d6d436047
* Another crash fix for duplicate edges. Fixes #939.Nico Weber2015-03-194-14/+38
| | | | | | | | | | | Patch #933 fixed a crash with duplicate edges by not adding edges to the graph if all the edge's outputs are already built by other edges. However, it added the edge to the out_edges of the edge's input nodes before deleting it, letting inputs refer to dead edges. To fix, move the check for deleting an edge above the code that adds inputs. Expand VerifyGraph() to check that nodes don't refer to edges that aren't present in the state.