From 9fa3491284af9a595cd46c6b230bcffb0ab8aec9 Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Tue, 2 Jun 2020 18:07:40 -0700
Subject: [clang-tidy] remove pointless string init
Found with readability-redundant-string-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
.clang-tidy | 2 ++
src/string_piece_util_test.cc | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.clang-tidy b/.clang-tidy
index 8968011..df4c1ed 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -3,9 +3,11 @@ Checks: '
,readability-avoid-const-params-in-decls,
,readability-non-const-parameter,
,readability-redundant-string-cstr,
+ ,readability-redundant-string-init,
'
WarningsAsErrors: '
,readability-avoid-const-params-in-decls,
,readability-non-const-parameter,
,readability-redundant-string-cstr,
+ ,readability-redundant-string-init,
'
diff --git a/src/string_piece_util_test.cc b/src/string_piece_util_test.cc
index b77ae84..61586dd 100644
--- a/src/string_piece_util_test.cc
+++ b/src/string_piece_util_test.cc
@@ -31,7 +31,7 @@ TEST(StringPieceUtilTest, SplitStringPiece) {
}
{
- string empty("");
+ string empty;
vector<StringPiece> list = SplitStringPiece(empty, ':');
EXPECT_EQ(list.size(), 1);
@@ -82,7 +82,7 @@ TEST(StringPieceUtilTest, JoinStringPiece) {
}
{
- string empty("");
+ string empty;
vector<StringPiece> list = SplitStringPiece(empty, ':');
EXPECT_EQ("", JoinStringPiece(list, ':'));
--
cgit v0.12