From 8b42a300bd57b93a8037e5097041c639ade8f9db Mon Sep 17 00:00:00 2001 From: scivision Date: Tue, 16 Jan 2024 12:56:15 -0500 Subject: correction to #2360 in general, flags check have to be to the non-no option. Updates use of deprecated CMake command. --- CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8a5ef00..90e3418 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -255,9 +255,9 @@ if(BUILD_TESTING) # NOTE: gtest uninit some variables, gcc >= 1.11.3 may cause error on compile. # Remove this comment and six lines below, once ninja deps gtest-1.11.0 or above. - if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "1.11.3") - check_cxx_compiler_flag(-Wno-maybe-uninitialized flag_no_maybe_uninit) - if (flag_no_maybe_uninit) + if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "1.11.3") + check_cxx_compiler_flag(-Wmaybe-uninitialized flag_maybe_uninit) + if (flag_maybe_uninit) target_compile_options(gtest PRIVATE -Wno-maybe-uninitialized) endif() endif() -- cgit v0.12