From 599d716fc78441436aebcde948886791d1988651 Mon Sep 17 00:00:00 2001 From: Evan Martin Date: Sat, 27 Oct 2012 12:56:31 -0700 Subject: delete some obsolete TODOs --- src/graph.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/graph.cc b/src/graph.cc index 0174e61..25b5baf 100644 --- a/src/graph.cc +++ b/src/graph.cc @@ -192,7 +192,7 @@ struct EdgeEnv : public Env { virtual string LookupVariable(const string& var); /// Given a span of Nodes, construct a list of paths suitable for a command - /// line. XXX here is where shell-escaping of e.g spaces should happen. + /// line. string MakePathList(vector::iterator begin, vector::iterator end, char sep); @@ -214,7 +214,6 @@ string EdgeEnv::LookupVariable(const string& var) { } else if (edge_->env_) { return edge_->env_->LookupVariable(var); } else { - // XXX should we warn here? return string(); } } -- cgit v0.12