From b0ada0efd9ee1d80d38c781fa15d73bece4a3d69 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sat, 17 May 2014 17:20:20 -0700 Subject: win console wip: Fix comments based on review feedback. --- src/subprocess-posix.cc | 2 +- src/subprocess-win32.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/subprocess-posix.cc b/src/subprocess-posix.cc index 6e4b47c..743e406 100644 --- a/src/subprocess-posix.cc +++ b/src/subprocess-posix.cc @@ -85,7 +85,7 @@ bool Subprocess::Start(SubprocessSet* set, const string& command) { error_pipe = 2; close(output_pipe[1]); } - // In the console case, child_pipe is still inherited by the child and + // In the console case, output_pipe is still inherited by the child and // closed when the subprocess finishes, which then notifies ninja. execl("/bin/sh", "/bin/sh", "-c", command.c_str(), (char *) NULL); diff --git a/src/subprocess-win32.cc b/src/subprocess-win32.cc index 4fa24c6..fad66e8 100644 --- a/src/subprocess-win32.cc +++ b/src/subprocess-win32.cc @@ -277,7 +277,7 @@ void SubprocessSet::Clear() { for (vector::iterator i = running_.begin(); i != running_.end(); ++i) { // Since the foreground process is in our process group, it will receive a - // CTRL_BREAK_EVENT at the same time as us. + // CTRL_C_EVENT or CTRL_BREAK_EVENT at the same time as us. if ((*i)->child_ && !(*i)->use_console_) { if (!GenerateConsoleCtrlEvent(CTRL_BREAK_EVENT, GetProcessId((*i)->child_))) { -- cgit v0.12