1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
|
// Copyright 2011 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "graph.h"
#include "build.h"
#include "test.h"
struct GraphTest : public StateTestWithBuiltinRules {
GraphTest() : scan_(&state_, NULL, NULL, &fs_) {}
VirtualFileSystem fs_;
DependencyScan scan_;
};
TEST_F(GraphTest, MissingImplicit) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"build out: cat in | implicit\n"));
fs_.Create("in", "");
fs_.Create("out", "");
Edge* edge = GetNode("out")->in_edge();
string err;
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
// A missing implicit dep *should* make the output dirty.
// (In fact, a build will fail.)
// This is a change from prior semantics of ninja.
EXPECT_TRUE(GetNode("out")->dirty());
}
TEST_F(GraphTest, ModifiedImplicit) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"build out: cat in | implicit\n"));
fs_.Create("in", "");
fs_.Create("out", "");
fs_.Tick();
fs_.Create("implicit", "");
Edge* edge = GetNode("out")->in_edge();
string err;
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
// A modified implicit dep should make the output dirty.
EXPECT_TRUE(GetNode("out")->dirty());
}
TEST_F(GraphTest, FunkyMakefilePath) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"rule catdep\n"
" depfile = $out.d\n"
" command = cat $in > $out\n"
"build out.o: catdep foo.cc\n"));
fs_.Create("foo.cc", "");
fs_.Create("out.o.d", "out.o: ./foo/../implicit.h\n");
fs_.Create("out.o", "");
fs_.Tick();
fs_.Create("implicit.h", "");
Edge* edge = GetNode("out.o")->in_edge();
string err;
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
// implicit.h has changed, though our depfile refers to it with a
// non-canonical path; we should still find it.
EXPECT_TRUE(GetNode("out.o")->dirty());
}
TEST_F(GraphTest, ExplicitImplicit) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"rule catdep\n"
" depfile = $out.d\n"
" command = cat $in > $out\n"
"build implicit.h: cat data\n"
"build out.o: catdep foo.cc || implicit.h\n"));
fs_.Create("implicit.h", "");
fs_.Create("foo.cc", "");
fs_.Create("out.o.d", "out.o: implicit.h\n");
fs_.Create("out.o", "");
fs_.Tick();
fs_.Create("data", "");
Edge* edge = GetNode("out.o")->in_edge();
string err;
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
// We have both an implicit and an explicit dep on implicit.h.
// The implicit dep should "win" (in the sense that it should cause
// the output to be dirty).
EXPECT_TRUE(GetNode("out.o")->dirty());
}
TEST_F(GraphTest, PathWithCurrentDirectory) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"rule catdep\n"
" depfile = $out.d\n"
" command = cat $in > $out\n"
"build ./out.o: catdep ./foo.cc\n"));
fs_.Create("foo.cc", "");
fs_.Create("out.o.d", "out.o: foo.cc\n");
fs_.Create("out.o", "");
Edge* edge = GetNode("out.o")->in_edge();
string err;
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
EXPECT_FALSE(GetNode("out.o")->dirty());
}
TEST_F(GraphTest, RootNodes) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"build out1: cat in1\n"
"build mid1: cat in1\n"
"build out2: cat mid1\n"
"build out3 out4: cat mid1\n"));
string err;
vector<Node*> root_nodes = state_.RootNodes(&err);
EXPECT_EQ(4u, root_nodes.size());
for (size_t i = 0; i < root_nodes.size(); ++i) {
string name = root_nodes[i]->path();
EXPECT_EQ("out", name.substr(0, 3));
}
}
TEST_F(GraphTest, VarInOutQuoteSpaces) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"build a$ b: cat nospace with$ space nospace2\n"));
Edge* edge = GetNode("a b")->in_edge();
EXPECT_EQ("cat nospace \"with space\" nospace2 > \"a b\"",
edge->EvaluateCommand());
}
// Regression test for https://github.com/martine/ninja/issues/380
TEST_F(GraphTest, DepfileWithCanonicalizablePath) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"rule catdep\n"
" depfile = $out.d\n"
" command = cat $in > $out\n"
"build ./out.o: catdep ./foo.cc\n"));
fs_.Create("foo.cc", "");
fs_.Create("out.o.d", "out.o: bar/../foo.cc\n");
fs_.Create("out.o", "");
Edge* edge = GetNode("out.o")->in_edge();
string err;
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
EXPECT_FALSE(GetNode("out.o")->dirty());
}
// Regression test for https://github.com/martine/ninja/issues/404
TEST_F(GraphTest, DepfileRemoved) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"rule catdep\n"
" depfile = $out.d\n"
" command = cat $in > $out\n"
"build ./out.o: catdep ./foo.cc\n"));
fs_.Create("foo.h", "");
fs_.Create("foo.cc", "");
fs_.Tick();
fs_.Create("out.o.d", "out.o: foo.h\n");
fs_.Create("out.o", "");
Edge* edge = GetNode("out.o")->in_edge();
string err;
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
EXPECT_FALSE(GetNode("out.o")->dirty());
state_.Reset();
fs_.RemoveFile("out.o.d");
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
EXPECT_TRUE(GetNode("out.o")->dirty());
}
// Check that rule-level variables are in scope for eval.
TEST_F(GraphTest, RuleVariablesInScope) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"rule r\n"
" depfile = x\n"
" command = depfile is $depfile\n"
"build out: r in\n"));
Edge* edge = GetNode("out")->in_edge();
EXPECT_EQ("depfile is x", edge->EvaluateCommand());
}
// Check that build statements can override rule builtins like depfile.
TEST_F(GraphTest, DepfileOverride) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"rule r\n"
" depfile = x\n"
" command = unused\n"
"build out: r in\n"
" depfile = y\n"));
Edge* edge = GetNode("out")->in_edge();
EXPECT_EQ("y", edge->GetBinding("depfile"));
}
// Check that overridden values show up in expansion of rule-level bindings.
TEST_F(GraphTest, DepfileOverrideParent) {
ASSERT_NO_FATAL_FAILURE(AssertParse(&state_,
"rule r\n"
" depfile = x\n"
" command = depfile is $depfile\n"
"build out: r in\n"
" depfile = y\n"));
Edge* edge = GetNode("out")->in_edge();
EXPECT_EQ("depfile is y", edge->GetBinding("command"));
}
// Verify that building a nested phony rule prints "no work to do"
TEST_F(GraphTest, NestedPhonyPrintsDone) {
AssertParse(&state_,
"build n1: phony \n"
"build n2: phony n1\n"
);
string err;
Edge* edge = GetNode("n2")->in_edge();
EXPECT_TRUE(scan_.RecomputeDirty(edge, &err));
ASSERT_EQ("", err);
Plan plan_;
EXPECT_TRUE(plan_.AddTarget(GetNode("n2"), &err));
ASSERT_EQ("", err);
EXPECT_EQ(0, plan_.command_edge_count());
ASSERT_FALSE(plan_.more_to_do());
}
|
