diff options
| author | Justin McPherson <justin.mcpherson@nokia.com> | 2009-11-11 03:48:36 (GMT) |
|---|---|---|
| committer | Justin McPherson <justin.mcpherson@nokia.com> | 2009-11-11 03:48:36 (GMT) |
| commit | 31037231e37a6f6534ca9075159181affc46bd4e (patch) | |
| tree | 4e13befddd941c830f0f7495598d38960845889f | |
| parent | 547f8d82b38dc33c036050042f41070223ff3d5f (diff) | |
| download | Qt-31037231e37a6f6534ca9075159181affc46bd4e.zip Qt-31037231e37a6f6534ca9075159181affc46bd4e.tar.gz Qt-31037231e37a6f6534ca9075159181affc46bd4e.tar.bz2 | |
gstreamer: Do not call gst_deinit() but do free the device and effect manager objects on backend destruction.
Integrated KDE change 1027566 by cguthrie.
Normally the backend is only destroyed once when the app exists, but calling gst_deinit()
means that the whole gstreamer system becomes unrecoverable. This means that if
you switch backends away from gstreamer and then back again it will not work.
Gstreamer devs recommend that you do not call gst_deinit() at all except in test cases.
Reviewed-by: Dmytro Poplavskiy
| -rw-r--r-- | src/3rdparty/phonon/gstreamer/backend.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/3rdparty/phonon/gstreamer/backend.cpp b/src/3rdparty/phonon/gstreamer/backend.cpp index e1ffd1f..be1cf0a 100644 --- a/src/3rdparty/phonon/gstreamer/backend.cpp +++ b/src/3rdparty/phonon/gstreamer/backend.cpp @@ -85,7 +85,6 @@ Backend::Backend(QObject *parent, const QVariantList &) Backend::~Backend() { - gst_deinit(); } gboolean Backend::busCall(GstBus *bus, GstMessage *msg, gpointer data) |