diff options
| author | João Abecasis <joao.abecasis@nokia.com> | 2010-05-04 16:43:42 (GMT) |
|---|---|---|
| committer | João Abecasis <joao.abecasis@nokia.com> | 2010-05-04 17:00:44 (GMT) |
| commit | 395e00552802024cb41335bc87675441ff119d3e (patch) | |
| tree | de67249c2f29e777e6372103ea7a9f9a18b49f5f | |
| parent | d59ef5d00b6c07c3a1c332ebdd0fac060538940c (diff) | |
| download | Qt-395e00552802024cb41335bc87675441ff119d3e.zip Qt-395e00552802024cb41335bc87675441ff119d3e.tar.gz Qt-395e00552802024cb41335bc87675441ff119d3e.tar.bz2 | |
Skip tst_LargeFile::mapOffsetOverflow on Mac
On this platform mmap'ing beyond EOF may succeed, even beyond filesystem
capabilities, but generate Bus Errors on access.
Skipping this failing test and accepting the underlying undefined
behavior is the right thing to do, until QFile offers proper guarantees.
Reviewed-by: Thiago Macieira
| -rw-r--r-- | tests/auto/qfile/largefile/tst_largefile.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tests/auto/qfile/largefile/tst_largefile.cpp b/tests/auto/qfile/largefile/tst_largefile.cpp index 041e5f2..60c5f89 100644 --- a/tests/auto/qfile/largefile/tst_largefile.cpp +++ b/tests/auto/qfile/largefile/tst_largefile.cpp @@ -523,6 +523,10 @@ void tst_LargeFile::mapFile() void tst_LargeFile::mapOffsetOverflow() { +#if defined(Q_OS_MAC) + QSKIP("mmap'ping beyond EOF may succeed; generate bus error on access", SkipAll); +#endif + // Out-of-range mappings should fail, and not silently clip the offset for (int i = 50; i < 63; ++i) { uchar *address = 0; |