summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNick Shaforostoff <shafff@ukr.net>2012-02-27 16:12:10 (GMT)
committerQt by Nokia <qt-info@nokia.com>2012-08-14 06:00:21 (GMT)
commit16fae7e72c4688f5000cb825da2cab3c0d2baa28 (patch)
treeb861cfbe01bc30d402c7d39f5ca7cadd8ee10cd8
parent6c432b59f9f60824731c2758503b8c563652a205 (diff)
downloadQt-16fae7e72c4688f5000cb825da2cab3c0d2baa28.zip
Qt-16fae7e72c4688f5000cb825da2cab3c0d2baa28.tar.gz
Qt-16fae7e72c4688f5000cb825da2cab3c0d2baa28.tar.bz2
fix dangling pointer access during drag-n-drop operation
delay deco widget freeing because the pointer to it is still available to the drag operation. Task-number: QTBUG-19363 Change-Id: I775864f72d7151c9fbd26feff5a9bd844f87f292 Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
-rw-r--r--src/gui/kernel/qdnd_x11.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/kernel/qdnd_x11.cpp b/src/gui/kernel/qdnd_x11.cpp
index bb29623..7257aa6 100644
--- a/src/gui/kernel/qdnd_x11.cpp
+++ b/src/gui/kernel/qdnd_x11.cpp
@@ -1788,7 +1788,7 @@ bool QX11Data::xdndHandleBadwindow()
qt_xdnd_current_proxy_target = 0;
manager->object->deleteLater();
manager->object = 0;
- delete xdnd_data.deco;
+ xdnd_data.deco->deleteLater(); //delay freeing to avoid crash QTBUG-19363
xdnd_data.deco = 0;
return true;
}