diff options
| author | Jo Asplin <jo.asplin@nokia.com> | 2011-06-27 11:10:03 (GMT) |
|---|---|---|
| committer | Rohan McGovern <rohan.mcgovern@nokia.com> | 2011-07-26 04:19:41 (GMT) |
| commit | 773e9812dfa391e27677f27112f4a3e36d471ffd (patch) | |
| tree | 46975fc25e429775f6f03c50aa824564335abdf8 | |
| parent | 808af2be5ffafffbb2642b542ec80c9be8b662c3 (diff) | |
| download | Qt-773e9812dfa391e27677f27112f4a3e36d471ffd.zip Qt-773e9812dfa391e27677f27112f4a3e36d471ffd.tar.gz Qt-773e9812dfa391e27677f27112f4a3e36d471ffd.tar.bz2 | |
Disabled benchmarks referring to private headers.
Certain benchmarks that referred to private
headers are removed from the list of 'trusted'
benchmarks.
Benchmarks referring to private headers are considered
bad practice for several reasons:
1) Such tests won't even build if private headers
are not avaiable in the installed version of Qt.
2) APIs should be designed well enough to be fully
testable through its public headers only.
Change-Id: Iccd81e12829a7b7f4bd2b88a72f3e9722520f6e2
Reviewed-by: Rohan McGovern
| -rw-r--r-- | tests/benchmarks/gui/gui.pro | 5 | ||||
| -rw-r--r-- | tests/benchmarks/network/network.pro | 3 | ||||
| -rw-r--r-- | tests/benchmarks/script/script.pro | 1 |
3 files changed, 3 insertions, 6 deletions
diff --git a/tests/benchmarks/gui/gui.pro b/tests/benchmarks/gui/gui.pro index d825458..06828f4 100644 --- a/tests/benchmarks/gui/gui.pro +++ b/tests/benchmarks/gui/gui.pro @@ -12,7 +12,6 @@ SUBDIRS = \ TRUSTED_BENCHMARKS += \ graphicsview/functional/GraphicsViewBenchmark \ - graphicsview/qgraphicsview \ - painting/qtracebench + graphicsview/qgraphicsview -include(../trusted-benchmarks.pri)
\ No newline at end of file +include(../trusted-benchmarks.pri) diff --git a/tests/benchmarks/network/network.pro b/tests/benchmarks/network/network.pro index 692a0a1..52817f9 100644 --- a/tests/benchmarks/network/network.pro +++ b/tests/benchmarks/network/network.pro @@ -6,8 +6,7 @@ SUBDIRS = \ socket TRUSTED_BENCHMARKS += \ - kernel/qhostinfo \ socket/qtcpserver \ ssl/qsslsocket -include(../trusted-benchmarks.pri)
\ No newline at end of file +include(../trusted-benchmarks.pri) diff --git a/tests/benchmarks/script/script.pro b/tests/benchmarks/script/script.pro index 5da05e7..3216b24 100644 --- a/tests/benchmarks/script/script.pro +++ b/tests/benchmarks/script/script.pro @@ -13,7 +13,6 @@ SUBDIRS = \ TRUSTED_BENCHMARKS += \ qscriptclass \ qscriptvalue \ - qscriptengine \ qscriptqobject include(../trusted-benchmarks.pri) |