Fix setPermissions in symbian

In error, it was checking the read permissions to set the read-only
file attribute, when it should have been checking the write permissions.
read-only = !writable.

Reviewed-By: Thomas Zander

1 files changed, 4 insertions, 4 deletions

diff --git a/src/corelib/io/qfilesystemengine_symbian.cpp b/src/corelib/io/qfilesystemengine_symbian.cpp
index 1ed4ee8..6bad860 100644
--- a/src/corelib/io/qfilesystemengine_symbian.cpp
+++ b/src/corelib/io/qfilesystemengine_symbian.cpp
@@ -290,7 +290,7 @@ bool QFileSystemEngine::removeFile(const QFileSystemEntry &entry)
     QString targetpath = absoluteName(entry).nativeFilePath();
     RFs& fs(qt_s60GetRFs());
     TInt err = fs.Delete(qt_QString2TPtrC(targetpath));
-    return false; // TODO error reporting;
+    return err == KErrNone; // TODO error reporting;
 }
 
 //static
@@ -300,8 +300,8 @@ bool QFileSystemEngine::setPermissions(const QFileSystemEntry &entry, QFile::Per
     TUint setmask = 0;
     TUint clearmask = 0;
     RFs& fs(qt_s60GetRFs());
-    if (permissions & (QFile::ReadOwner | QFile::ReadUser | QFile::ReadGroup | QFile::ReadOther))
-        clearmask = KEntryAttReadOnly;
+    if (permissions & (QFile::WriteOwner | QFile::WriteUser | QFile::WriteGroup | QFile::WriteOther))
+        clearmask = KEntryAttReadOnly; //if anyone can write, it's not read-only
     else
         setmask = KEntryAttReadOnly;
     TInt err = fs.SetAtt(qt_QString2TPtrC(targetpath), setmask, clearmask);
@@ -310,7 +310,7 @@ bool QFileSystemEngine::setPermissions(const QFileSystemEntry &entry, QFile::Per
         data->entryFlags |= QFileSystemMetaData::MetaDataFlag(uint(permissions));
         data->knownFlagsMask |= QFileSystemMetaData::Permissions;
     }
-    return err != KErrNone; // TODO error reporting
+    return err == KErrNone; // TODO error reporting
 }
 
 QT_END_NAMESPACE