summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRohan McGovern <rohan.mcgovern@nokia.com>2010-12-30 22:20:39 (GMT)
committerRohan McGovern <rohan.mcgovern@nokia.com>2010-12-30 22:36:20 (GMT)
commit8365b863419ad68f7dde7b7595e1b943ad9670ca (patch)
tree79b29bd3443347068cbd870041cd1153e0b4aeba
parent9e26955ab926afe1bc3306d5f6fcab0c5dfe4db1 (diff)
downloadQt-8365b863419ad68f7dde7b7595e1b943ad9670ca.zip
Qt-8365b863419ad68f7dde7b7595e1b943ad9670ca.tar.gz
Qt-8365b863419ad68f7dde7b7595e1b943ad9670ca.tar.bz2
Fixed networkselftest failing to resolve hostname
The logic here was the opposite from what was intended. Note that this bug was hidden under normal circumstances when running the entire testcase. It only appeared when one of the following was true: (1) httpProxy or socks5Proxy was run on its own, or (2) the dnsResolution test failed.
-rw-r--r--tests/auto/networkselftest/tst_networkselftest.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/auto/networkselftest/tst_networkselftest.cpp b/tests/auto/networkselftest/tst_networkselftest.cpp
index 752e368..5e9c50e 100644
--- a/tests/auto/networkselftest/tst_networkselftest.cpp
+++ b/tests/auto/networkselftest/tst_networkselftest.cpp
@@ -337,7 +337,7 @@ QHostAddress tst_NetworkSelfTest::serverIpAddress()
// need resolving
QHostInfo resolved = QHostInfo::fromName(QtNetworkSettings::serverName());
if(resolved.error() != QHostInfo::NoError ||
- !resolved.addresses().isEmpty()) {
+ resolved.addresses().isEmpty()) {
qWarning("QHostInfo::fromName failed (%d).", resolved.error());
return QHostAddress(QHostAddress::Null);
}