diff options
author | Bill King <bill.king@nokia.com> | 2010-01-11 04:15:56 (GMT) |
---|---|---|
committer | Jason McDonald <jason.mcdonald@nokia.com> | 2010-01-11 13:05:34 (GMT) |
commit | d4a854f6d25e00ef488ef9e04d10203426312dde (patch) | |
tree | a5e30e83bf402d12efc7d191d82e2cc693852170 | |
parent | 217c63fc83577e35a9cd07fd356ca08d349413f3 (diff) | |
download | Qt-d4a854f6d25e00ef488ef9e04d10203426312dde.zip Qt-d4a854f6d25e00ef488ef9e04d10203426312dde.tar.gz Qt-d4a854f6d25e00ef488ef9e04d10203426312dde.tar.bz2 |
(Sqlite2) Fix for QTBUG-6421
Forgot to port the fix over to sqlite2 which seems to also be affected
by the setForwardOnly caching bug as well.
Task-number: QTBUG-6421
Reviewed-by: Justin McPherson
(cherry picked from commit 8d76de98d93421395306941e59d136f1e7395d15)
-rw-r--r-- | src/sql/drivers/sqlite2/qsql_sqlite2.cpp | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/src/sql/drivers/sqlite2/qsql_sqlite2.cpp b/src/sql/drivers/sqlite2/qsql_sqlite2.cpp index 2ce0f46..8a010be 100644 --- a/src/sql/drivers/sqlite2/qsql_sqlite2.cpp +++ b/src/sql/drivers/sqlite2/qsql_sqlite2.cpp @@ -110,10 +110,11 @@ public: const char *currentTail; sqlite_vm *currentMachine; - uint skippedStatus: 1; // the status of the fetchNext() that's skipped - uint skipRow: 1; // skip the next fetchNext()? - uint utf8: 1; + bool skippedStatus; // the status of the fetchNext() that's skipped + bool skipRow; // skip the next fetchNext()? + bool utf8; QSqlRecord rInf; + QVector<QVariant> firstRow; }; static const uint initial_cache_size = 128; @@ -192,6 +193,8 @@ bool QSQLite2ResultPrivate::fetchNext(QSqlCachedResult::ValueCache &values, int // already fetched Q_ASSERT(!initialFetch); skipRow = false; + for(int i=0;i<firstRow.count(); i++) + values[i] = firstRow[i]; return skippedStatus; } skipRow = initialFetch; @@ -209,6 +212,11 @@ bool QSQLite2ResultPrivate::fetchNext(QSqlCachedResult::ValueCache &values, int #endif } + if(initialFetch) { + firstRow.clear(); + firstRow.resize(colNum); + } + switch(res) { case SQLITE_ROW: // check to see if should fill out columns @@ -299,7 +307,7 @@ bool QSQLite2Result::reset (const QString& query) } // we have to fetch one row to find out about // the structure of the result set - d->skippedStatus = d->fetchNext(cache(), 0, true); + d->skippedStatus = d->fetchNext(d->firstRow, 0, true); if (lastError().isValid()) { setSelect(false); setActive(false); |