diff options
author | axis <qt-info@nokia.com> | 2011-01-31 13:39:23 (GMT) |
---|---|---|
committer | axis <qt-info@nokia.com> | 2011-01-31 14:19:30 (GMT) |
commit | 3f6da18e492a58d65feabdb2037b13d38ddf83bd (patch) | |
tree | da47e4d5e7421ae72d105f8ab1234e7dfdb90b65 /qmake | |
parent | 5cd39cd8a70be4c22164fe060ad64a1d9108bf41 (diff) | |
download | Qt-3f6da18e492a58d65feabdb2037b13d38ddf83bd.zip Qt-3f6da18e492a58d65feabdb2037b13d38ddf83bd.tar.gz Qt-3f6da18e492a58d65feabdb2037b13d38ddf83bd.tar.bz2 |
Fixed win32-msvc2008 build regression.
We needed to move the code in the init() function to the
fixTargetExt() function, which is where the variables are actually
used. The reason is that fixTargetExt() runs before init().
RevBy: Miikka Heikkinen
Diffstat (limited to 'qmake')
-rw-r--r-- | qmake/generators/win32/winmakefile.cpp | 13 | ||||
-rw-r--r-- | qmake/generators/win32/winmakefile.h | 1 |
2 files changed, 5 insertions, 9 deletions
diff --git a/qmake/generators/win32/winmakefile.cpp b/qmake/generators/win32/winmakefile.cpp index 409d550..603ffb5 100644 --- a/qmake/generators/win32/winmakefile.cpp +++ b/qmake/generators/win32/winmakefile.cpp @@ -57,14 +57,6 @@ Win32MakefileGenerator::Win32MakefileGenerator() : MakefileGenerator() { } -void Win32MakefileGenerator::init() -{ - if (project->isEmpty("QMAKE_EXTENSION_STATICLIB")) - project->values("QMAKE_EXTENSION_STATICLIB").append("lib"); - if (project->isEmpty("QMAKE_EXTENSION_SHLIB")) - project->values("QMAKE_EXTENSION_SHLIB").append("lib"); -} - int Win32MakefileGenerator::findHighestVersion(const QString &d, const QString &stem, const QString &ext) { @@ -373,6 +365,11 @@ void Win32MakefileGenerator::processVars() void Win32MakefileGenerator::fixTargetExt() { + if (project->isEmpty("QMAKE_EXTENSION_STATICLIB")) + project->values("QMAKE_EXTENSION_STATICLIB").append("lib"); + if (project->isEmpty("QMAKE_EXTENSION_SHLIB")) + project->values("QMAKE_EXTENSION_SHLIB").append("dll"); + if (!project->values("QMAKE_APP_FLAG").isEmpty()) { project->values("TARGET_EXT").append(".exe"); } else if (project->isActiveConfig("shared")) { diff --git a/qmake/generators/win32/winmakefile.h b/qmake/generators/win32/winmakefile.h index cfc2c55..fb11e1a 100644 --- a/qmake/generators/win32/winmakefile.h +++ b/qmake/generators/win32/winmakefile.h @@ -59,7 +59,6 @@ class Win32MakefileGenerator : public MakefileGenerator public: Win32MakefileGenerator(); ~Win32MakefileGenerator(); - void init(); protected: virtual QString defaultInstall(const QString &); virtual void writeCleanParts(QTextStream &t); |