diff options
author | Gareth Stockwell <gareth.stockwell@sosco.com> | 2009-08-18 08:12:47 (GMT) |
---|---|---|
committer | Gareth Stockwell <gareth.stockwell@sosco.com> | 2009-08-18 08:15:29 (GMT) |
commit | 008d464ea90a0a33f16bd6ce29563e7dd206b91f (patch) | |
tree | 7156f7124e8b520b1559e4cce1f0f2476cf075e6 /src/3rdparty/phonon/mmf/utils.h | |
parent | 427c415d876d57042a55e8b66730888512ac0ed1 (diff) | |
parent | 6b7603a0a2fed844b1264d8deb0ce78b110858c4 (diff) | |
download | Qt-008d464ea90a0a33f16bd6ce29563e7dd206b91f.zip Qt-008d464ea90a0a33f16bd6ce29563e7dd206b91f.tar.gz Qt-008d464ea90a0a33f16bd6ce29563e7dd206b91f.tar.bz2 |
Merged recognizer changes with abstraction for audio / video playback.
Audio playback now working to the same extent as prior to the abstraction, with one regression: the initial volume level in the UI is set to zero, although playback is audible.
Some cleanup is required:
- Functionality common to AudioPlayer and VideoPlayer (e.g. tick timer, changeState function) should be moved into AbstractPlayer.
- Files may be opened by multiple instances of MediaObject at at time. For example, the musicplayer example app uses one instance to read file metadata, and one for the actual playback. In order to avoid KErrInUse errors from the file server, files must be opened with an EShare* flag and passed around by handle. At present this is done in a slightly hacky way (i.e. AbstractPlayer::setSource is renamed to setFileSource).
- The pointer held by MediaObject::m_player must be checked for nullness in many of the public API calls. This could be made cleaner by implementing a stub derivation of AbstractPlayer, which returns sensible default values. Note that, if functionality such as tick timer handling is going to be pushed upwards from AudioPlayer / VideoPlayer, we should add an intermediate class to the hierarchy so that the overhead of constructing DummyPlayer objects is minimised.
At present, media type (audio / video) is only recognised from file streams - this needs to be extended to include HTTP streaming aswell.
Diffstat (limited to 'src/3rdparty/phonon/mmf/utils.h')
-rw-r--r-- | src/3rdparty/phonon/mmf/utils.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/3rdparty/phonon/mmf/utils.h b/src/3rdparty/phonon/mmf/utils.h index 4b967fc..72d5472 100644 --- a/src/3rdparty/phonon/mmf/utils.h +++ b/src/3rdparty/phonon/mmf/utils.h @@ -117,6 +117,7 @@ namespace Phonon #define TRACE_EXIT(string, args...) { if(_tc.Enabled()) _TRACE_PRINT(_TRACE_TEXT(L ## "- Phonon::MMF::%s [0x%08x] " L ## string), _tc.iFunction, _tc.iAddr, args); } #define TRACE_RETURN(string, result) { if(_tc.Enabled()) _TRACE_PRINT(_TRACE_TEXT(L ## "r Phonon::MMF::%s [0x%08x] " L ## string), _tc.iFunction, _tc.iAddr, result); } return result; #define TRACE_PANIC(code) { _TRACE_PRINT(_TRACE_TEXT(L ## "! Phonon::MMF::%s [0x%08x] panic %d"), _tc.iFunction, _tc.iAddr, code); } Utils::panic(code); + #define TRACE_0(string) { if(_tc.Enabled()) _TRACE_PRINT(_TRACE_TEXT(L ## "Phonon::MMF::%s [0x%08x] " L ## string), _tc.iFunction, _tc.iAddr); } #define TRACE(string, args...) { if(_tc.Enabled()) _TRACE_PRINT(_TRACE_TEXT(L ## "Phonon::MMF::%s [0x%08x] " L ## string), _tc.iFunction, _tc.iAddr, args); } #else #define TRACE_CONTEXT(_fn, _cat) @@ -126,6 +127,7 @@ namespace Phonon #define TRACE_EXIT(string, args...) #define TRACE_RETURN(string, result) return result; #define TRACE_PANIC(code) Utils::panic(code); + #define TRACE_0(string) #define TRACE(string, args...) #endif } |