summaryrefslogtreecommitdiffstats
path: root/src/corelib/thread
diff options
context:
space:
mode:
authormread <qt-info@nokia.com>2011-02-17 11:43:54 (GMT)
committermread <qt-info@nokia.com>2011-03-09 12:47:12 (GMT)
commit04510ff7b065b27f2a80f2cbf42cb097c98923b0 (patch)
tree27cdf4dd9327d39ee16ab60a829d4ea9bfe45a92 /src/corelib/thread
parenta84dcc30b096915dc71d8c9696696731dee45c48 (diff)
downloadQt-04510ff7b065b27f2a80f2cbf42cb097c98923b0.zip
Qt-04510ff7b065b27f2a80f2cbf42cb097c98923b0.tar.gz
Qt-04510ff7b065b27f2a80f2cbf42cb097c98923b0.tar.bz2
Improving init_symbian_thread_handle
From review comments on QThread_Symbian.cpp. init_symbian_thread_handle now opens the thread with process wide ownership directly, rather than going through an intermediate Duplicate. Retested QTBUG-13612 test case, which originally caused that function to be written. tst_qthread passes. Task-number: QTBUG-13990 Reviewed-by: Shane Kearns
Diffstat (limited to 'src/corelib/thread')
-rw-r--r--src/corelib/thread/qthread_symbian.cpp7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/corelib/thread/qthread_symbian.cpp b/src/corelib/thread/qthread_symbian.cpp
index bb1a4a7..4bbf5e3 100644
--- a/src/corelib/thread/qthread_symbian.cpp
+++ b/src/corelib/thread/qthread_symbian.cpp
@@ -78,12 +78,7 @@ static void init_symbian_thread_handle(RThread &thread)
{
thread = RThread();
TThreadId threadId = thread.Id();
- thread.Open(threadId);
-
- // Make thread handle accessible process wide
- RThread originalCloser = thread;
- thread.Duplicate(thread, EOwnerProcess);
- originalCloser.Close();
+ qt_symbian_throwIfError(thread.Open(threadId, EOwnerProcess));
}
QThreadData *QThreadData::current()