Merge branch 'kinetic-declarativeui' of git@scm.dev.nokia.troll.no:qt/kinetic into kinetic-declarativeui-scriptopt

2 files changed, 57 insertions, 39 deletions

diff --git a/src/declarative/util/qmllistmodel.cpp b/src/declarative/util/qmllistmodel.cpp
index 69bed25..062ab48 100644
--- a/src/declarative/util/qmllistmodel.cpp
+++ b/src/declarative/util/qmllistmodel.cpp
@@ -239,41 +239,8 @@ struct ModelNode
         return objectCache;
     }
 
-    void setListValue(const QScriptValue& valuelist) {
-        QScriptValueIterator it(valuelist);
-        values.clear();
-        while (it.hasNext()) {
-            it.next();
-            ModelNode *value = new ModelNode;
-            QScriptValue v = it.value();
-            if (v.isArray()) {
-                value->setListValue(v);
-            } else if (v.isObject()) {
-                value->setObjectValue(v);
-            } else {
-                value->values << v.toVariant();
-            }
-            values.append(qVariantFromValue(value));
-
-        }
-    }
-
-    void setObjectValue(const QScriptValue& valuemap) {
-        QScriptValueIterator it(valuemap);
-        while (it.hasNext()) {
-            it.next();
-            ModelNode *value = new ModelNode;
-            QScriptValue v = it.value();
-            if (v.isArray()) {
-                value->setListValue(v);
-            } else if (v.isObject()) {
-                value->setObjectValue(v);
-            } else {
-                value->values << v.toVariant();
-            }
-            properties.insert(it.name(),value);
-        }
-    }
+    void setObjectValue(const QScriptValue& valuemap);
+    void setListValue(const QScriptValue& valuelist);
 
     void setProperty(const QString& prop, const QVariant& val) {
         QHash<QString, ModelNode *>::const_iterator it = properties.find(prop);
@@ -292,6 +259,48 @@ struct ModelNode
     ModelObject *objectCache;
 };
 
+QT_END_NAMESPACE
+
+Q_DECLARE_METATYPE(ModelNode *)
+
+QT_BEGIN_NAMESPACE
+void ModelNode::setObjectValue(const QScriptValue& valuemap) {
+    QScriptValueIterator it(valuemap);
+    while (it.hasNext()) {
+        it.next();
+        ModelNode *value = new ModelNode;
+        QScriptValue v = it.value();
+        if (v.isArray()) {
+            value->setListValue(v);
+        } else if (v.isObject()) {
+            value->setObjectValue(v);
+        } else {
+            value->values << v.toVariant();
+        }
+        properties.insert(it.name(),value);
+    }
+}
+
+void ModelNode::setListValue(const QScriptValue& valuelist) {
+    QScriptValueIterator it(valuelist);
+    values.clear();
+    while (it.hasNext()) {
+        it.next();
+        ModelNode *value = new ModelNode;
+        QScriptValue v = it.value();
+        if (v.isArray()) {
+            value->setListValue(v);
+        } else if (v.isObject()) {
+            value->setObjectValue(v);
+        } else {
+            value->values << v.toVariant();
+        }
+        values.append(qVariantFromValue(value));
+
+    }
+}
+
+
 ModelObject::ModelObject()
 : _mo(new QmlOpenMetaObject(this))
 {
@@ -846,7 +855,6 @@ ModelNode::~ModelNode()
 
 QT_END_NAMESPACE
 
-Q_DECLARE_METATYPE(ModelNode *)
 QML_DECLARE_TYPE(QmlListElement)
 
 #include "qmllistmodel.moc"
diff --git a/src/declarative/util/qmltimer.cpp b/src/declarative/util/qmltimer.cpp
index b95d6ad..fdc57ff 100644
--- a/src/declarative/util/qmltimer.cpp
+++ b/src/declarative/util/qmltimer.cpp
@@ -100,6 +100,8 @@ QmlTimer::QmlTimer(QObject *parent)
     \qmlproperty int Timer::interval
 
     Sets the \a interval in milliseconds between triggering.
+
+    The default interval is 1000 milliseconds.
 */
 void QmlTimer::setInterval(int interval)
 {
@@ -123,6 +125,8 @@ int QmlTimer::interval() const
     For a non-repeating timer, \a running  will be set to false after the
     timer has been triggered.
 
+    \a running defaults to false.
+
     \sa repeat
 */
 bool QmlTimer::isRunning() const
@@ -148,6 +152,8 @@ void QmlTimer::setRunning(bool running)
     specified interval; otherwise, the timer will trigger once at the
     specified interval and then stop (i.e. running will be set to false).
 
+    \a repeat defaults to false.
+
     \sa running
 */
 bool QmlTimer::isRepeating() const
@@ -169,7 +175,11 @@ void QmlTimer::setRepeating(bool repeating)
     \qmlproperty bool Timer::triggeredOnStart
 
     If \a triggeredOnStart is true, the timer will be triggered immediately
-    when started, and subsequently at the specified interval.
+    when started, and subsequently at the specified interval.  Note that for
+    a Timer with \e repeat set to false, this will result in the timer being
+    triggered twice; once on start, and again at the interval.
+
+    \a triggeredOnStart defaults to false.
 
     \sa running
 */
@@ -198,7 +208,7 @@ void QmlTimer::setTriggeredOnStart(bool triggeredOnStart)
 void QmlTimer::start()
 {
     Q_D(QmlTimer);
-    d->pause.start();
+    setRunning(true);
 }
 
 /*!
@@ -211,7 +221,7 @@ void QmlTimer::start()
 void QmlTimer::stop()
 {
     Q_D(QmlTimer);
-    d->pause.stop();
+    setRunning(false);
 }
 
 void QmlTimer::update()