diff options
| author | Bjørn Erik Nilsen <bjorn.nilsen@nokia.com> | 2010-01-22 16:25:38 (GMT) |
|---|---|---|
| committer | Bjørn Erik Nilsen <bjorn.nilsen@nokia.com> | 2010-01-22 17:45:58 (GMT) |
| commit | 5f4af1b5b5a96875b42750a778dcf6695a844623 (patch) | |
| tree | d2ece281dfe69bd432fcab1d3442980286c51a17 /src/gui/graphicsview/qgraphicsscene_p.h | |
| parent | 3e51b6c872e86a5e68a8e59770fc1bc32b84da0c (diff) | |
| download | Qt-5f4af1b5b5a96875b42750a778dcf6695a844623.zip Qt-5f4af1b5b5a96875b42750a778dcf6695a844623.tar.gz Qt-5f4af1b5b5a96875b42750a778dcf6695a844623.tar.bz2 | |
Potential crash when adding items from QGraphicsWidget::polishEvent().
These were processed immediately, so there was a fair chance that we
could end up doing a virtual function call on items that were not fully
constructed. This patch is also an optimization, since we never remove
anything from the vector.
Auto-test included.
Reviewed-by: Jan-Arve
Diffstat (limited to 'src/gui/graphicsview/qgraphicsscene_p.h')
| -rw-r--r-- | src/gui/graphicsview/qgraphicsscene_p.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/gui/graphicsview/qgraphicsscene_p.h b/src/gui/graphicsview/qgraphicsscene_p.h index a3e36d0..54d8130 100644 --- a/src/gui/graphicsview/qgraphicsscene_p.h +++ b/src/gui/graphicsview/qgraphicsscene_p.h @@ -111,7 +111,6 @@ public: QVector<QGraphicsItem *> unpolishedItems; QList<QGraphicsItem *> topLevelItems; bool needSortTopLevelItems; - bool unpolishedItemsModified; bool holesInTopLevelSiblingIndex; bool topLevelSequentialOrdering; |