summaryrefslogtreecommitdiffstats
path: root/src/gui/graphicsview/qgraphicsscene_p.h
diff options
context:
space:
mode:
authorJ-P Nurmi <jpnurmi@gmail.com>2009-10-09 07:45:45 (GMT)
committerAlexis Menard <alexis.menard@nokia.com>2009-10-09 07:46:23 (GMT)
commitfc3dfc20d487cb4fd2f93bd9fa36eef85a7467a3 (patch)
tree658ccef93309ca9e58654ec32cd80a19a6775ee4 /src/gui/graphicsview/qgraphicsscene_p.h
parent0054b444a202d08167c49a1a94fd2d306d14f91f (diff)
downloadQt-fc3dfc20d487cb4fd2f93bd9fa36eef85a7467a3.zip
Qt-fc3dfc20d487cb4fd2f93bd9fa36eef85a7467a3.tar.gz
Qt-fc3dfc20d487cb4fd2f93bd9fa36eef85a7467a3.tar.bz2
Fixed a potential crash in QGraphicsScenePrivate::_q_polishItems()
This patch make sure that we always start from the beginning of the unpolished items list and we erase the first value at each iteration. The patch also convert the list to a set that is more appropriate here. Merge-request: 1707 Reviewed-by: Alexis Menard <alexis.menard@nokia.com>
Diffstat (limited to 'src/gui/graphicsview/qgraphicsscene_p.h')
-rw-r--r--src/gui/graphicsview/qgraphicsscene_p.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/graphicsview/qgraphicsscene_p.h b/src/gui/graphicsview/qgraphicsscene_p.h
index 5000860..8073695 100644
--- a/src/gui/graphicsview/qgraphicsscene_p.h
+++ b/src/gui/graphicsview/qgraphicsscene_p.h
@@ -108,7 +108,7 @@ public:
QPainterPath selectionArea;
int selectionChanging;
QSet<QGraphicsItem *> selectedItems;
- QList<QGraphicsItem *> unpolishedItems;
+ QSet<QGraphicsItem *> unpolishedItems;
QList<QGraphicsItem *> topLevelItems;
bool needSortTopLevelItems;
bool holesInTopLevelSiblingIndex;