diff options
| author | Oswald Buddenhagen <oswald.buddenhagen@nokia.com> | 2010-01-29 15:44:12 (GMT) |
|---|---|---|
| committer | Oswald Buddenhagen <oswald.buddenhagen@nokia.com> | 2010-02-01 13:13:43 (GMT) |
| commit | e0fda52fde32458c4a42f04bd62b5e37f14c4bfd (patch) | |
| tree | df8154a8878f767c87a5cae8ad9d1dc4e17ebffd /src/gui/itemviews/qitemdelegate.cpp | |
| parent | 45591e13862963fb29c13e0c5bfe39330883c579 (diff) | |
| download | Qt-e0fda52fde32458c4a42f04bd62b5e37f14c4bfd.zip Qt-e0fda52fde32458c4a42f04bd62b5e37f14c4bfd.tar.gz Qt-e0fda52fde32458c4a42f04bd62b5e37f14c4bfd.tar.bz2 | |
optimization: get rid of QString::fromUtf16() usage
QString::fromUtf16() is slow - it does a BOM check and optionally byte
swapping, which is utterly pointless when converting internal data
structures which are raw utf16 in host byte order anyway. so replace
it with QString::fromRawData() (for short-lived strings) or
QString(const QChar *, int) (otherwise) if possible.
Reviewed-by: axis
Reviewed-by: mariusSO
Reviewed-by: Bill King
Diffstat (limited to 'src/gui/itemviews/qitemdelegate.cpp')
| -rw-r--r-- | src/gui/itemviews/qitemdelegate.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/itemviews/qitemdelegate.cpp b/src/gui/itemviews/qitemdelegate.cpp index 6fd26a7..9069ce4 100644 --- a/src/gui/itemviews/qitemdelegate.cpp +++ b/src/gui/itemviews/qitemdelegate.cpp @@ -1033,7 +1033,7 @@ static QString qPixmapSerial(quint64 i, bool enabled) i >>= 4; } - return QString::fromUtf16(ptr, int(&arr[sizeof(arr) / sizeof(ushort)] - ptr)); + return QString((const QChar *)ptr, int(&arr[sizeof(arr) / sizeof(ushort)] - ptr)); } /*! |