Merge branch 'master' of git@scm.dev.troll.no:qt/qt-s60-public

1 files changed, 215 insertions, 224 deletions

diff --git a/src/gui/styles/qs60style.cpp b/src/gui/styles/qs60style.cpp
index f7a1700..83f5a6b 100644
--- a/src/gui/styles/qs60style.cpp
+++ b/src/gui/styles/qs60style.cpp
@@ -50,7 +50,6 @@
 #include "qcalendarwidget.h"
 #include "qdial.h"
 #include "qdialog.h"
-#include "qerrormessage.h"
 #include "qgroupbox.h"
 #include "qheaderview.h"
 #include "qlist.h"
@@ -58,7 +57,6 @@
 #include "qlistview.h"
 #include "qmenu.h"
 #include "qmenubar.h"
-#include "qmessagebox.h"
 #include "qpushbutton.h"
 #include "qscrollarea.h"
 #include "qscrollbar.h"
@@ -116,8 +114,6 @@ const short QS60StylePrivate::data[][MAX_PIXELMETRICS] = {
 {7,0,-909,0,0,2,0,0,-1,20,52,28,19,19,9,258,-909,-909,-909,29,19,6,0,0,32,-909,60,-909,5,5,2,-909,-909,0,7,32,0,17,29,22,22,27,27,7,173,29,0,-909,-909,-909,-909,0,0,26,2,-909,0,0,-909,26,-909,-909,-909,-909,87,27,98,35,98,5,5,6,8,19,-909,7,74,22,7,0,5,5,8,12,5,5,-909,2,-909,-909,-909,-909,7,7,3,1},
 {7,0,-909,0,0,2,0,0,-1,10,20,27,18,18,9,301,-909,-909,-909,29,18,5,0,0,35,-909,32,-909,5,5,2,-909,-909,0,2,8,0,16,28,21,21,26,26,2,170,26,0,-909,-909,-909,-909,0,0,21,5,-909,0,0,-909,-909,-909,-909,-909,-909,54,26,265,34,265,5,5,6,3,18,-909,7,72,19,7,0,8,6,5,11,6,5,-909,2,-909,-909,-909,-909,5,5,3,1},
 {7,0,-909,0,0,2,0,0,-1,10,20,27,18,18,9,301,-909,-909,-909,29,18,5,0,0,35,-909,32,-909,5,5,2,-909,-909,0,2,8,0,16,28,21,21,26,26,2,170,26,0,-909,-909,-909,-909,0,0,21,6,-909,0,0,-909,-909,-909,-909,-909,-909,54,26,265,34,265,5,5,6,3,18,-909,7,72,19,7,0,5,6,8,11,6,5,-909,2,-909,-909,-909,-909,5,5,3,1}
-
-
 // *** End of generated data ***
 };
 
@@ -126,6 +122,7 @@ const short *QS60StylePrivate::m_pmPointer = QS60StylePrivate::data[0];
 // theme background texture
 QPixmap *QS60StylePrivate::m_background = 0;
 
+// theme palette
 QPalette *QS60StylePrivate::m_themePalette = 0;
 
 const struct QS60StylePrivate::frameElementCenter QS60StylePrivate::m_frameElementsData[] = {
@@ -144,10 +141,12 @@ const struct QS60StylePrivate::frameElementCenter QS60StylePrivate::m_frameEleme
     {SE_PanelBackground,        QS60StyleEnums::SP_QsnFrSetOptCenter},
     {SE_ButtonInactive,         QS60StyleEnums::SP_QsnFrButtonCenterInactive},
 };
+
 static const int frameElementsCount =
     int(sizeof(QS60StylePrivate::m_frameElementsData)/sizeof(QS60StylePrivate::m_frameElementsData[0]));
 
-const int KNotFound = -1;
+const int KNotFound = -909;
+const double KTabFontMul = 0.72;
 
 QS60StylePrivate::~QS60StylePrivate()
 {
@@ -292,8 +291,6 @@ short QS60StylePrivate::pixelMetric(int metric)
 {
     Q_ASSERT(metric < MAX_PIXELMETRICS);
     const short returnValue = m_pmPointer[metric];
-    if (returnValue==-909)
-        return -1;
     return returnValue;
 }
 
@@ -308,7 +305,6 @@ void QS60StylePrivate::setStyleProperty(const char *name, const QVariant &value)
         QApplication::setLayoutDirection(m_layoutHeaders[layoutIndex].mirroring ? Qt::RightToLeft : Qt::LeftToRight);
         clearCaches();
         refreshUI();
-        return;
     }
 }
 
@@ -360,8 +356,7 @@ QColor QS60StylePrivate::lighterColor(const QColor &baseColor)
 
 bool QS60StylePrivate::drawsOwnThemeBackground(const QWidget *widget)
 {
-    return (qobject_cast<const QMessageBox *> (widget) ||
-            qobject_cast<const QErrorMessage *> (widget));
+    return qobject_cast<const QDialog *> (widget);
 }
 
 QFont QS60StylePrivate::s60Font(
@@ -413,8 +408,8 @@ void QS60StylePrivate::clearCaches(QS60StylePrivate::CacheClearReason reason)
 }
 
 // Since S60Style has 'button' and 'tooltip' as a graphic, we don't have any native color which to use
-// for QPalette::Button and QPalette::ToolTipBase. Therefore we need to guesstimate
-// this by calculating average rgb values for button pixels.
+// for QPalette::Button and QPalette::ToolTipBase. Therefore S60Style needs to guesstimate
+// palette colors by calculating average rgb values for button pixels.
 // Returns Qt::black if there is an issue with the graphics (image is NULL, or no bits() found).
 QColor QS60StylePrivate::colorFromFrameGraphics(QS60StylePrivate::SkinFrameElements frame) const
 {
@@ -562,11 +557,11 @@ void QS60StylePrivate::drawRow(QS60StyleEnums::SkinParts start,
     QRect endRect;
 
     if (orientation == Qt::Horizontal) {
-        startRect.setWidth(qMin(rect.width() / 2 - 1, startRect.width()));
+        startRect.setWidth(qMin(rect.width() >>1 - 1, startRect.width()));
         endRect = startRect.translated(rect.width() - startRect.width(), 0);
         middleRect.adjust(startRect.width(), 0, -startRect.width(), 0);
     } else {
-        startRect.setHeight(qMin(rect.height() / 2 - 1, startRect.height()));
+        startRect.setHeight(qMin(rect.height() >>1 - 1, startRect.height()));
         endRect = startRect.translated(0, rect.height() - startRect.height());
         middleRect.adjust(0, startRect.height(), 0, -startRect.height());
     }
@@ -615,9 +610,7 @@ QPixmap QS60StylePrivate::cachedFrame(SkinFrameElements frame, const QSize &size
 
 void QS60StylePrivate::refreshUI()
 {
-    QList<QWidget *> widgets = QApplication::allWidgets(); 
-
-    // The following is similar to updateWidgets in qstylesheetstyle.cpp.
+    QList<QWidget *> widgets = QApplication::allWidgets();
 
     for (int i = 0; i < widgets.size(); ++i) {
         QWidget *widget = widgets.at(i);
@@ -662,7 +655,7 @@ void QS60StylePrivate::setThemePalette(QWidget *widget) const
     QPalette widgetPalette = widget->palette();
 
     //header view and its viewport need to be set 100% transparent button color, since drawing code will
-    //draw transparent theme graphics there.
+    //draw transparent theme graphics to table column and row headers.
     if (qobject_cast<QHeaderView *>(widget)){
         widgetPalette.setColor(QPalette::Active, QPalette::ButtonText,
             QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 23, 0));
@@ -696,20 +689,21 @@ void QS60StylePrivate::setThemePalette(QPalette *palette) const
     palette->setColor(QPalette::LinkVisited, palette->color(QPalette::Link).darker());
     palette->setColor(QPalette::Highlight,
             QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnHighlightColors, 2, 0));
+    // set background image as a texture brush
+    palette->setBrush(QPalette::Window, QS60StylePrivate::backgroundTexture());
     // set these as transparent so that styled full screen theme background is visible
     palette->setColor(QPalette::AlternateBase, Qt::transparent);
-    palette->setBrush(QPalette::Window, QS60StylePrivate::backgroundTexture());
-    palette->setColor(QPalette::Base, Qt::transparent);
+    palette->setBrush(QPalette::Base, Qt::transparent);
     // set button and tooltipbase based on pixel colors
     const QColor buttonColor = this->colorFromFrameGraphics(QS60StylePrivate::SF_ButtonNormal);
     palette->setColor(QPalette::Button, buttonColor );
+    const QColor toolTipColor = this->colorFromFrameGraphics(QS60StylePrivate::SF_ToolTip);
+    palette->setColor(QPalette::ToolTipBase, toolTipColor );
     palette->setColor(QPalette::Light, palette->color(QPalette::Button).lighter());
     palette->setColor(QPalette::Dark, palette->color(QPalette::Button).darker());
     palette->setColor(QPalette::Midlight, palette->color(QPalette::Button).lighter(125));
     palette->setColor(QPalette::Mid, palette->color(QPalette::Button).darker(150));
     palette->setColor(QPalette::Shadow, Qt::black);
-    QColor toolTipColor = this->colorFromFrameGraphics(QS60StylePrivate::SF_ToolTip);
-    palette->setColor(QPalette::ToolTipBase, toolTipColor );
 
     setThemePaletteHash(palette);
     QS60StylePrivate::storeThemePalette(palette);
@@ -733,6 +727,8 @@ void QS60StylePrivate::setThemePaletteHash(QPalette *palette) const
 
     //store the original palette
     QPalette widgetPalette = *palette;
+    const QColor mainAreaTextColor =
+        QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 6, 0);
 
     widgetPalette.setColor(QPalette::All, QPalette::WindowText,
         QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnLineColors, 8, 0));
@@ -740,20 +736,16 @@ void QS60StylePrivate::setThemePaletteHash(QPalette *palette) const
     // return to original palette after each widget
     widgetPalette = *palette;
 
-    widgetPalette.setColor(QPalette::Active, QPalette::ButtonText,
-        QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 6, 0));
-    widgetPalette.setColor(QPalette::Inactive, QPalette::ButtonText,
-        QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 6, 0));
+    widgetPalette.setColor(QPalette::Active, QPalette::ButtonText, mainAreaTextColor);
+    widgetPalette.setColor(QPalette::Inactive, QPalette::ButtonText, mainAreaTextColor);
     const QStyleOption opt;
     widgetPalette.setColor(QPalette::Disabled, QPalette::ButtonText,
         QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 6, &opt));
     QApplication::setPalette(widgetPalette, "QPushButton");
     widgetPalette = *palette;
 
-    widgetPalette.setColor(QPalette::Active, QPalette::ButtonText,
-        QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 6, 0));
-    widgetPalette.setColor(QPalette::Inactive, QPalette::ButtonText,
-        QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 6, 0));
+    widgetPalette.setColor(QPalette::Active, QPalette::ButtonText, mainAreaTextColor);
+    widgetPalette.setColor(QPalette::Inactive, QPalette::ButtonText, mainAreaTextColor);
     QApplication::setPalette(widgetPalette, "QToolButton");
     widgetPalette = *palette;
 
@@ -782,11 +774,10 @@ void QS60StylePrivate::setThemePaletteHash(QPalette *palette) const
     QApplication::setPalette(widgetPalette, "QLineEdit");
     widgetPalette = *palette;
 
-    const QColor color(QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 6, 0));
-    widgetPalette.setColor(QPalette::WindowText, color);
+    widgetPalette.setColor(QPalette::WindowText, mainAreaTextColor);
     widgetPalette.setColor(QPalette::Button, QApplication::palette().color(QPalette::Button));
-    widgetPalette.setColor(QPalette::Dark, color.darker());
-    widgetPalette.setColor(QPalette::Light, color.lighter());
+    widgetPalette.setColor(QPalette::Dark, mainAreaTextColor.darker());
+    widgetPalette.setColor(QPalette::Light, mainAreaTextColor.lighter());
     QApplication::setPalette(widgetPalette, "QDial");
     widgetPalette = *palette;
 
@@ -870,14 +861,6 @@ QSize QS60StylePrivate::partSize(QS60StyleEnums::SkinParts part, SkinElementFlag
   \sa QMacStyle, QWindowsStyle, QWindowsXPStyle, QWindowsVistaStyle, QPlastiqueStyle, QCleanlooksStyle, QMotifStyle
 */
 
-/*!
-  Constructs a QS60Style object.
-*/
-QS60Style::QS60Style()
-    : QCommonStyle(*new QS60StylePrivate)
-{
-}
-
 QS60Style::~QS60Style()
 {
 }
@@ -903,7 +886,7 @@ void QS60Style::drawComplexControl(ComplexControl control, const QStyleOptionCom
                 horizontal ? QS60StylePrivate::SE_ScrollBarGrooveHorizontal : QS60StylePrivate::SE_ScrollBarGrooveVertical;
             QS60StylePrivate::drawSkinElement(grooveElement, painter, grooveRect, flags);
 
-            QStyle::SubControls subControls = optionSlider->subControls;
+            const QStyle::SubControls subControls = optionSlider->subControls;
 
             // select correct slider (horizontal/vertical/pressed)
             const bool sliderPressed = ((optionSlider->state & QStyle::State_Sunken) && (subControls & SC_ScrollBarSlider));
@@ -955,7 +938,6 @@ void QS60Style::drawComplexControl(ComplexControl control, const QStyleOptionCom
         if (const QStyleOptionComboBox *cmb = qstyleoption_cast<const QStyleOptionComboBox *>(option)) {
             const QRect cmbxEditField = subControlRect(CC_ComboBox, option, SC_ComboBoxEditField, widget);
             const QRect cmbxFrame = subControlRect(CC_ComboBox, option, SC_ComboBoxFrame, widget);
-
             const bool direction = cmb->direction == Qt::LeftToRight;
 
             // Button frame
@@ -973,8 +955,9 @@ void QS60Style::drawComplexControl(ComplexControl control, const QStyleOptionCom
             const QS60StylePrivate::SkinElements skinElement = QS60StylePrivate::SE_FrameLineEdit;
             QS60StylePrivate::drawSkinElement(skinElement, painter, cmbxEditField, flags);
 
+            // Draw the combobox arrow
             if (sub & SC_ComboBoxArrow) {
-                // Draw the little arrow
+                // Make rect slightly smaller
                 buttonOption.rect.adjust(1, 1, -1, -1);
                 painter->save();
                 painter->setPen(option->palette.buttonText().color());
@@ -1115,14 +1098,13 @@ void QS60Style::drawComplexControl(ComplexControl control, const QStyleOptionCom
 
             if (spinBox->subControls & SC_SpinBoxUp) {
                 copy.subControls = SC_SpinBoxUp;
-                QPalette pal2 = spinBox->palette;
+                QPalette spinBoxPal = spinBox->palette;
                 if (!(spinBox->stepEnabled & QAbstractSpinBox::StepUpEnabled)) {
-                    pal2.setCurrentColorGroup(QPalette::Disabled);
+                    spinBoxPal.setCurrentColorGroup(QPalette::Disabled);
                     copy.state &= ~State_Enabled;
+                    copy.palette = spinBoxPal;
                 }
 
-                copy.palette = pal2;
-
                 if (spinBox->activeSubControls == SC_SpinBoxUp && (spinBox->state & State_Sunken)) {
                     copy.state |= State_On;
                     copy.state |= State_Sunken;
@@ -1130,8 +1112,9 @@ void QS60Style::drawComplexControl(ComplexControl control, const QStyleOptionCom
                     copy.state |= State_Raised;
                     copy.state &= ~State_Sunken;
                 }
-                pe = (spinBox->buttonSymbols == QAbstractSpinBox::PlusMinus ? PE_IndicatorSpinPlus
-                      : PE_IndicatorSpinUp);
+                pe = (spinBox->buttonSymbols == QAbstractSpinBox::PlusMinus) ? 
+                      PE_IndicatorSpinPlus :
+                      PE_IndicatorSpinUp;
 
                 copy.rect = subControlRect(CC_SpinBox, spinBox, SC_SpinBoxUp, widget);
                 drawPrimitive(PE_PanelButtonBevel, &copy, painter, widget);
@@ -1142,12 +1125,12 @@ void QS60Style::drawComplexControl(ComplexControl control, const QStyleOptionCom
             if (spinBox->subControls & SC_SpinBoxDown) {
                 copy.subControls = SC_SpinBoxDown;
                 copy.state = spinBox->state;
-                QPalette pal2 = spinBox->palette;
+                QPalette spinBoxPal = spinBox->palette;
                 if (!(spinBox->stepEnabled & QAbstractSpinBox::StepDownEnabled)) {
-                    pal2.setCurrentColorGroup(QPalette::Disabled);
+                    spinBoxPal.setCurrentColorGroup(QPalette::Disabled);
                     copy.state &= ~State_Enabled;
+                    copy.palette = spinBoxPal;
                 }
-                copy.palette = pal2;
 
                 if (spinBox->activeSubControls == SC_SpinBoxDown && (spinBox->state & State_Sunken)) {
                     copy.state |= State_On;
@@ -1156,8 +1139,9 @@ void QS60Style::drawComplexControl(ComplexControl control, const QStyleOptionCom
                     copy.state |= State_Raised;
                     copy.state &= ~State_Sunken;
                 }
-                pe = (spinBox->buttonSymbols == QAbstractSpinBox::PlusMinus ? PE_IndicatorSpinMinus
-                      : PE_IndicatorSpinDown);
+                pe = (spinBox->buttonSymbols == QAbstractSpinBox::PlusMinus) ? 
+                      PE_IndicatorSpinMinus :
+                      PE_IndicatorSpinDown;
 
                 copy.rect = subControlRect(CC_SpinBox, spinBox, SC_SpinBoxDown, widget);
                 drawPrimitive(PE_PanelButtonBevel, &copy, painter, widget);
@@ -1365,13 +1349,12 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
 
             // draw themed background for table unless background brush has been defined.
             if (vopt->backgroundBrush == Qt::NoBrush) {
-                // draw the background
                 const QStyleOptionViewItemV4 *tableOption = qstyleoption_cast<const QStyleOptionViewItemV4 *>(option);
                 const QTableView *table = qobject_cast<const QTableView *>(widget);
                 if (table && tableOption) {
                     const QModelIndex index = tableOption->index;
                     //todo: Draw cell background only once - for the first cell.
-                    QStyleOptionViewItemV4 voptAdj2 = voptAdj2;
+                    QStyleOptionViewItemV4 voptAdj2 = voptAdj;
                     const QModelIndex indexFirst = table->model()->index(0,0);
                     const QModelIndex indexLast = table->model()->index(
                         table->model()->rowCount()-1,table->model()->columnCount()-1);
@@ -1397,7 +1380,7 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
                      listView &&
                      (listView->selectionMode() == QAbstractItemView::SingleSelection ||
                      listView->selectionMode() == QAbstractItemView::NoSelection);
-                 QRect selectionRect = subElementRect(SE_ItemViewItemCheckIndicator, &voptAdj, widget);
+                 const QRect selectionRect = subElementRect(SE_ItemViewItemCheckIndicator, &voptAdj, widget);
                  if (voptAdj.state & QStyle::State_Selected && !singleSelection) {
                      QStyleOptionViewItemV4 option(voptAdj);
                      option.rect = selectionRect;
@@ -1434,9 +1417,11 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
                 const QStyleOptionViewItemV4 *tableOption = qstyleoption_cast<const QStyleOptionViewItemV4 *>(option);
                 if (isSelected) {
                     if (qobject_cast<const QTableView *>(widget) && tableOption)
-                        voptAdj.palette.setColor(QPalette::Text, QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 11, 0));
+                        voptAdj.palette.setColor(
+                            QPalette::Text, QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 11, 0));
                     else
-                        voptAdj.palette.setColor(QPalette::Text, QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 10, 0));
+                        voptAdj.palette.setColor(
+                            QPalette::Text, QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 10, 0));
                 }
                 painter->setPen(voptAdj.palette.text().color());
                 d->viewItemDrawText(painter, &voptAdj, textRect);
@@ -1534,7 +1519,7 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
             }
             painter->save();
             QFont f = painter->font();
-            f.setPointSizeF(f.pointSizeF() * 0.72);
+            f.setPointSizeF(f.pointSizeF() * KTabFontMul);
             painter->setFont(f);
 
             if (option->state & QStyle::State_Selected){
@@ -1542,27 +1527,27 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
                     QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors, 3, option));
             }
 
-            bool verticalTabs = optionTab.shape == QTabBar::RoundedEast
+            const bool verticalTabs = optionTab.shape == QTabBar::RoundedEast
                                 || optionTab.shape == QTabBar::RoundedWest
                                 || optionTab.shape == QTabBar::TriangularEast
                                 || optionTab.shape == QTabBar::TriangularWest;
-            bool selected = optionTab.state & State_Selected;
+            const bool selected = optionTab.state & State_Selected;
             if (verticalTabs) {
                 painter->save();
-                int newX, newY, newRot;
+                int newX, newY, newRotation;
                 if (optionTab.shape == QTabBar::RoundedEast || optionTab.shape == QTabBar::TriangularEast) {
                     newX = tr.width();
                     newY = tr.y();
-                    newRot = 90;
+                    newRotation = 90;
                 } else {
                     newX = 0;
                     newY = tr.y() + tr.height();
-                    newRot = -90;
+                    newRotation = -90;
                 }
                 tr.setRect(0, 0, tr.height(), tr.width());
                 QTransform m;
                 m.translate(newX, newY);
-                m.rotate(newRot);
+                m.rotate(newRotation);
                 painter->setTransform(m, true);
             }
             tr.adjust(0, 0, pixelMetric(QStyle::PM_TabBarTabShiftHorizontal, tab, widget),
@@ -1584,9 +1569,13 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
                 QPixmap tabIcon = optionTab.icon.pixmap(iconSize,
                     (optionTab.state & State_Enabled) ? QIcon::Normal : QIcon::Disabled);
                 if (tab->text.isEmpty())
-                    painter->drawPixmap(tr.center().x() - (tabIcon.height() >>1), tr.center().y() - (tabIcon.height() >>1), tabIcon);
+                    painter->drawPixmap(tr.center().x() - (tabIcon.height() >>1), 
+                                        tr.center().y() - (tabIcon.height() >>1), 
+                                        tabIcon);
                 else
-                    painter->drawPixmap(tr.left() + tabOverlap, tr.center().y() - (tabIcon.height() >>1), tabIcon);
+                    painter->drawPixmap(tr.left() + tabOverlap, 
+                                        tr.center().y() - (tabIcon.height() >>1), 
+                                        tabIcon);
                 tr.setLeft(tr.left() + iconSize.width() + 4);
             }
 
@@ -1596,13 +1585,13 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
 
             if (optionTab.state & State_HasFocus) {
                 const int OFFSET = 1 + pixelMetric(PM_DefaultFrameWidth);
-                const int x1 = optionTab.rect.left();
-                const int x2 = optionTab.rect.right() - 1;
+                const int leftBorder = optionTab.rect.left();
+                const int rightBorder = optionTab.rect.right() - 1;
 
                 QStyleOptionFocusRect fropt;
                 fropt.QStyleOption::operator=(*tab);
-                fropt.rect.setRect(x1 + 1 + OFFSET, optionTab.rect.y() + OFFSET,
-                                   x2 - x1 - 2*OFFSET, optionTab.rect.height() - 2*OFFSET);
+                fropt.rect.setRect(leftBorder + 1 + OFFSET, optionTab.rect.y() + OFFSET,
+                                   rightBorder - leftBorder - 2*OFFSET, optionTab.rect.height() - 2*OFFSET);
                 drawPrimitive(PE_FrameFocusRect, &fropt, painter, widget);
             }
 
@@ -1652,25 +1641,12 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
         }
         break;
 #endif // QT_NO_PROGRESSBAR
-#ifndef QT_NO_MENUBAR
-#endif //QT_NO_MENUBAR
 #ifndef QT_NO_MENU
     case CE_MenuItem:
         if (const QStyleOptionMenuItem *menuItem = qstyleoption_cast<const QStyleOptionMenuItem *>(option)) {
             QStyleOptionMenuItem optionMenuItem = *menuItem;
-            const bool enabled = optionMenuItem.state & State_Enabled;
-            const bool checkable = optionMenuItem.checkType != QStyleOptionMenuItem::NotCheckable;
-
-            uint text_flags = Qt::AlignLeading | Qt::TextShowMnemonic | Qt::TextDontClip
-                            | Qt::TextSingleLine | Qt::AlignVCenter;
-            if (!styleHint(SH_UnderlineShortcut, menuItem, widget))
-                text_flags |= Qt::TextHideMnemonic;
-
-            QRect iconRect =
-                subElementRect(SE_ItemViewItemDecoration, &optionMenuItem, widget);
-            QRect textRect = subElementRect(SE_ItemViewItemText, &optionMenuItem, widget);
+            
             bool drawSubMenuIndicator = false;
-
             switch(menuItem->menuItemType) {
                 case QStyleOptionMenuItem::Scroller:
                 case QStyleOptionMenuItem::Separator:
@@ -1681,20 +1657,29 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
                 default:
                     break;
             }
+            const bool enabled = optionMenuItem.state & State_Enabled;
+            const bool checkable = optionMenuItem.checkType != QStyleOptionMenuItem::NotCheckable;
+
+            uint text_flags = Qt::AlignLeading | Qt::TextShowMnemonic | Qt::TextDontClip
+                            | Qt::TextSingleLine | Qt::AlignVCenter;
+            if (!styleHint(SH_UnderlineShortcut, menuItem, widget))
+                text_flags |= Qt::TextHideMnemonic;
+
+            QRect iconRect =
+                subElementRect(SE_ItemViewItemDecoration, &optionMenuItem, widget);
+            QRect textRect = subElementRect(SE_ItemViewItemText, &optionMenuItem, widget);
 
             if ((option->state & State_Selected) && (option->state & State_Enabled))
                 QS60StylePrivate::drawSkinElement(QS60StylePrivate::SE_ListHighlight, painter, option->rect, flags);
 
             //todo: move the vertical spacing stuff into subElementRect
             const int vSpacing = QS60StylePrivate::pixelMetric(QStyle::PM_LayoutVerticalSpacing);
-            QStyleOptionMenuItem optionCheckBox;
             if (checkable){
-                QRect checkBoxRect = optionMenuItem.rect;
-                checkBoxRect.setWidth(pixelMetric(PM_IndicatorWidth));
-                checkBoxRect.setHeight(pixelMetric(PM_IndicatorHeight));
+                QStyleOptionMenuItem optionCheckBox;
                 optionCheckBox.QStyleOption::operator=(*menuItem);
-                optionCheckBox.rect = checkBoxRect;
-                const int moveByX = checkBoxRect.width()+vSpacing;
+                optionCheckBox.rect.setWidth(pixelMetric(PM_IndicatorWidth));
+                optionCheckBox.rect.setHeight(pixelMetric(PM_IndicatorHeight));
+                const int moveByX = optionCheckBox.rect.width()+vSpacing;
                 if (optionMenuItem.direction == Qt::LeftToRight) {
                     textRect.translate(moveByX,0);
                     iconRect.translate(moveByX, 0);
@@ -1745,20 +1730,18 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
                         optionMenuItem.palette.color(QPalette::Disabled, QPalette::Text)));
                 painter->save();
                 painter->setOpacity(0.5);
-                QCommonStyle::drawItemText(painter, textRect, text_flags,
+            }
+            QCommonStyle::drawItemText(painter, textRect, text_flags,
                     optionMenuItem.palette, enabled,
                     optionMenuItem.text, QPalette::Text);
+            if (!enabled)
                 painter->restore();
-            } else {
-                QCommonStyle::drawItemText(painter, textRect, text_flags,
-                        optionMenuItem.palette, enabled,
-                        optionMenuItem.text, QPalette::Text);
-            }
         }
         break;
+    case CE_MenuEmptyArea:
+        break;
 #endif //QT_NO_MENU
 
-    case CE_MenuEmptyArea:
 #ifndef QT_NO_MENUBAR
     case CE_MenuBarEmptyArea:
         break;
@@ -1788,19 +1771,19 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
     case CE_HeaderEmptyArea:
         {
             QS60StylePrivate::SkinElementFlags adjFlags = flags;
-            QRect mtyRect = option->rect;
+            QRect emptyAreaRect = option->rect;
             if (option->state & QStyle::State_Horizontal) {
-                mtyRect.adjust(-2,-2,2,-2);
+            emptyAreaRect.adjust(-2,-2,2,-2);
             } else {
                 if ( option->direction == Qt::LeftToRight ) {
-                    mtyRect.adjust(-2,-2,0,2);
+                emptyAreaRect.adjust(-2,-2,0,2);
                     adjFlags |= QS60StylePrivate::SF_PointWest;
                 } else {
-                    mtyRect.adjust(2,2,0,-2);
+                emptyAreaRect.adjust(2,2,0,-2);
                     adjFlags |= QS60StylePrivate::SF_PointEast;
                 }
             }
-            QS60StylePrivate::drawSkinElement(QS60StylePrivate::SE_TableHeaderItem, painter, mtyRect, adjFlags);
+            QS60StylePrivate::drawSkinElement(QS60StylePrivate::SE_TableHeaderItem, painter, emptyAreaRect, adjFlags);
         }
         break;
     case CE_Header:
@@ -1820,7 +1803,19 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
                 }
             }
             QS60StylePrivate::drawSkinElement(QS60StylePrivate::SE_TableHeaderItem, painter, mtyRect, adjFlags);
-            QCommonStyle::drawControl(element, header, painter, widget);
+            
+            QRegion clipRegion = painter->clipRegion();
+            painter->setClipRect(option->rect);
+            drawControl(CE_HeaderSection, header, painter, widget);
+            QStyleOptionHeader subopt = *header;
+            subopt.rect = subElementRect(SE_HeaderLabel, header, widget);
+            if (subopt.rect.isValid())
+                drawControl(CE_HeaderLabel, &subopt, painter, widget);
+            if (header->sortIndicator != QStyleOptionHeader::None) {
+                subopt.rect = subElementRect(SE_HeaderArrow, option, widget);
+                drawPrimitive(PE_IndicatorHeaderArrow, &subopt, painter, widget);
+            }
+            painter->setClipRegion(clipRegion);
         }
         break;
 #ifndef QT_NO_TOOLBAR
@@ -1828,6 +1823,7 @@ void QS60Style::drawControl(ControlElement element, const QStyleOption *option,
         if (const QStyleOptionToolBar *toolBar = qstyleoption_cast<const QStyleOptionToolBar *>(option)) {
             const QToolBar *tbWidget = qobject_cast<const QToolBar *>(widget);
 
+            //toolbar within a toolbar, skip
             if (!tbWidget || (widget && qobject_cast<QToolBar *>(widget->parentWidget())))
                 break;
 
@@ -1903,6 +1899,7 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
         }
         break;
     case PE_IndicatorViewItemCheck:
+#ifndef QT_NO_ITEMVIEWS
         if (const QListView *listItem = (qobject_cast<const QListView *>(widget))) {
             if (const QStyleOptionViewItemV4 *vopt = qstyleoption_cast<const QStyleOptionViewItemV4 *>(option)) {
                 const bool checkBoxVisible = vopt->features & QStyleOptionViewItemV2::HasCheckIndicator;
@@ -1923,9 +1920,9 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
                 }
             }
         }
+#endif //QT_NO_ITEMVIEWS
         break;
-    case PE_IndicatorRadioButton:
-        {
+    case PE_IndicatorRadioButton: {
             QRect buttonRect = option->rect;
             //there is empty (a. 33%) space in svg graphics for radiobutton
             const qreal reduceWidth = (qreal)buttonRect.width()/3.0;
@@ -1948,8 +1945,7 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
     case PE_PanelButtonCommand:
     case PE_PanelButtonTool:
     case PE_PanelButtonBevel:
-    case PE_FrameButtonBevel:
-        {
+    case PE_FrameButtonBevel: {
         const bool isPressed = option->state & QStyle::State_Sunken;
         const QS60StylePrivate::SkinElements skinElement =
             isPressed ? QS60StylePrivate::SE_ButtonPressed : QS60StylePrivate::SE_ButtonNormal;
@@ -1960,8 +1956,7 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
     case PE_IndicatorArrowDown:
     case PE_IndicatorArrowLeft:
     case PE_IndicatorArrowRight:
-    case PE_IndicatorArrowUp:
-        {
+    case PE_IndicatorArrowUp: {
         QS60StyleEnums::SkinParts skinPart;
         if (element==PE_IndicatorArrowDown)
             skinPart = QS60StyleEnums::SP_QgnGrafScrollArrowDown;
@@ -2016,6 +2011,7 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
         break;
 #endif //QT_NO_SPINBOX
     case PE_FrameFocusRect:
+// Calendar widget and combox both do not use styled itemDelegate
         if (!(widget && qobject_cast<const QCalendarWidget *>(widget->parent())) ||
                         qobject_cast<const QComboBoxListView *>(widget)) {
             // no focus selection for touch
@@ -2046,11 +2042,16 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
         }
         break;
     case PE_Widget:
-        if (QS60StylePrivate::drawsOwnThemeBackground(widget) ||
-            qobject_cast<const QComboBoxListView *>(widget) ||
-            qobject_cast<const QMenu *> (widget)) {
-                QS60StylePrivate::SkinElements skinElement = QS60StylePrivate::SE_OptionsMenu;
-                QS60StylePrivate::drawSkinElement(skinElement, painter, option->rect, flags);
+        if (QS60StylePrivate::drawsOwnThemeBackground(widget)
+#ifndef QT_NO_COMBOBOX
+            || qobject_cast<const QComboBoxListView *>(widget)
+#endif //QT_NO_COMBOBOX
+#ifndef QT_NO_MENU
+            || qobject_cast<const QMenu *> (widget)
+#endif //QT_NO_MENU
+            ) {
+            QS60StylePrivate::SkinElements skinElement = QS60StylePrivate::SE_OptionsMenu;
+            QS60StylePrivate::drawSkinElement(skinElement, painter, option->rect, flags);
         }
         break;
     case PE_FrameWindow:
@@ -2116,8 +2117,8 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
         break; //disable frame in menu
 
     case PE_IndicatorBranch:
-        {
 #if defined(Q_WS_S60)
+        // 3.1 AVKON UI does not have tree view component, use common style for drawing there
         if (QSysInfo::s60Version() == QSysInfo::SV_S60_3_1) {
 #else
         if (true) {
@@ -2159,7 +2160,6 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
                 QS60StylePrivate::drawSkinPart(skinPart, painter, iconRect, flags);
             }
         }
-        }
         break;
 
         // todo: items are below with #ifdefs "just in case". in final version, remove all non-required cases
@@ -2192,9 +2192,7 @@ void QS60Style::drawPrimitive(PrimitiveElement element, const QStyleOption *opti
     }
 }
 
-/*!
-  \reimp
-*/
+/*! \reimp */
 int QS60Style::pixelMetric(PixelMetric metric, const QStyleOption *option, const QWidget *widget) const
 {
     int metricValue = QS60StylePrivate::pixelMetric(metric);
@@ -2210,6 +2208,7 @@ int QS60Style::pixelMetric(PixelMetric metric, const QStyleOption *option, const
     }
     return metricValue;
 }
+
 /*! \reimp */
 QSize QS60Style::sizeFromContents(ContentsType ct, const QStyleOption *opt,
                                   const QSize &csz, const QWidget *widget) const
@@ -2232,22 +2231,19 @@ QSize QS60Style::sizeFromContents(ContentsType ct, const QStyleOption *opt,
     }
     return sz;
 }
+
 /*! \reimp */
 int QS60Style::styleHint(StyleHint sh, const QStyleOption *opt, const QWidget *widget,
                             QStyleHintReturn *hret) const
 {
     int retValue = -1;
     switch (sh) {
-        case SH_Table_GridLineColor: {
-            QColor lineColor = QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnLineColors,2,0);
-            retValue = lineColor.rgb();
-        }
-        break;
-        case SH_GroupBox_TextLabelColor: {
-            QColor groupBoxTxtColor = QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors,6,0);
-            retValue = groupBoxTxtColor.rgb();
-        }
-        break;
+        case SH_Table_GridLineColor:
+            retValue = QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnLineColors,2,0).rgb();
+            break;
+        case SH_GroupBox_TextLabelColor:
+            retValue = QS60StylePrivate::s60Color(QS60StyleEnums::CL_QsnTextColors,6,0).rgb();
+            break;
         case SH_ScrollBar_ScrollWhenPointerLeavesControl:
             retValue = true;
             break;
@@ -2273,10 +2269,7 @@ int QS60Style::styleHint(StyleHint sh, const QStyleOption *opt, const QWidget *w
     return retValue;
 }
 
-
-/*!
-    \reimp
-*/
+/*! \reimp */
 QRect QS60Style::subControlRect(ComplexControl control, const QStyleOptionComplex *option, SubControl scontrol, const QWidget *widget) const
 {
     QRect ret;
@@ -2311,35 +2304,33 @@ QRect QS60Style::subControlRect(ComplexControl control, const QStyleOptionComple
                                                             scrollbarOption->upsideDown);
 
             switch (scontrol) {
-            case SC_ScrollBarSubLine:            // top/left button
-            case SC_ScrollBarAddLine:            // bottom/right button
-                break;
-            case SC_ScrollBarSubPage:            // between top/left button and slider
-                if (isHorizontal)
-                    ret.setRect(0, 0, sliderstart, scrollBarRect.height());
-                else
-                    ret.setRect(0, 0, scrollBarRect.width(), sliderstart);
-                break;
-            case SC_ScrollBarAddPage:            // between bottom/right button and slider
-                {
+                case SC_ScrollBarSubPage:            // between top/left button and slider
+                    if (isHorizontal)
+                        ret.setRect(0, 0, sliderstart, scrollBarRect.height());
+                    else
+                        ret.setRect(0, 0, scrollBarRect.width(), sliderstart);
+                    break;
+                case SC_ScrollBarAddPage: {         // between bottom/right button and slider
                     const int addPageLength = sliderstart + sliderlen;
                     if (isHorizontal)
                         ret = scrollBarRect.adjusted(addPageLength, 0, 0, 0);
                     else
                         ret = scrollBarRect.adjusted(0, addPageLength, 0, 0);
-                }
-                break;
-            case SC_ScrollBarGroove:
-                ret = scrollBarRect;
-                break;
-            case SC_ScrollBarSlider:
-                if (scrollbarOption->orientation == Qt::Horizontal)
-                    ret.setRect(sliderstart, 0, sliderlen, scrollBarRect.height());
-                else
-                    ret.setRect(0, sliderstart, scrollBarRect.width(), sliderlen);
-                break;
-            default:
-                break;
+                    }
+                    break;
+                case SC_ScrollBarGroove:
+                    ret = scrollBarRect;
+                    break;
+                case SC_ScrollBarSlider:
+                    if (scrollbarOption->orientation == Qt::Horizontal)
+                        ret.setRect(sliderstart, 0, sliderlen, scrollBarRect.height());
+                    else
+                        ret.setRect(0, sliderstart, scrollBarRect.width(), sliderlen);
+                    break;
+                case SC_ScrollBarSubLine:            // top/left button
+                case SC_ScrollBarAddLine:            // bottom/right button
+                default:
+                    break;
             }
             ret = visualRect(scrollbarOption->direction, scrollBarRect, ret);
         }
@@ -2357,37 +2348,37 @@ QRect QS60Style::subControlRect(ComplexControl control, const QStyleOptionComple
 
             const int y = frameThickness + spinbox->rect.y();
             const int x = spinbox->rect.x() + spinbox->rect.width() - frameThickness - 2*buttonSize.width();
-
+            
             switch (scontrol) {
-            case SC_SpinBoxUp:
-                if (spinbox->buttonSymbols == QAbstractSpinBox::NoButtons)
-                    return QRect();
-                ret = QRect(x, y, buttonWidth, buttonSize.height());
-                break;
-            case SC_SpinBoxDown:
-                if (spinbox->buttonSymbols == QAbstractSpinBox::NoButtons)
-                    return QRect();
-                ret = QRect(x+buttonSize.width(), y, buttonWidth, buttonSize.height());
-                break;
-            case SC_SpinBoxEditField:
-                if (spinbox->buttonSymbols == QAbstractSpinBox::NoButtons)
-                    ret = QRect(
-                        frameThickness,
-                        frameThickness,
-                        spinbox->rect.width() - 2*frameThickness,
-                        spinbox->rect.height() - 2*frameThickness);
-                else
-                    ret = QRect(
-                        frameThickness,
-                        frameThickness,
-                        x - frameThickness,
-                        spinbox->rect.height() - 2*frameThickness);
-                break;
-            case SC_SpinBoxFrame:
-                ret = spinbox->rect;
-                break;
-            default:
-                break;
+                case SC_SpinBoxUp:
+                    if (spinbox->buttonSymbols == QAbstractSpinBox::NoButtons)
+                        return QRect();
+                    ret = QRect(x, y, buttonWidth, buttonSize.height());
+                    break;
+                case SC_SpinBoxDown:
+                    if (spinbox->buttonSymbols == QAbstractSpinBox::NoButtons)
+                        return QRect();
+                    ret = QRect(x+buttonSize.width(), y, buttonWidth, buttonSize.height());
+                    break;
+                case SC_SpinBoxEditField:
+                    if (spinbox->buttonSymbols == QAbstractSpinBox::NoButtons)
+                        ret = QRect(
+                                frameThickness,
+                                frameThickness,
+                                spinbox->rect.width() - 2*frameThickness,
+                                spinbox->rect.height() - 2*frameThickness);
+                    else
+                        ret = QRect(
+                                frameThickness,
+                                frameThickness,
+                                x - frameThickness,
+                                spinbox->rect.height() - 2*frameThickness);
+                    break;
+                case SC_SpinBoxFrame:
+                    ret = spinbox->rect;
+                    break;
+                default:
+                    break;
             }
         ret = visualRect(spinbox->direction, spinbox->rect, ret);
         }
@@ -2401,7 +2392,7 @@ QRect QS60Style::subControlRect(ComplexControl control, const QStyleOptionComple
             // lets use spinbox frame here as well, as no combobox specific value available.
             const int frameThickness = cmb->frame ? pixelMetric(PM_SpinBoxFrameWidth, cmb, widget) : 0;
             const int buttonWidth = QS60StylePrivate::pixelMetric(QStyle::PM_ButtonIconSize);
-            int xposMod = (cmb->rect.x()) + width - buttonMargin - buttonWidth;
+            const int xposMod = (cmb->rect.x()) + width - buttonMargin - buttonWidth;
             const int ypos = cmb->rect.y();
 
             QSize buttonSize;
@@ -2430,26 +2421,26 @@ QRect QS60Style::subControlRect(ComplexControl control, const QStyleOptionComple
         if (const QStyleOptionGroupBox *groupBox = qstyleoption_cast<const QStyleOptionGroupBox *>(option)) {
             ret = QCommonStyle::subControlRect(control, option, scontrol, widget);
             switch (scontrol) {
-            case SC_GroupBoxCheckBox: //fallthrough
-            case SC_GroupBoxLabel: {
-                //slightly indent text and boxes, so that dialog border does not mess with them.
-                const int horizontalSpacing =
-                    QS60StylePrivate::pixelMetric(QStyle::PM_LayoutHorizontalSpacing);
-                ret.adjust(2,horizontalSpacing-3,0,0);
-                }
-                break;
-            case SC_GroupBoxFrame: {
-                const QRect textBox = subControlRect(control, option, SC_GroupBoxLabel, widget);
-                const int tbHeight = textBox.height();
-                ret.translate(0, -ret.y());
-                // include title to within the groupBox frame
-                ret.setHeight(ret.height()+tbHeight);
-                if (widget && ret.bottom() > widget->rect().bottom())
-                    ret.setBottom(widget->rect().bottom());
-                }
-                break;
-            default:
-                break;
+                case SC_GroupBoxCheckBox: //fallthrough
+                case SC_GroupBoxLabel: {
+                    //slightly indent text and boxes, so that dialog border does not mess with them.
+                    const int horizontalSpacing =
+                        QS60StylePrivate::pixelMetric(QStyle::PM_LayoutHorizontalSpacing);
+                    ret.adjust(2,horizontalSpacing-3,0,0);
+                    }
+                    break;
+                case SC_GroupBoxFrame: {
+                    const QRect textBox = subControlRect(control, option, SC_GroupBoxLabel, widget);
+                    const int tbHeight = textBox.height();
+                    ret.translate(0, -ret.y());
+                    // include title to within the groupBox frame
+                    ret.setHeight(ret.height()+tbHeight);
+                    if (widget && ret.bottom() > widget->rect().bottom())
+                        ret.setBottom(widget->rect().bottom());
+                    }
+                    break;
+                default:
+                    break;
             }
         }
         break;
@@ -2467,7 +2458,7 @@ QRect QS60Style::subElementRect(SubElement element, const QStyleOption *opt, con
             // in S60 the input text box doesn't start from line Edit's TL, but
             // a bit indented.
                 QRect lineEditRect = opt->rect;
-                int adjustment = opt->rect.height()>>2;
+                const int adjustment = opt->rect.height()>>2;
                 lineEditRect.adjust(adjustment,0,0,0);
                 ret = lineEditRect;
             }
@@ -2539,7 +2530,7 @@ QRect QS60Style::subElementRect(SubElement element, const QStyleOption *opt, con
                 }
             } else if (const QStyleOptionMenuItem *menuItem = qstyleoption_cast<const QStyleOptionMenuItem *>(opt)) {
                 const bool checkable = menuItem->checkType != QStyleOptionMenuItem::NotCheckable;
-                int indicatorWidth = checkable ?
+                const int indicatorWidth = checkable ?
                     pixelMetric(PM_ListViewIconSize, opt, widget) :
                     pixelMetric(PM_SmallIconSize, opt, widget);
                 ret = menuItem->rect;
@@ -2559,11 +2550,10 @@ QRect QS60Style::subElementRect(SubElement element, const QStyleOption *opt, con
                     // Make room for submenu indicator
                     if (menuItem->menuItemType == QStyleOptionMenuItem::SubMenu){
                         // submenu indicator is very small, so lets halve the rect
-                        indicatorWidth = indicatorWidth >> 1;
                         if (menuItem->direction == Qt::LeftToRight)
-                            ret.adjust(0,0,-indicatorWidth,0);
+                            ret.adjust(0,0,-(indicatorWidth >> 1),0);
                         else
-                            ret.adjust(indicatorWidth,0,0,0);
+                            ret.adjust((indicatorWidth >> 1),0,0,0);
                     }
                 }
             }
@@ -2592,7 +2582,9 @@ QRect QS60Style::subElementRect(SubElement element, const QStyleOption *opt, con
                     // Move rect and make it slightly smaller, so that
                     // a) highlight border does not cross the rect
                     // b) in s60 list checkbox is smaller than normal checkbox
-                    ret.setRect(opt->rect.left()+3, opt->rect.top() + heightOffset, indicatorWidth-3, indicatorHeight-3);
+                    //todo; magic three
+                    ret.setRect(opt->rect.left()+3, opt->rect.top() + heightOffset, 
+                        indicatorWidth-3, indicatorHeight-3);
                 } else {
                     ret.setRect(opt->rect.right() - indicatorWidth - spacing, opt->rect.top() + heightOffset,
                         indicatorWidth, indicatorHeight);
@@ -2667,9 +2659,8 @@ void QS60Style::unpolish(QWidget *widget)
     #ifndef QT_NO_SCROLLBAR
         || qobject_cast<QScrollBar *>(widget)
     #endif
-        ) {
+        )
         widget->setAttribute(Qt::WA_OpaquePaintEvent);
-    }
 
     if (QS60StylePrivate::drawsOwnThemeBackground(widget)) {
         widget->setAttribute(Qt::WA_StyledBackground, false);
@@ -2687,9 +2678,8 @@ void QS60Style::unpolish(QWidget *widget)
         widget->setAttribute(Qt::WA_StyledBackground, false);
     }
 
-    if (widget) {
+    if (widget)
         widget->setPalette(QPalette());
-    }
 
     QCommonStyle::unpolish(widget);
 }
@@ -2703,7 +2693,6 @@ void QS60Style::polish(QApplication *application)
 
 void QS60Style::unpolish(QApplication *application)
 {
-    Q_UNUSED(application)
     Q_D(QS60Style);
     const QPalette newPalette = QApplication::style()->standardPalette();
     application->setPalette(newPalette);
@@ -2730,7 +2719,9 @@ QIcon QS60Style::standardIconImplementation(StandardPixmap standardIcon,
     QS60StyleEnums::SkinParts part;
     QS60StylePrivate::SkinElementFlags adjustedFlags;
     if (option)
-        adjustedFlags = (option->state & State_Enabled) ?  QS60StylePrivate::SF_StateEnabled : QS60StylePrivate::SF_StateDisabled;
+        adjustedFlags = (option->state & State_Enabled) ?  
+            QS60StylePrivate::SF_StateEnabled : 
+            QS60StylePrivate::SF_StateDisabled;
 
     switch(standardIcon) {
         case QStyle::SP_MessageBoxWarning: