summaryrefslogtreecommitdiffstats
path: root/src/multimedia/audio
diff options
context:
space:
mode:
authorGareth Stockwell <ext-gareth.stockwell@nokia.com>2010-09-01 12:49:54 (GMT)
committerGareth Stockwell <ext-gareth.stockwell@nokia.com>2010-09-17 13:21:03 (GMT)
commit98b335dadef433e383d3a25dbdadbb5efe7f8429 (patch)
treeee8387c24053dd3e451f9059323646cd764beb26 /src/multimedia/audio
parent7eb0aea6d3d261b97d224b5342fac1637cb9b792 (diff)
downloadQt-98b335dadef433e383d3a25dbdadbb5efe7f8429.zip
Qt-98b335dadef433e383d3a25dbdadbb5efe7f8429.tar.gz
Qt-98b335dadef433e383d3a25dbdadbb5efe7f8429.tar.bz2
Discard empty buffer on call to QAudioOutput::resume()
The Symbian backend holds buffers which are passed to it from DevSound, exposing the memory of these buffers via the QIODevice interface. When QAudioOutput::resume() is called, the backend re-starts data flow by passing the buffer it holds back to DevSound. Previously, this would not happen if the buffer was empty, potentially causing playback to stall. This patch ensures that the buffer is always sent back to DevSound, and data flow therefore always resumes. Task-number: QTBUG-13059 Reviewed-by: Derick Hawcroft
Diffstat (limited to 'src/multimedia/audio')
-rw-r--r--src/multimedia/audio/qaudiooutput_symbian_p.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/multimedia/audio/qaudiooutput_symbian_p.cpp b/src/multimedia/audio/qaudiooutput_symbian_p.cpp
index 5098469..5054ae3 100644
--- a/src/multimedia/audio/qaudiooutput_symbian_p.cpp
+++ b/src/multimedia/audio/qaudiooutput_symbian_p.cpp
@@ -210,7 +210,7 @@ void QAudioOutputPrivate::suspend()
void QAudioOutputPrivate::resume()
{
if (SymbianAudio::SuspendedState == m_internalState) {
- if (!m_pullMode && m_devSoundBuffer && m_devSoundBuffer->Data().Length())
+ if (!m_pullMode && m_devSoundBuffer)
bufferFilled();
startPlayback();
}