diff options
author | Markus Goetz <Markus.Goetz@nokia.com> | 2009-07-15 10:40:53 (GMT) |
---|---|---|
committer | Markus Goetz <Markus.Goetz@nokia.com> | 2009-07-17 11:36:17 (GMT) |
commit | 8ab072aff0527d3ef3e44cf1ceba7dca985a6f94 (patch) | |
tree | 6a7a77a5dcea90c00ebc66c735c19af731b042f3 /src/network/access/qnetworkaccesshttpbackend.cpp | |
parent | 430f93c3649aacea5d9ccab047f036027f0622ea (diff) | |
download | Qt-8ab072aff0527d3ef3e44cf1ceba7dca985a6f94.zip Qt-8ab072aff0527d3ef3e44cf1ceba7dca985a6f94.tar.gz Qt-8ab072aff0527d3ef3e44cf1ceba7dca985a6f94.tar.bz2 |
QNetworkAccessManager: HTTP download performance improvements
Better usage of move semantics with implicit sharing to avoid
detaching (=malloc/memcpy). Also some other improvements.
Download performance improvement is around 20% according
to the httpDownloadPerformance autotest.
Reviewed-by: Thiago Macieira
Diffstat (limited to 'src/network/access/qnetworkaccesshttpbackend.cpp')
-rw-r--r-- | src/network/access/qnetworkaccesshttpbackend.cpp | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/network/access/qnetworkaccesshttpbackend.cpp b/src/network/access/qnetworkaccesshttpbackend.cpp index db84e58..9c36026 100644 --- a/src/network/access/qnetworkaccesshttpbackend.cpp +++ b/src/network/access/qnetworkaccesshttpbackend.cpp @@ -653,10 +653,15 @@ void QNetworkAccessHttpBackend::readFromHttp() // this is not a critical thing since it is already in the // memory anyway - while (httpReply->bytesAvailable() != 0 && nextDownstreamBlockSize() != 0) { - const QByteArray data = httpReply->readAny(); - writeDownstreamData(data); + QByteDataBuffer list; + + while (httpReply->bytesAvailable() != 0 && nextDownstreamBlockSize() != 0 && nextDownstreamBlockSize() > list.byteAmount()) { + QByteArray data = httpReply->readAny(); + list.append(data); } + + if (!list.isEmpty()) + writeDownstreamData(list); } void QNetworkAccessHttpBackend::replyFinished() |