diff options
author | Tom Cooksey <thomas.cooksey@nokia.com> | 2010-01-29 10:39:06 (GMT) |
---|---|---|
committer | Tom Cooksey <thomas.cooksey@nokia.com> | 2010-01-29 14:29:42 (GMT) |
commit | 9e95ce2a68ef167e17dccc5789cbf3bf74712280 (patch) | |
tree | 1fc5e33c239a32905dfd6692292e363d6783b88e /src/opengl/qgl_p.h | |
parent | e2f9547983c15be88c0a096dd52cc7c7a0eac0c6 (diff) | |
download | Qt-9e95ce2a68ef167e17dccc5789cbf3bf74712280.zip Qt-9e95ce2a68ef167e17dccc5789cbf3bf74712280.tar.gz Qt-9e95ce2a68ef167e17dccc5789cbf3bf74712280.tar.bz2 |
Fix GL texture leaks when pixmaps are deleted
This fixes quite a lot of issues:
* QtOpenGL only registered qpixmap destruction hooks on X11 and
those only cleanup the EGL/GLX surface, not the texture object.
* The QPixmap destruction hooks were only being called from the
QPixmap destructor. However, this means when a QPixmap is assigned
to another QPixmap, the hooks don't get called.
Task-number: QTBUG-7647
Reviewed-By: Samuel
Reviewed-By: Trond
Diffstat (limited to 'src/opengl/qgl_p.h')
-rw-r--r-- | src/opengl/qgl_p.h | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/opengl/qgl_p.h b/src/opengl/qgl_p.h index 0104f07..713b067 100644 --- a/src/opengl/qgl_p.h +++ b/src/opengl/qgl_p.h @@ -522,7 +522,7 @@ public: QSize bindCompressedTexturePVR(const char *buf, int len); }; -class QGLTextureCache { +class Q_AUTOTEST_EXPORT QGLTextureCache { public: QGLTextureCache(); ~QGLTextureCache(); @@ -539,11 +539,8 @@ public: static QGLTextureCache *instance(); static void deleteIfEmpty(); static void imageCleanupHook(qint64 cacheKey); - static void cleanupTextures(QPixmap* pixmap); -#ifdef Q_WS_X11 - // X11 needs to catch pixmap data destruction to delete EGL/GLX pixmap surfaces - static void cleanupPixmapSurfaces(QPixmap* pixmap); -#endif + static void cleanupTextures(QPixmapData* pixmap); + static void cleanupBeforePixmapDestruction(QPixmapData* pixmap); private: QCache<qint64, QGLTexture> m_cache; |