summaryrefslogtreecommitdiffstats
path: root/src/opengl/qpixmapdata_gl.cpp
diff options
context:
space:
mode:
authorSamuel Rødal <sroedal@trolltech.com>2009-06-17 08:25:03 (GMT)
committerSamuel Rødal <sroedal@trolltech.com>2009-06-17 08:56:33 (GMT)
commit4cacc45d10e59bb8915b8d76c359df7a8ad0a846 (patch)
tree1cc67f1bce59e9c85b9670831ab9d2acbf4b1269 /src/opengl/qpixmapdata_gl.cpp
parent583a306bb66601d4aa1ecc0429cc9e02aa6f9246 (diff)
downloadQt-4cacc45d10e59bb8915b8d76c359df7a8ad0a846.zip
Qt-4cacc45d10e59bb8915b8d76c359df7a8ad0a846.tar.gz
Qt-4cacc45d10e59bb8915b8d76c359df7a8ad0a846.tar.bz2
Prevented infinite recursion in GL graphics system.
If creating a QGLWidget triggers the creation of a QPixmap then we might end up in an infinite recursion due to QPixmap trying to access qt_gl_share_widget(). This can happen via setWindowIcon for example. Adding an initializing flag to QGLGlobalShareWidget and preventing QGLFramebufferObject::hasOpenGLFramebufferObjects() and ::hasOpenGLFramebufferBlit() from creating a QGLWidget every time they are called with no active GL context. Reviewed-by: Trond
Diffstat (limited to 'src/opengl/qpixmapdata_gl.cpp')
-rw-r--r--src/opengl/qpixmapdata_gl.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/opengl/qpixmapdata_gl.cpp b/src/opengl/qpixmapdata_gl.cpp
index 5e73ef5..f745aae 100644
--- a/src/opengl/qpixmapdata_gl.cpp
+++ b/src/opengl/qpixmapdata_gl.cpp
@@ -114,8 +114,11 @@ QGLPixmapData::~QGLPixmapData()
QGLWidget *shareWidget = qt_gl_share_widget();
if (!shareWidget)
return;
- QGLShareContextScope ctx(shareWidget->context());
- glDeleteTextures(1, &m_textureId);
+
+ if (m_textureId) {
+ QGLShareContextScope ctx(shareWidget->context());
+ glDeleteTextures(1, &m_textureId);
+ }
}
bool QGLPixmapData::isValid() const