diff options
author | Gabriel de Dietrich <gabriel.dietrich-de@nokia.com> | 2010-03-18 09:47:44 (GMT) |
---|---|---|
committer | Gabriel de Dietrich <gabriel.dietrich-de@nokia.com> | 2010-03-18 10:07:47 (GMT) |
commit | 692f12d89e6d2cf33ca2965ccd155d30ce3d32e8 (patch) | |
tree | aa9c63a9009c0f02d26619b461c9341a82264c3e /src/s60installs/selfsigned.key | |
parent | 6dcdab8d9ee66f420a525400d873cfccf78c7003 (diff) | |
download | Qt-692f12d89e6d2cf33ca2965ccd155d30ce3d32e8.zip Qt-692f12d89e6d2cf33ca2965ccd155d30ce3d32e8.tar.gz Qt-692f12d89e6d2cf33ca2965ccd155d30ce3d32e8.tar.bz2 |
Optimized visualRegionForSelection in various item views classes
When the number of selected items is large (a few thousands), the
computation of visualRegionForSelection can take a long time (up to a
few seconds). Analysis with valgrind shows that most of the time is
spent in miRegionOp (in qregion.cpp), which is being called by
QRegion::operator+=. The visualRegionForSelection virtual method being
called only to update the view after selection, we can safely ignore
those item's rectangles outside the viewport, thus both reducing the
number of calls to miRegionOp and the actual cost of each call.
This, however, introduces a behaviour change in
visualRegionForSelection, as the returned region will *not* contain
any rectangle *not* intersecting the viewport.
Reviewed-by: Thierry
Task-number: QTBUG-884
Diffstat (limited to 'src/s60installs/selfsigned.key')
0 files changed, 0 insertions, 0 deletions