diff options
author | David Boddie <dboddie@trolltech.com> | 2010-01-20 16:48:45 (GMT) |
---|---|---|
committer | David Boddie <dboddie@trolltech.com> | 2010-01-20 16:48:45 (GMT) |
commit | ed760b619ed0748d1428b9f08b785913883b560c (patch) | |
tree | 1afc57deb86fa711c54ce53c987d7f612a6f7574 /src/script/bridge/qscriptqobject.cpp | |
parent | c3637e53cb4e4d64a60664874f15292982acbdbd (diff) | |
parent | 304c70a03406eb16b9a08719769655b75bf6d8e3 (diff) | |
download | Qt-ed760b619ed0748d1428b9f08b785913883b560c.zip Qt-ed760b619ed0748d1428b9f08b785913883b560c.tar.gz Qt-ed760b619ed0748d1428b9f08b785913883b560c.tar.bz2 |
Merge branch '4.6' of git@scm.dev.nokia.troll.no:qt/oslo-staging-1 into 4.6
Diffstat (limited to 'src/script/bridge/qscriptqobject.cpp')
-rw-r--r-- | src/script/bridge/qscriptqobject.cpp | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/src/script/bridge/qscriptqobject.cpp b/src/script/bridge/qscriptqobject.cpp index fb0dddb..db312bc 100644 --- a/src/script/bridge/qscriptqobject.cpp +++ b/src/script/bridge/qscriptqobject.cpp @@ -978,7 +978,8 @@ JSC::JSValue QtFunction::execute(JSC::ExecState *exec, JSC::JSValue thisValue, QScriptObjectDelegate *delegate = scriptObject->delegate(); Q_ASSERT(delegate && (delegate->type() == QScriptObjectDelegate::QtObject)); QObject *qobj = static_cast<QScript::QObjectDelegate*>(delegate)->value(); - Q_ASSERT_X(qobj != 0, "QtFunction::call", "handle the case when QObject has been deleted"); + if (!qobj) + return JSC::throwError(exec, JSC::GeneralError, QString::fromLatin1("cannot call function of deleted QObject")); QScriptEnginePrivate *engine = scriptEngineFromExec(exec); const QMetaObject *meta = qobj->metaObject(); @@ -2219,7 +2220,14 @@ void QObjectConnectionManager::execute(int slotIndex, void **argv) JSC::call(exec, slot, callType, callData, thisObject, jscArgs); if (exec->hadException()) { - engine->emitSignalHandlerException(); + if (slot.inherits(&QtFunction::info) && !static_cast<QtFunction*>(JSC::asObject(slot))->qobject()) { + // The function threw an error because the target QObject has been deleted. + // The connections list is stale; remove the signal handler and ignore the exception. + removeSignalHandler(sender(), signalIndex, receiver, slot); + exec->clearException(); + } else { + engine->emitSignalHandlerException(); + } } } |