summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorFrans Englich <frans.englich@nokia.com>2009-09-08 21:22:54 (GMT)
committerGareth Stockwell <gareth.stockwell@sosco.com>2009-09-09 15:30:22 (GMT)
commit4bdd75bd721610b992b01c9ebc659da2a8730480 (patch)
tree10c30d8e21b446d2b6770582b8837655bbadf588 /src
parentc4fb0864e229ff33e4b454c74116573a9ea79054 (diff)
downloadQt-4bdd75bd721610b992b01c9ebc659da2a8730480.zip
Qt-4bdd75bd721610b992b01c9ebc659da2a8730480.tar.gz
Qt-4bdd75bd721610b992b01c9ebc659da2a8730480.tar.bz2
Improve signal connections between MediaObject and AbstractPlayer.
MediaObject deals with an AbstractPlayer, so make sure we have the signals declared in that base class, instead of individually in each sub-class.
Diffstat (limited to 'src')
-rw-r--r--src/3rdparty/phonon/mmf/abstractmediaplayer.cpp3
-rw-r--r--src/3rdparty/phonon/mmf/abstractmediaplayer.h6
-rw-r--r--src/3rdparty/phonon/mmf/abstractplayer.h8
-rw-r--r--src/3rdparty/phonon/mmf/audioplayer.h3
-rw-r--r--src/3rdparty/phonon/mmf/videoplayer.h4
5 files changed, 10 insertions, 14 deletions
diff --git a/src/3rdparty/phonon/mmf/abstractmediaplayer.cpp b/src/3rdparty/phonon/mmf/abstractmediaplayer.cpp
index 1e032f3..bdf188d 100644
--- a/src/3rdparty/phonon/mmf/abstractmediaplayer.cpp
+++ b/src/3rdparty/phonon/mmf/abstractmediaplayer.cpp
@@ -443,7 +443,8 @@ qint64 MMF::AbstractMediaPlayer::toMilliSeconds(const TTimeIntervalMicroSeconds
void MMF::AbstractMediaPlayer::tick()
{
- emit tick(currentTime());
+ // For the MWC compiler, we need to qualify the base class.
+ emit MMF::AbstractPlayer::tick(currentTime());
}
QT_END_NAMESPACE
diff --git a/src/3rdparty/phonon/mmf/abstractmediaplayer.h b/src/3rdparty/phonon/mmf/abstractmediaplayer.h
index f11b559..e69f325 100644
--- a/src/3rdparty/phonon/mmf/abstractmediaplayer.h
+++ b/src/3rdparty/phonon/mmf/abstractmediaplayer.h
@@ -68,7 +68,6 @@ protected:
// AbstractPlayer
virtual void doSetTickInterval(qint32 interval);
-protected:
virtual void doPlay() = 0;
virtual void doPause() = 0;
virtual void doStop() = 0;
@@ -121,11 +120,6 @@ protected:
private:
void doVolumeChanged();
-Q_SIGNALS:
- void tick(qint64 time);
- void stateChanged(Phonon::State oldState,
- Phonon::State newState);
-
private Q_SLOTS:
/**
* Receives signal from m_tickTimer
diff --git a/src/3rdparty/phonon/mmf/abstractplayer.h b/src/3rdparty/phonon/mmf/abstractplayer.h
index 0f846ca..72d0a3b 100644
--- a/src/3rdparty/phonon/mmf/abstractplayer.h
+++ b/src/3rdparty/phonon/mmf/abstractplayer.h
@@ -88,6 +88,14 @@ public:
void setVideoOutput(VideoOutput* videoOutput);
+Q_SIGNALS:
+ void totalTimeChanged(qint64 length);
+ void finished();
+ void tick(qint64 time);
+ void stateChanged(Phonon::State oldState,
+ Phonon::State newState);
+
+
protected:
virtual void videoOutputChanged();
diff --git a/src/3rdparty/phonon/mmf/audioplayer.h b/src/3rdparty/phonon/mmf/audioplayer.h
index 3245159..f16de1d 100644
--- a/src/3rdparty/phonon/mmf/audioplayer.h
+++ b/src/3rdparty/phonon/mmf/audioplayer.h
@@ -87,9 +87,6 @@ public:
#endif
CPlayerType *player() const;
-Q_SIGNALS:
- void totalTimeChanged(qint64 length);
- void finished();
private:
void construct();
diff --git a/src/3rdparty/phonon/mmf/videoplayer.h b/src/3rdparty/phonon/mmf/videoplayer.h
index 887a26b..5761ce7 100644
--- a/src/3rdparty/phonon/mmf/videoplayer.h
+++ b/src/3rdparty/phonon/mmf/videoplayer.h
@@ -73,10 +73,6 @@ public:
// VideoOutputObserver
virtual void videoOutputRegionChanged();
-Q_SIGNALS:
- void totalTimeChanged(qint64 length);
- void finished();
-
private:
void construct();
VideoOutput& videoOutput();