diff options
author | Martin Jones <martin.jones@nokia.com> | 2010-07-29 03:59:59 (GMT) |
---|---|---|
committer | Martin Jones <martin.jones@nokia.com> | 2010-07-29 03:59:59 (GMT) |
commit | 5d5feaa86f3933a1e89b53267953b86e2b0459ed (patch) | |
tree | dd7becfa769c4c75b897323d7094b8725e38b58d /src | |
parent | 34c4380219743a3b268bf1ce0be55d7291da5750 (diff) | |
download | Qt-5d5feaa86f3933a1e89b53267953b86e2b0459ed.zip Qt-5d5feaa86f3933a1e89b53267953b86e2b0459ed.tar.gz Qt-5d5feaa86f3933a1e89b53267953b86e2b0459ed.tar.bz2 |
Remove use of shared NOTIFY signals in QGraphicsScale
Sharing a NOTIFY signal can cause binding loop warnings with no apparent
cause.
Task-number: QTBUG-12333
Reviewed-by: Aaron Kennedy
Reviewed-by: Michael Brasser
Diffstat (limited to 'src')
-rw-r--r-- | src/gui/graphicsview/qgraphicstransform.cpp | 3 | ||||
-rw-r--r-- | src/gui/graphicsview/qgraphicstransform.h | 9 |
2 files changed, 9 insertions, 3 deletions
diff --git a/src/gui/graphicsview/qgraphicstransform.cpp b/src/gui/graphicsview/qgraphicstransform.cpp index 4ab6975..986bee6 100644 --- a/src/gui/graphicsview/qgraphicstransform.cpp +++ b/src/gui/graphicsview/qgraphicstransform.cpp @@ -267,6 +267,7 @@ void QGraphicsScale::setXScale(qreal scale) return; d->xScale = scale; update(); + emit xScaleChanged(); emit scaleChanged(); } @@ -293,6 +294,7 @@ void QGraphicsScale::setYScale(qreal scale) return; d->yScale = scale; update(); + emit yScaleChanged(); emit scaleChanged(); } @@ -319,6 +321,7 @@ void QGraphicsScale::setZScale(qreal scale) return; d->zScale = scale; update(); + emit zScaleChanged(); emit scaleChanged(); } diff --git a/src/gui/graphicsview/qgraphicstransform.h b/src/gui/graphicsview/qgraphicstransform.h index 58b201a..d8c9654 100644 --- a/src/gui/graphicsview/qgraphicstransform.h +++ b/src/gui/graphicsview/qgraphicstransform.h @@ -85,9 +85,9 @@ class Q_GUI_EXPORT QGraphicsScale : public QGraphicsTransform Q_OBJECT Q_PROPERTY(QVector3D origin READ origin WRITE setOrigin NOTIFY originChanged) - Q_PROPERTY(qreal xScale READ xScale WRITE setXScale NOTIFY scaleChanged) - Q_PROPERTY(qreal yScale READ yScale WRITE setYScale NOTIFY scaleChanged) - Q_PROPERTY(qreal zScale READ zScale WRITE setZScale NOTIFY scaleChanged) + Q_PROPERTY(qreal xScale READ xScale WRITE setXScale NOTIFY xScaleChanged) + Q_PROPERTY(qreal yScale READ yScale WRITE setYScale NOTIFY yScaleChanged) + Q_PROPERTY(qreal zScale READ zScale WRITE setZScale NOTIFY zScaleChanged) public: QGraphicsScale(QObject *parent = 0); ~QGraphicsScale(); @@ -108,6 +108,9 @@ public: Q_SIGNALS: void originChanged(); + void xScaleChanged(); + void yScaleChanged(); + void zScaleChanged(); void scaleChanged(); private: |